Comments (4)
To my knowledge, vimdiff only supports diffing one file at a time. Most PRs I review are multiple files.
from critiq.vim.
@AGhost-7 yeah, but it can be a queue of files to be reviewed. git difftools does that and it automatically opens the next file to be reviewed if you close the current diffs.
from critiq.vim.
Personally this isn't how I'd want to review a PR. I scan the whole changes first then look in higher detail each file. I don't think vim diff is going to work.
If you're interested in implementing this I would accept a PR as an opt-in feature (meaning the old behaviour would be the default).
from critiq.vim.
@AGhost-7 I found that in diff page I can type gf
on the diff content and go to that file. It is very useful and I dont think this feature is needed for now. Thanks!
from critiq.vim.
Related Issues (20)
- Ability to view previous file
- Review List
- Refresh comments
- Display repo in pr list
- Document mappings
- View pr commits
- Submitting images in comments
- pass GH_USER/GH_PASS differently HOT 4
- [Enhancement] Bitbucket HOT 13
- Navigate PR commit-wise HOT 1
- vim8 support
- PR List Label Filter
- Delete branch
- Utilize .netrc HOT 3
- CritiqOpenPr fails HOT 4
- Migrate to circle ci
- Approving a PR? HOT 1
- Commenting line in PR does not work HOT 1
- Integrate with fugitive for diffs HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from critiq.vim.