ads7 / isbndb-py Goto Github PK

This will allow for better overal key management, and better mimic what is
on the isbndb.com site.

this involves changing the keyfile xml a bit, and adding a .name attribute to
the Key class.

There's no license file included in the sources. The README does mention
LGPL, but not the exact version. It would be a good idea to clarify this a bit.

I'm attaching a rudimentary setup.py. No cheeseshop integration included
and I'm a bit unsure how to declare the elementtree dependency
(celementtree/elementtree/the version included in 2.5), but at least it
does manage to install the library.

Currently it only gets the first enabled key. This should also be selectable.

In keys.py, should use

sys.stderr.write

rather than sys.stdout.write. Using sys.stdout.write prevents console-based
client programs from functioning (unless they redirect the console, which
would be annoying for them to have to bother with).

No sample is provided, and AFAICT it expects XML.

In isbndb/keys.py, the constructor should be changed to read:

def __init__(self, key, name = "", force_=False):

Otherwise, the line

            try:
                key = keys.Key(key)

(which is in _get_key in file internet.py) always fails, which means that
calls like


isbndb.IsbndbSearch(searchValue=AN_ISBN, key=MY_KEY)

won't work.

Need to add docs for using the api

To show the problem:
python book.py isbnhere


This is the result that i get
Traceback (most recent call last):
  File "book.py", line 77, in <module>
    x = IsbndbGetter()
NameError: name 'IsbndbGetter' is not defined

This occurs with the code from the svn the code from the SVN repository.

This will allow for removing keys from teh keyfile as needed. It is for
symetry, not necessarily anything else.

It should allow for removal by either key name or key value.

What steps will reproduce the problem?
1. run any of the code

What is the expected output? What do you see instead?

Traceback (most recent call last):
  File "run_tests.py", line 6, in <module>
    import
helpers_test,cursors_test,book_test,setup_xml,setup_keys,params_test,key_test
  File "./tests/helpers_test.py", line 4, in <module>
    from isbndb.helpers import *
  File "/home/petrov/isbndb-py/isbndb/__init__.py", line 6, in <module>
    from cursors import *
  File "/home/petrov/isbndb-py/isbndb/cursors.py", line 5, in <module>
    from elementtree import ElementTree
ImportError: No module named elementtree


What version of the product are you using? On what operating system?

Python 2.5, Ubuntu 7.04

Please provide any additional information below.

In Python 2.5 the ElementTree code is in the standard library. To import
the code one needs to do 
from xml.etree import ElementTree