Code Monkey home page Code Monkey logo

helix-embed's Introduction

Helix Embedding Microservice

This is a simple microservice (to be used in conjunction with Project Helix) that turns URLs into HTML-previews of the web page behind it. It uses HTML Meta Tags, Twitter Cards, Open Graph Protocol and OEmbed to generate a rich preview and can be configured to use 3rd-party embed providers like Embdely or Iframely.

Status

codecov CircleCI GitHub license GitHub issues LGTM Code Quality Grade: JavaScript

Usage

Run the following command to get a preview of http://www.adobe.com

$ curl https://adobeioruntime.net/api/v1/web/helix/default/embed/http://www.adobe.com
<div class="embed embed-has-url embed-has-title embed-has-image embed-has-description">
  <a href="https://www.adobe.com/">
    <span class="title">Adobe: Creative, marketing and document management solutions</span>
  </a>
  <img src="https://www.adobe.com/homepage/index/index.thumb.800.480.png?ck=1540830329" alt="Adobe: Creative, marketing and document management solutions" class="image">
    <p class="description">Adobe is changing the world through digital experiences. We help our customers create, deliver and optimize content and applications.</p>
<div>

While the above is simple to type, it is more safe to escape the url and optionally pass it as src query parameter:

curl https://adobeioruntime.net/api/v1/web/helix/default/embed/http%3A%2F%2Fwww.adobe.com

or

curl https://adobeioruntime.net/api/v1/web/helix/default/embed?src=http%3A%2F%2Fwww.adobe.com

Deployment

The default deployment can be started with npm run deploy.

Options

In order to use a third-party embedding service, make sure the api property is set at deployment time, e.g.

$ npm run zip && wsk action update embed embed.zip --kind nodejs:8 --web raw --web-secure false -p api https://my-embed-provider.com

All additional default parameters will be used as URL parameters when making the request to the URL specified in api. This allows you to create services that proxy another OEmbed-compatible provider:

Iframely uses the api_key parameter for API keys.

npm run zip && wsk action update embed embed.zip --kind nodejs:8 --web raw --web-secure false -p api http://iframe.ly/api/oembed -p api_key insert-here

Embedly, on the other hand, uses key

npm run zip && wsk action update embed embed.zip --kind nodejs:8 --web raw --web-secure false -p api https://api.embedly.com/1/oembed -p key insert-here

Development

Use the standard trifecta of npm install, npm lint, and npm test.

Build

npm install

Test

npm test

Lint

npm run lint

helix-embed's People

Contributors

adobe-bot avatar dependabot[bot] avatar greenkeeper[bot] avatar kptdobe avatar marquiserosier avatar renovate-bot avatar renovate[bot] avatar rofe avatar semantic-release-bot avatar stefan-guggisberg avatar trieloff avatar tripodsan avatar

Stargazers

avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

dalavancloud isabella232 ghas-results

helix-embed's Issues

The automated release is failing 🚨

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

No npm token specified.

An npm token must be created and set in the NPM_TOKEN environment variable on your CI environment.

Please make sure to create an npm token and to set it in the NPM_TOKEN environment variable on your CI environment. The token must allow to publish to the registry https://registry.npmjs.org/.

Good luck with your project ✨

Your semantic-release bot 📦🚀

make embeds more robust

Description
When importing from the original blog, we search iframes for the src:
https://github.com/adobe/helix-theblog-importer/blob/b19ace2424399d68ccab30ec169b9360f1b811f2/src/index.js#L50-L121

The problem is these links don't work with our embed services; what we need is link to the original content not the link given in the src attribute of an <iframe>.

For example, these link cannot be embedded properly by Iframely but have been extracted during an import.

To Reproduce
You can check them at https://iframely.com/embed/:

https://embed.spotify.com/?uri=spotify4gzpq5DPGxSnKTe4SA8HAU

https://www.linkedin.com/video/embed/live/urn:li:ugcPost:6666809526391570432

https://w.soundcloud.com/player/?url=https%3A%2F%2Fapi.soundcloud.com%2Ftracks%2F673363193&color=%23ff5500&auto_play=false&hide_related=false&show_comments=true&show_user=true&show_reposts=false&show_teaser=true&visual=true

Expected behavior
these embeds should work; for every embed on the embed_allowlist in helix-pipeline, there should be a fallback that can get the right embed if we're given the link to src of a <iframe>, etc. This would require us to just visit the site and construct the embed ourselves!

An in-range update of ajv is breaking the build 🚨

The devDependency ajv was updated from 6.6.2 to 6.7.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ajv is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
Release Notes for v6.7.0

Option useDefaults: "empty" to replace null and "" (empty strings) with default values.
Update draft-04 meta-schema to remove incorrect usage of "uri" format.

Commits

The new version differs by 17 commits.

There are 17 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Integrate Lottie Web Player

From URL https://lottiefiles.com/16313-favorite look for a line containing

<lottie-listings height="150px" type="public" src="https://assets6.lottiefiles.com/packages/lf20_5z9SbI.json" slug="16313-favorite" speed="1" bg="#ffffff" is-listing='true'></lottie-listings>

which has the asset URL for the web player at

see https://lottiefiles.com/web-player?lottie_url=https://assets6.lottiefiles.com/packages/lf20_5z9SbI.json the resulting HTML looks like this:

<script src="https://unpkg.com/@lottiefiles/lottie-player@latest/dist/lottie-player.js"></script>
<lottie-player
    src="https://assets6.lottiefiles.com/packages/lf20_5z9SbI.json"  background="transparent"  speed="1"   loop controls autoplay >
</lottie-player>

/cc @kptdobe

Add SlideShare support

Is your feature request related to a problem? Please describe.
As a user, I would like to embed a SlideShare player in my content.

Describe the solution you'd like
I add the SlideShare URL as a link in my md or Word doc, and Helix turns it into a SlideShare player for me.

Example:
https://www.slideshare.net/adobe/adobe-digital-insights-holiday-recap-2019
would be transformed to the following output

<iframe src="//www.slideshare.net/slideshow/embed_code/key/dG2YdReopAurYT" width="595" height="485" frameborder="0" marginwidth="0" marginheight="0" scrolling="no" style="border:1px solid #CCC; border-width:1px; margin-bottom:5px; max-width: 100%;" allowfullscreen> </iframe>

Additional context
Needed for adobe/theblog#166

An in-range update of @semantic-release/git is breaking the build 🚨

The devDependency @semantic-release/git was updated from 7.0.15 to 7.0.16.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@semantic-release/git is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ✅ ci/circleci: build: Your tests passed on CircleCI! (Details).
  • ❌ ci/circleci: branch-deploy: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Success
Release Notes for v7.0.16

7.0.16 (2019-07-01)

Bug Fixes

  • package: update globby to version 10.0.0 (a93b846)
Commits

The new version differs by 1 commits.

  • a93b846 fix(package): update globby to version 10.0.0

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Integrate with Livefyre Gateway

@ninowalker made me aware of https://git.corp.adobe.com/Livefyre/gateway which implements an OEmbed-service that might be a useful alternative to the built-in services, with following constraints:

  • gateway's authentication needs to be solved, with an easy way of creating a token at deploy time
  • gateway is not externally accessible, so it would need to be put behind Adobe I/O API Gateway
  • we need to convince @ninowalker to keep the service running, because Helix can't run services

An in-range update of request-promise-native is breaking the build 🚨

The dependency request-promise-native was updated from 1.0.5 to 1.0.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

request-promise-native is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
Commits

The new version differs by 10 commits.

  • 7ad655a Version 1.0.6 (now really)
  • 1240b80 fix: updated indirect lodash dependency to fix security vulnerability
  • 80947a1 Version 1.0.6
  • ad529a3 chore: fix ci build for node v8+
  • c2c54c4 Merge pull request #33 from jasonmit/u/jasonmit/fix-node-6
  • 67f7ed2 Merge branch 'master' into u/jasonmit/fix-node-6
  • 4633d4c fix: breaking change in tough-cookie v3
  • 14aa6ee chore: added node 8 and 10 to ci build
  • 9cfcaaa Update package.json
  • 049152b fix: target tough-cookie 2.x to preserve node 6 support

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of mocha-junit-reporter is breaking the build 🚨

The devDependency mocha-junit-reporter was updated from 1.18.0 to 1.19.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

mocha-junit-reporter is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
Commits

The new version differs by 3 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of @adobe/openwhisk-action-builder is breaking the build 🚨

The devDependency @adobe/openwhisk-action-builder was updated from 1.3.1 to 1.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@adobe/openwhisk-action-builder is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ✅ Tidelift: Dependencies checked (Details).
  • ❌ build: * build - Failed
  • branch-deploy - Blocked
Commits

The new version differs by 7 commits.

  • 1e3a6e7 chore(release): 1.4.0 [skip ci]
  • 293ff57 feat(builder): trigger release
  • b89a261 test(unzip): replace unzip2 with yauzl due to security fixes (#61)
  • b752f94 refactor(lib): extract helper to own package (#60)
  • b544def chore(lint): use airbnb-base and update deps (#58)
  • c02a494 chore(tidelift): adding list of forbidden licenses
  • 8c915f1 chore(docs): update readme

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Accessibility: iframe elements are missing a title attribute

Description
The embed's iframe element is missing a title attribute.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://blog.adobe.com/en/2020/07/09/prototypes-enhance-remote-design-dev-collaboration.html and inspect the DOM for the video embed
  2. Note the missing title attribute

Expected behavior
Screen reader users rely on a frame title to describe the contents of the frame. Navigating through frame and iframe elements quickly becomes difficult and confusing for users of this technology if the markup does not contain a title attribute.

Screen reader users have the option to pull up a list of titles for all frames on a page. Adding descriptive, unique titles allows users to quickly find the frame they need. If no titles are present, navigating through frames can quickly become difficult and confusing. If no title is listed, screen readers will instead give information like “frame,” “JavaScript,” the filename, or the URL. In most cases, this information won’t be very helpful.

Proposed solution
Rewrite the iframe element coming from iframely in helix-embed, adding the title attribute.

Additional context

.vscode Folder Got Merged

Description
It seems that .vscode folder was not in .gitignore and now has been merged. This may impact other vscode users.

To Reproduce
Steps to reproduce the behavior:

  1. Go to adobe/helix
  2. Click on /.vscode
  3. See the config files

I would like to work on this issue if it is a valid issue.

Add class name declaring the kind of embed used

Is your feature request related to a problem? Please describe.
Developers should be able to apply custom styles to different kinds of embeds. For this reason, it would come in handy if the embed's wrapper div got a distinct class name depending on the 2nd level domain in the hostname of the embed URL.

Describe the solution you'd like
A YouTube embed should have an embed-youtube class in the wrapper, a SlideShare embed an embed-slideshare class and so forth.

Additional context
Customer feedback on adobe/theblog#166 was that the SoundCloud embed should be smaller when used on theblog.

Better Embedding of Adobe Spark Posts

Adobe Spark Post is currently embedded as Open Graph (image preview, title, and description), but it should be embedded as a responsive, scalable img.

Support player urls

Follow up of the discussion here adobe/helix-pipeline#702.

For any kind of embed, if the player url is provided (instead of the "direct" url to the resource), the embed service should be smart enough and use the player url as in the output.

An in-range update of @pollyjs/persister-fs is breaking the build 🚨

The devDependency @pollyjs/persister-fs was updated from 2.6.2 to 2.6.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@pollyjs/persister-fs is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ✅ Tidelift: Dependencies checked (Details).
  • ✅ ci/circleci: build: Your tests passed on CircleCI! (Details).
  • ❌ ci/circleci: branch-deploy: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Success
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

some embeds don't go through iframely

There is still an issue of some embeds not even going through Iframely which is strange; our embed script should be last ditch in case we cannot find an oembed.

To be exact, https://www.youtube.com/embed/i_CMyAoNcRI shouldn't become

<div class="embed  embed-has-url embed-has-title">
  <a href="https://www.youtube.com/embed/i_CMyAoNcRI?">
    <span class="title">We’re Here. And We’re Ready | Coronavirus (COVID 19) Network Preparedness | Verizon - YouTube</span>
  </a>
<div>

It should become

"<div class="embed embed-oembed embed-advanced"><div style="left: 0; width: 100%; height: 0; position: relative; padding-bottom: 56.25%;"><iframe src="https://www.youtube.com/embed/TTCVn4EByfI?rel=0" style="border: 0; top: 0; left: 0; width: 100%; height: 100%; position: absolute;" allowfullscreen scrolling="no" allow="encrypted-media; accelerometer; gyroscope; picture-in-picture"></iframe></div></div>"

An in-range update of codecov is breaking the build 🚨

The devDependency codecov was updated from 3.1.0 to 3.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

codecov is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
Commits

The new version differs by 3 commits.

  • e427d90 feat(services): add azure pipelines (#114)
  • 023d204 Use small HTTP dependency (#110)
  • 500f308 Update Readme

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of semantic-release is breaking the build 🚨

The devDependency semantic-release was updated from 15.13.20 to 15.13.21.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

semantic-release is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ✅ ci/circleci: build: Your tests passed on CircleCI! (Details).
  • ❌ ci/circleci: branch-deploy: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Success
Release Notes for v15.13.21

15.13.21 (2019-08-12)

Bug Fixes

  • package: update hosted-git-info to version 3.0.0 (391af98)
Commits

The new version differs by 3 commits.

  • 391af98 fix(package): update hosted-git-info to version 3.0.0
  • d45d8b6 docs: fix typo
  • 519df0d chore: remove commitizen from our dependencies

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Tests sometimes don't complete

Description
Tests sometimes timeout on CI because the process doesn't exit due to open sockets.

To Reproduce
Steps to reproduce the behavior:

In a local checkout, run `npx mocha test/' a couple of times. Sooner or later the process hangs and needs to be killed wit CTRL+C.

Expected behavior
Tests complete and the process exits every time.

An in-range update of eslint is breaking the build 🚨

The devDependency eslint was updated from 5.13.0 to 5.14.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
Release Notes for v5.14.0
  • 85a04b3 Fix: adds conditional for separateRequires in one-var (fixes #10179) (#10980) (Scott Stern)
  • 0c02932 Upgrade: [email protected] (#11401) (Ilya Volodin)
  • 104ae88 Docs: Update governance doc with reviewers status (#11399) (Nicholas C. Zakas)
  • ab8ac6a Fix: Support boundary spread elements in sort-keys (#11158) (Jakub Rożek)
  • a23d197 New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes #7145) (#11243) (richie3366)
  • e25e7aa Fix: comma-spacing ignore comma before closing paren (fixes #11295) (#11374) (Pig Fang)
  • a1f7c44 Docs: fix space-before-blocks correct code for "classes": "never" (#11391) (PoziWorld)
  • 14f58a2 Docs: fix grammar in object-curly-spacing docs (#11389) (PoziWorld)
  • d3e9a27 Docs: fix grammar in “those who says” (#11390) (PoziWorld)
  • ea8e804 Docs: Add note about support for object spread (fixes #11136) (#11395) (Steven Thomas)
  • 95aa3fd Docs: Update README team and sponsors (ESLint Jenkins)
  • 51c4972 Update: Behavior of --init (fixes #11105) (#11332) (Nicholas C. Zakas)
  • ad7a380 Docs: Update README team and sponsors (ESLint Jenkins)
  • 550de1e Update: use default keyword in JSON schema (fixes #9929) (#11288) (Pig Fang)
  • 983c520 Update: Use 'readonly' and 'writable' for globals (fixes #11359) (#11384) (Nicholas C. Zakas)
  • f1d3a7e Upgrade: some deps (fixes #11372) (#11373) (薛定谔的猫)
  • 3e0c417 Docs: Fix grammar in “there’s nothing prevent you” (#11385) (PoziWorld)
  • de988bc Docs: Fix grammar: Spacing improve -> Spacing improves (#11386) (PoziWorld)
  • 1309dfd Revert "Build: fix test failure on Node 11 (#11100)" (#11375) (薛定谔的猫)
  • 1e56897 Docs: “the function actually use”: use -> uses (#11380) (PoziWorld)
  • 5a71bc9 Docs: Update README team and sponsors (ESLint Jenkins)
  • 82a58ce Docs: Update README team and sponsors (ESLint Jenkins)
  • 546d355 Docs: Update README with latest sponsors/team data (#11378) (Nicholas C. Zakas)
  • c0df9fe Docs: ... is not an operator (#11232) (Felix Kling)
  • 7ecfdef Docs: update typescript parser (refs #11368) (#11369) (薛定谔的猫)
  • 3c90dd7 Update: remove prefer-spread autofix (fixes #11330) (#11365) (薛定谔的猫)
  • 5eb3121 Update: add fixer for prefer-destructuring (fixes #11151) (#11301) (golopot)
  • 173eb38 Docs: Clarify ecmaVersion doesn't imply globals (refs #9812) (#11364) (Keith Maxwell)
  • 84ce72f Fix: Remove extraneous linefeeds in one-var fixer (fixes #10741) (#10955) (st-sloth)
  • 389362a Docs: clarify motivation for no-prototype-builtins (#11356) (Teddy Katz)
  • 533d240 Update: no-shadow-restricted-names lets unassigned vars shadow undefined (#11341) (Teddy Katz)
  • d0e823a Update: Make --init run js config files through linter (fixes #9947) (#11337) (Brian Kurek)
  • 92fc2f4 Fix: CircularJSON dependency warning (fixes #11052) (#11314) (Terry)
  • 4dd19a3 Docs: mention 'prefer-spread' in docs of 'no-useless-call' (#11348) (Klaus Meinhardt)
  • 4fd83d5 Docs: fix a misleading example in one-var (#11350) (薛定谔的猫)
  • 9441ce7 Chore: update incorrect tests to fix build failing (#11354) (薛定谔的猫)
Commits

The new version differs by 38 commits.

  • af9688b 5.14.0
  • 0ce3ac7 Build: changelog update for 5.14.0
  • 85a04b3 Fix: adds conditional for separateRequires in one-var (fixes #10179) (#10980)
  • 0c02932 Upgrade: [email protected] (#11401)
  • 104ae88 Docs: Update governance doc with reviewers status (#11399)
  • ab8ac6a Fix: Support boundary spread elements in sort-keys (#11158)
  • a23d197 New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes #7145) (#11243)
  • e25e7aa Fix: comma-spacing ignore comma before closing paren (fixes #11295) (#11374)
  • a1f7c44 Docs: fix space-before-blocks correct code for "classes": "never" (#11391)
  • 14f58a2 Docs: fix grammar in object-curly-spacing docs (#11389)
  • d3e9a27 Docs: fix grammar in “those who says” (#11390)
  • ea8e804 Docs: Add note about support for object spread (fixes #11136) (#11395)
  • 95aa3fd Docs: Update README team and sponsors
  • 51c4972 Update: Behavior of --init (fixes #11105) (#11332)
  • ad7a380 Docs: Update README team and sponsors

There are 38 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of epsagon is breaking the build 🚨

The dependency epsagon was updated from 1.28.0 to 1.29.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

epsagon is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ✅ ci/circleci: build: Your tests passed on CircleCI! (Details).
  • ❌ ci/circleci: branch-deploy: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Success
Release Notes for v1.29.0

1.29.0 (2019-07-07)

Features

Commits

The new version differs by 1 commits.

  • 950e38b feat(utils): ignore fields in metadata (#131)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint-plugin-import is breaking the build 🚨

The devDependency eslint-plugin-import was updated from 2.17.1 to 2.17.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
Commits

The new version differs by 5 commits.

  • eddcfa9 Bump to v2.17.2
  • b151d04 [fix] no-unused-modules: avoid crash when using ignoreExports-option
  • 3512563 [fix] no-unused-modules: make sure that rule with no options will not fail
  • 8e0c021 [Test] no-unused-modules add failing test case
  • 9b7a970 [meta] add npm run mocha for easier unit testing

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint is breaking the build 🚨

The devDependency eslint was updated from 6.1.0 to 6.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ✅ Tidelift: Dependencies checked (Details).
  • ✅ ci/circleci: build: Your tests passed on CircleCI! (Details).
  • ❌ ci/circleci: branch-deploy: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Success
Release Notes for v6.2.0
  • fee6acb Update: support bigint and dynamic import (refs #11803) (#11983) (Toru Nagashima)
  • afd8012 New: noInlineConfig setting (refs eslint/rfcs#22) (#12091) (Toru Nagashima)
  • 3d12378 Update: Fix accessor-pairs to enforce pairs per property in literals (#12062) (Milos Djermanovic)
  • 8cd00b3 New: function-call-argument-newline (#12024) (finico)
  • 30ebf92 Fix: prefer-template autofix produces syntax error with octal escapes (#12085) (Milos Djermanovic)
  • 13c3988 Fix: Check literal type explicitly in dot-notation (#12095) (Milos Djermanovic)
  • 3e5ceca Fix: Handle empty string property names in getFunctionNameWithKind (#12104) (Milos Djermanovic)
  • 9a043ff Fix: no-duplicate-case false positives on Object.prototype keys (#12107) (Milos Djermanovic)
  • fe631af Chore: minor typo fix (#12112) (James George)
  • 4cb7877 Fix: fix no-extra-parens ignores some nodes (#11909) (Pig Fang)
  • 2dc23b8 Update: fix no-dupe-keys false negatives on empty string names (#12069) (Milos Djermanovic)
  • 19ab666 Fix: yoda exceptRange false positives on empty string property names (#12071) (Milos Djermanovic)
  • d642150 Update: Check empty string property names in sort-keys (#12073) (Milos Djermanovic)
  • acce6de Fix: class-methods-use-this reports 'undefined' names (#12103) (Milos Djermanovic)
  • 92ec2cb Fix: Allow bind call with a single spread element in no-extra-bind (#12088) (Milos Djermanovic)
  • bfdb0c9 Fix: no-extra-boolean-cast invalid autofix for Boolean() without args (#12076) (Milos Djermanovic)
  • 34ccc0c Chore: Remove TDZ scope type condition from no-unused-vars (#12055) (Milos Djermanovic)
  • 01d38ce Docs: Remove TDZ scope from the scope manager interface documentation (#12054) (Milos Djermanovic)
  • 1aff8fc Update: warn about mixing ternary and logical operators (fixes #11704) (#12001) (Karthik Priyadarshan)
  • 11be2f8 Docs: do not recommend global-installed usage (#12016) (薛定谔的猫)
  • cf31dab Fix: no-restricted-syntax - correct the schema (#12051) (Brad Zacher)
  • fbec99e Update: fix class-methods-use-this false negatives with exceptMethods (#12077) (Milos Djermanovic)
  • fb08b7c Docs: Remove readonly/writable global logic from no-undef (fixes #11963) (#12053) (Milos Djermanovic)
  • 5b5934b Sponsors: Sync README with website (ESLint Jenkins)
  • 9156760 Sponsors: Sync README with website (ESLint Jenkins)
  • f5e0cc4 Update: Check computed method keys in no-extra-parens (#11973) (Milos Djermanovic)
  • d961438 Docs: Fix Incorrect Documentation (#12045) (Michael Miceli)
  • 887d08c Sponsors: Sync README with website (ESLint Jenkins)
  • d90183f Docs: add a case to func-names (#12038) (Chiawen Chen)
  • 8a5b62d Docs: no use eslint.linter in code example (#12037) (薛定谔的猫)
  • 5831767 Update: report location of func-names (fixes #12022) (#12028) (Pig Fang)
Commits

The new version differs by 33 commits.

  • 320b7bd 6.2.0
  • 9601f5a Build: changelog update for 6.2.0
  • fee6acb Update: support bigint and dynamic import (refs #11803) (#11983)
  • afd8012 New: noInlineConfig setting (refs eslint/rfcs#22) (#12091)
  • 3d12378 Update: Fix accessor-pairs to enforce pairs per property in literals (#12062)
  • 8cd00b3 New: function-call-argument-newline (#12024)
  • 30ebf92 Fix: prefer-template autofix produces syntax error with octal escapes (#12085)
  • 13c3988 Fix: Check literal type explicitly in dot-notation (#12095)
  • 3e5ceca Fix: Handle empty string property names in getFunctionNameWithKind (#12104)
  • 9a043ff Fix: no-duplicate-case false positives on Object.prototype keys (#12107)
  • fe631af Chore: minor typo fix (#12112)
  • 4cb7877 Fix: fix no-extra-parens ignores some nodes (#11909)
  • 2dc23b8 Update: fix no-dupe-keys false negatives on empty string names (#12069)
  • 19ab666 Fix: yoda exceptRange false positives on empty string property names (#12071)
  • d642150 Update: Check empty string property names in sort-keys (#12073)

There are 33 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of ajv is breaking the build 🚨

The devDependency ajv was updated from 6.10.0 to 6.10.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ajv is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ✅ ci/circleci: build: Your tests passed on CircleCI! (Details).
  • ❌ ci/circleci: branch-deploy: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Success
Commits

The new version differs by 12 commits.

  • 8b59052 6.10.1
  • 66c2907 chore(package): update del-cli to version 2.0.0 (#1014)
  • d476534 chore(package): update eslint to version 6.0.0 (#1030)
  • c468632 test: update node.js versions for travis test
  • 3ca7571 chore: update jshint
  • 120d746 chore(package): update nyc to version 14.0.0 (#994)
  • c3093bb Add "empty" to useDefaults Option type definition (#1020)
  • ab841b4 fix: addKeyword and schema without ID, closes #1001
  • bc993de chore(package): update karma to version 4.0.1 (#959)
  • 6be5ff6 fix(types): add strictKeywords to Options interface (#975)
  • 78a9403 update JSON-Schema-Test-Suite
  • d107207 Fix wrong json schema reference (#961)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Integrate with Unsplash API

When using an Unsplash image, the embedder should use the Unsplash API instead of OpenGraph and create a proper img with srcset and sizes.

An in-range update of @pollyjs/adapter-node-http is breaking the build 🚨

The devDependency @pollyjs/adapter-node-http was updated from 2.3.0 to 2.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@pollyjs/adapter-node-http is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of nyc is breaking the build 🚨

The devDependency nyc was updated from 13.1.0 to 13.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

nyc is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
Commits

The new version differs by 17 commits.

  • 29e6f5e chore(release): 13.2.0
  • e95856c chore: Update dependencies. (#978)
  • 921d386 fix: Create directory for merge destination. (#979)
  • df2730d feat: Option Plugins (#948)
  • 35cd49a feat: document the fact that cacheDir is configurable (#968)
  • ff834aa feat: avoid hardcoded HOME for spawn-wrap working dir (#957)
  • 35710b1 build: move windows tests to travis (#961)
  • 93cb5c1 tests: coverage for temp-dir changes (#964)
  • d566efe test: stop using LAZY_LOAD_COUNT (#960)
  • f23d474 chore: update stale bot config with feedback (#958)
  • 62d7fb8 chore: slight tweak to position of test
  • 28b6d09 fix: missing command temp-directory (#928)
  • 40afc5f fix: nyc processing files not covered by include when all is enabled. (#914)
  • ba22a26 docs(readme): Update to reflect .nycrc.json support (#934)
  • 2dbb82d chore: enable probot-stale

There are 17 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint-plugin-react is breaking the build 🚨

The devDependency eslint-plugin-react was updated from 7.11.1 to 7.12.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-react is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
Release Notes for v7.12.0

Added

Fixed

Changed

Commits

The new version differs by 127 commits.

  • a83d65c Update CHANGELOG and bump version
  • 0c6160e [Dev Deps] update coveralls, babel-eslint, typescript
  • cd6c8e6 [Deps] update resolve
  • d2b5b73 Merge pull request #1828 from alexzherdev/1721-no-typos-create-class
  • e747459 [Tests] remove node 5/7/9, add node 11
  • b33ae84 Merge pull request #1098 from arian/createElement-display-test
  • 84be80a Merge pull request #1824 from alexzherdev/1762-jsx-max-depth-false-positive
  • a442067 Merge pull request #2029 from sstern6/issue1422
  • 7d07c37 Merge pull request #2032 from alexzherdev/jsx-fragments-message
  • 8c6a8e2 Merge pull request #2089 from jomasti/feature/support-react-forwardref-memo
  • 14451d4 Merge pull request #2085 from himynameisdave/issues/2083
  • 8be52c7 📝 Addresses CR comments
  • f7e3121 Merge branch 'master' of https://github.com/yannickcr/eslint-plugin-react into issues/2083
  • 77e3fd0 Merge pull request #2090 from JBallin/no-method-set-state-docs-url
  • 7da9e0d Fix noMethodSetState docsUrl's

There are 127 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of @adobe/helix-pingdom-status is breaking the build 🚨

The dependency @adobe/helix-pingdom-status was updated from 2.0.0 to 2.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@adobe/helix-pingdom-status is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ ci/circleci: build: Your tests failed on CircleCI (Details).
  • ❌ build: * build - Failed
  • branch-deploy - Blocked
Release Notes for v2.0.1

2.0.1 (2019-07-24)

Bug Fixes

  • package: update snyk to version 2.0.0 (afe472b)
Commits

The new version differs by 7 commits.

  • 5c03bd6 chore(release): 2.0.1 [skip ci]
  • c01dd79 Merge pull request #25 from adobe/greenkeeper/snyk-2.0.0
  • 0619600 chore(package): update lockfile package-lock.json
  • afe472b fix(package): update snyk to version 2.0.0
  • fdf6879 tests(index): adjust to new version
  • dc181db chore(package): update lockfile package-lock.json
  • 389cb31 chore(package): update @adobe/openwhisk-action-builder to version 1.2.1

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

escape or don't use `__ow_path` to pass external resource url

Description
this action receives the external resource URL as unescaped path suffix via the __ow_path parameter. this has the drawback, that the query parameters of the resource URL bleed into the action parameters. this makes it volatile to changes in the resource URL, since each extractor needs to anticipate the potential query parameters needed. also, it prevents using query params for real action params.

also see:

Suggestion A

The minimal change that could be done is to url-escape the external resource.

so instead of:

https://adobeioruntime.net/api/v1/web/helix/helix-serivces/data-embed@v1/https://adobe.sharepoint.com/sites/TheBlog/_layouts/15/guestaccess.aspx?share=ESR1N29Z7HpCh1Zfs_0YS_gB4gVSuKyWRut-kNcHVSvkew&email=helix%40adobe.com&e=hx0OUl

we'd use:

https://adobeioruntime.net/api/v1/web/helix/helix-serivces/data-embed@v1/https%3A%2F%2Fadobe.sharepoint.com%2Fsites%2FTheBlog%2F_layouts%2F15%2Fguestaccess.aspx%3Fshare%3DESR1N29Z7HpCh1Zfs_0YS_gB4gVSuKyWRut-kNcHVSvkew%26email%3Dhelix%2540adobe.com%26e%3Dhx0OUl

Suggestion B

an alternative approach is not to use the __ow_path but a normal action parameter, eg:

https://adobeioruntime.net/api/v1/web/helix/helix-serivces/data-embed@v1?r=https%3A%2F%2Fadobe.sharepoint.com%2Fsites%2FTheBlog%2F_layouts%2F15%2Fguestaccess.aspx%3Fshare%3DESR1N29Z7HpCh1Zfs_0YS_gB4gVSuKyWRut-kNcHVSvkew%26email%3Dhelix%2540adobe.com%26e%3Dhx0OUl

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.