Code Monkey home page Code Monkey logo

Comments (9)

tripodsan avatar tripodsan commented on June 1, 2024

I tried to work around the hanging tests... and it most of the times works, but sometimes the tests still hang. It is related to using helix-fetch, which keeps the connections open. alternatively, we could use --exit on the mocha tests for force stopping the process.

from helix-embed.

trieloff avatar trieloff commented on June 1, 2024

Ok, I'll watch the CI build and close this issue if resolved.

from helix-embed.

tripodsan avatar tripodsan commented on June 1, 2024

ok, I tried to merge....

I also notived, that the tests only hang, if something fails:

[ERROR] Status 403: request failed, check your url

from helix-embed.

tripodsan avatar tripodsan commented on June 1, 2024

no....that's not it.... now it went through

from helix-embed.

trieloff avatar trieloff commented on June 1, 2024

Yep. I'm glad that we are dealing with all the HTTP2 paper cuts now, instead of later when we have lots of traffic.

from helix-embed.

tripodsan avatar tripodsan commented on June 1, 2024

I'm glad that we are dealing with all the HTTP2 paper cuts now,

I don't think it's related to http2, but to helix-fetch :-)

@stefan-guggisberg would it be possible to add an option to helix-fetch to disable keep-alive ?

from helix-embed.

stefan-guggisberg avatar stefan-guggisberg commented on June 1, 2024

@tripodsan

const { fetch } = require('@adobe/helix-fetch').context({
  http1: {
    keepAlive: false
  },
  httpsProtocols: ['http1']
});

see here

from helix-embed.

MarquiseRosier avatar MarquiseRosier commented on June 1, 2024

^^ Hey @stefan-guggisberg that is what I do with the proxyquire. I figured it would cured us of the hanging; but that was merged yesterday. All the fetching is done with keepAlive set to false! So this might not be the fix unfortunately :(

from helix-embed.

stefan-guggisberg avatar stefan-guggisberg commented on June 1, 2024

I have reported a related fetch-h2 issue a while ago. It's been finally fixed 2 days ago and the fix is included in helix-fetch v1.4.1 released yesterday.

Disabling keep-alive shouldn't be necessary. I will verify this in another PR.: #172

from helix-embed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.