Comments (9)
I tried to work around the hanging tests... and it most of the times works, but sometimes the tests still hang. It is related to using helix-fetch, which keeps the connections open. alternatively, we could use --exit
on the mocha tests for force stopping the process.
from helix-embed.
Ok, I'll watch the CI build and close this issue if resolved.
from helix-embed.
ok, I tried to merge....
I also notived, that the tests only hang, if something fails:
[ERROR] Status 403: request failed, check your url
from helix-embed.
no....that's not it.... now it went through
from helix-embed.
Yep. I'm glad that we are dealing with all the HTTP2 paper cuts now, instead of later when we have lots of traffic.
from helix-embed.
I'm glad that we are dealing with all the HTTP2 paper cuts now,
I don't think it's related to http2, but to helix-fetch :-)
@stefan-guggisberg would it be possible to add an option to helix-fetch to disable keep-alive ?
from helix-embed.
const { fetch } = require('@adobe/helix-fetch').context({
http1: {
keepAlive: false
},
httpsProtocols: ['http1']
});
see here
from helix-embed.
^^ Hey @stefan-guggisberg that is what I do with the proxyquire. I figured it would cured us of the hanging; but that was merged yesterday. All the fetching is done with keepAlive set to false! So this might not be the fix unfortunately :(
from helix-embed.
I have reported a related fetch-h2 issue a while ago. It's been finally fixed 2 days ago and the fix is included in helix-fetch
v1.4.1 released yesterday.
Disabling keep-alive
shouldn't be necessary. I will verify this in another PR.: #172
from helix-embed.
Related Issues (20)
- youtu.be embed should create embed-youtube div attribute HOT 1
- Lazy load iFrames HOT 1
- query parameter bug HOT 4
- make span invisible HOT 1
- different styling for same embed url
- enable propagation of queryparams! HOT 2
- Don't include secrets during deploy.
- Clean up code and document
- iframely caches response for youtube
- too many trips to url HOT 1
- requests to fastly block and timeout after 60s HOT 2
- when x-forwarded-for IP is not in range, iframely is invoked with no api key. HOT 1
- 429s from Instagram HOT 1
- migrate to helix-deploy HOT 2
- AWS: post-deploy tests don't work. maybe due to not allowed ip HOT 1
- unsplash post-deploy tests don't work on CI
- Client Side Embeds HOT 6
- instagram embed styling inconsistent
- Add source url to markup HOT 1
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helix-embed.