accumulator / quickddit Goto Github PK

The current design of Quickddit, where subreddits are always shown on the first page of the PageStack make sense, as it limits the memory usage. However, the behavior where upon clicking on a subreddit URL all pages get popped from the PageStack is quite annoying when you are reading a comment section and click on a link without clear distinction where it leads. Instead of a URL dialog being opened or a new post/user page, all progress is lost when the URL leads to a subreddit.

What about creating a new dialog which would ask the user if they really want to open the subreddit URL, notifying them that their reading progress in the current thread will be lost?

This would eliminate many annoying situations and lost progress.

PS: I can contribute this dialog myself in a few days, but some discussion is needed, so that's why I'm opening this issue.

After the fix for high res pics images no longer rescale when changing orientation

https://www.reddit.com/r/EliteDangerous/comments/4m71b8/whats_your_everyday_ship_in_21/d3t2qr2

Three times in a row, not sure if parent comment or the thread is the issue, but quickddit crashed three times on me on this one

Whenever you reply to a comment or edit a comment and you scroll up or down too far, the text you've entered into the reply/edit field disappears. This probably happens because the edited text is kept in the delegate, which may be destroyed when the ListView scrolls the edit field out of view.

I'm not sure if that is the case for Jolla, hence only offering only for Harmattan. Quickddit is incapable of opening .gifv so you have to open link in browser, then click the image again so it opens in a video player.

If you would parse all .gifv as .gif they could be opened inside Quickddit without the need to use external apps. The most common subreddit that comes to mind which has lots of .gifv is /r/aww, but they are pretty much everywhere.

Would be great if you could add a feature to block specific subreddits from appearing when you're looking at all. There's always a bunch of low quality content you just never want to see.

A comma-separated list in settings would do fine because this is something you only enter once and forget about it.

The buttons get moved too much to the left on some posts, upvote ends up being halfway outside of screen: http://i.imgur.com/DzNW6Vx.png

Seeing so many (6!) options in the comment context menu, I have got an idea that would both reduce the number of icons and also make it easier to understand for a regular user.

I would replace Copy Comment and Permalink with a Share option. It would open the current Permalink dialog, but also feature a 'Copy Comment' button there.

I believe that 'Permalink' is quite a cryptic term for a regular user, so sharing option would be more understandable and this move would also bring the advantage of having a dedicated sharing page that could be expanded later.

PS: I might implement it myself, but I don't have much time right now (which resulted in the pull request fiasco the last time).

As .gif animations/images are currently being looped, there should be at least an option to loop their .gifv counterparts as well, as they are only a video replacement of the original format.

Is an Android client out of the question? Would you accept patches?

Since a few days ago Gfycat links fail to load, with the warning 'Problem finding stream URL'. Apparently the json endpoint used by youtube-dl is gone, and a fix was commited the youtube-dl repo on November 29. Upgrading to the latest youtube-dl version should fix this issue.

In SFOS (or any mobile os really) tap and hold brings up a menu of sorts, while tapping performs an action. Please add an option to reverse the current behaviour when it comes to hiding comments/showing the option bar (where you can upvote) as it's extremely unnatural .

Since the last 2/3 days youtube videos don't work anymore. It seems a new version of youtube-dl is needed.

Also: I wouldn't mind trying to build it myself, but I don't see any kind of Makefile or CMakeLists.txt anywhere. Is that even possible without installing weird things like QtCreator?

This one specifically:
https://www.reddit.com/r/CrappyDesign/comments/5szxfy/its_better_because_it_is_all_automated/
It's linked as jpg, while playing memory quickly reaches 97% usage and all apps get killed (jolla c, 2.1.0.9)

Tongue in cheek a bit, but would help people voice their appreciation, this is becoming THE BEST mobile reddit client

Any comment containing apostrophe is displayed without in overview page

For some reason Quickddit is adding amp; to facebook image urls (*.fbcdn.net). Preview is working fine but if you try to open or copy it, you won't be able to.
Example of links:
Correct one: (NSFW)
https://scontent-sjc2-1.xx.fbcdn.net/hphotos-xap1/v/t1.0-9/984265_628802043920534_7984640431054628742_n.jpg?oh=aeb98c2e935bd2f86a690d9434f51f40&oe=56CD84CD

The one you get in Quickddit:
https://scontent-sjc2-1.xx.fbcdn.net/hphotos-xap1/v/t1.0-9/984265_628802043920534_7984640431054628742_n.jpg?oh=aeb98c2e935bd2f86a690d9434f51f40&oe=56CD84CD

Note that I'm using Harmattan version, it's possible that it's working fine on Sailfish.

Tested on Sailfish.
Use a tool to monitor CPU usage per process, such as top or lighthouse.
In Quickddit, find an item which links to a website (especially noticeable for 'heavy' websites with lots of JavaScript). Touch the link icon, then swipe left to accept and open the link in Quickddit's internal webviewer. Check CPU usage: a new process called QtWebProcess has appeared. In Quickddit, swipe right to close the webview. Continue using Quickddit. Notice that the phone is getting hot and the battery is draining. Check process CPU usage: the QtWebProcess process is still there, and still consuming a high percentage of CPU time.

Closing and reopening Quickddit kills the rogue process, but of course forgets what you were looking at.

It could be worth keeping the web process running while you're still looking at the comments associated with the link, so you can flip back and forth, but once you leave that item, I think the process should be stopped.

Only selfposts allow submitting

First of all thank you for your work so far.

Usually I open the app to browse a bit and then turn on the offline mode for the night. On the next morning the app is crashed and starts up again.
This behavior is not consistent with offline mode and it usually takes at least an hour until the app crashes. At least I could not reproduce it with offline mode for a few minutes.

How to reproduce the bug?

1. Start app and browse a bit.
2. Turn on flight/offline mode for at least an hour or the whole night.
3. App crashed some when in the meantime and starts up again.

Other information

This happened to me on Xperia X and version 1.6.0 and 1.6.1 of Quickddit. This might be a regression or an error with the Phone itself, because I had no such problems on the Jolla C.

I'll start the app tonight via terminal and will paste any logs I have.

nothing happens when you click on the icon or the video icon from within a post

Upvote, Downvote, Save & URL options are available in drop-down menu when you long tap on a post.
Can you also add Hide option which will keep the post hidden in all sections in subreddit ?

Thank you and keep up the great work!

Version: 0.7.3 (Harmattan)
Self posts no longer shows any content. I can only see title and comments but no content of a self.post.

I don't believe any android or else client has it, but it would be awesome to be able to see deleted comments from within the app, seems to be more and more needed feature though

Oftentimes when browsing r/all I end up wanting to jump to the subreddit current post is from, would be cool if subreddits in r/all view were clickable like usernames (or extra pulley option at top)

Especially on slower connections, one must pause the video, wait for the buffer to reach 100% and then hit play. It becomes quite annoying as it is usually repeated for each video and if you don't hit the pause button fast enough, you are presented with a stuttering video with a percentage overlay.

How to reproduce:

• Play a .gifv on slower connection.

What should happen:

• The player should wait for the video to load and then start playing.

What happens instead:

• Video stutters, moves image by image, is barely watchable.
• Percentage overlay covers part of the video.
• Once the loading catches up, the video plays as it should.

Hi,

This is one of my favourite Sailfish apps, thanks for all the hard work on it.

I think I read in a changelog a while back that you had done some work to make the UI scalable, which is great if I'm not misremembering. Is it possible to tweak the thumbnails so that they are larger on bigger screens? They are too small to be easily visible on Fairphone 2 (1290x1080 5" screen), but the same feed viewed on Jolla looks great.

Here's Quickddit on Fairphone 2 (ithumbnails too small):

And here's Neliapila on Fairphone 2 (thumbnails easily visible):

Something closer to the Neliapila scale would be great, if that's possible?

I don't think moving messages to the pulley menu of the 2nd page, I think it should be in the pulley menu of the first page.
Similar to reddit for sync on android.

What you think about dropping support for Harmattan? The benefits we can see are:

• No need back porting changes to Harmattan (particulally QML changes)
• Can use new features in Qt5 and C++11, and drop Qt-Json
• Easier to maintain the whole project

Unless you got a valid reason (like they are still huge amount of Harmattan Quickddit users out there), I don't see any advantages on continue maintaining the Harmattan port.

If I'm in Landscape mode and open a link in the browser, the InfoBanner is shown in portrait mode still.

I'm not sure if this is at all possible to do from Quickddit itself, but it happens way too often that I open a post of a video without sound (not sure if it's necessarily a proper gif), and the music playback from the default Jolla music player is paused. This becomes annoying really quickly, since about 25% of the posts I view are short videos like that.

Hello, thank you accumulator for this great app. I enjoy surfing reddit more than with any android app. Congrats :)

Now my report: just as I say above, with messages like this one I tap on it but I cannot upvote/downvote or do any other action but going back.

Any other clue I can give you just tell me.

Thank you!

Edit:
My phone is a MotoG (2013 falcon) ported running SFOS 2.0.1.11

Not sure if the buttons used to grey out before, but just noticed that one cannot tell if they already upvoted a comment when it is in [score hidden] state, extra upvote nullifies the previous one, so not sure if the correct way to address this is greying out last used option, or just adding red/blue highlight to the [score hidden] comments

The app doesn't currently tell you when someone's sent you a PM or replied to one of your comments: when you would see the 'orangered' envelope on the Reddit website. Can I request that this gets implemented as a notification? The messaging page is not simple to get to - you have to select 'more' from the main pulley menu, then select 'Messages' - but unread messages really the only important part of that, so that's fine if a notification jumped straight to unread messages.

Just makes it a bit easier to scroll through the list.

Since version 1.6.1, Quickddit systematically segfaults when trying to unfold hidden comments.

A few subreddits use the flair feature categorize posts, with the aim that users can filter out topics that they don't want to see. For example 'US Politics', 'Trump' or 'Net Neutrality'. The Reddit Enhancement Suite features a flair filter, as do some apps, and it'd be great of Quickddit could do this too. Some suggestions:

• Post flair is already displayed, so a tap or long press on that on the post page would be a good place to initiate a filter.
• Filter creation would let you choose whether to apply the filter to the current post's subreddit, or all.
• Filter management should allow temporary disabling as well as deleting, as well as creation of a filter with a free text input.

What about displaing post karma und comment karma at the top of the page.
Also a un/friend button would be great.
A bit like in reddit sync.

Not sure what would be the best way to handle this, move back to comment view only after 'success' reply, or storing it temporarily, does not crash at least :)

It would be nice if one could share some of the pictures and maybe videos found on reddit. Currently it is possible to save the image and share it afterwards. Maybe it would be possible to add the share menu to the pulley menu. Sorry for the quality of the mockup.


The second one is how it works in the Gallery app and might not be the best solution, but it would be consistent.
Thanks to the sailfishos IRC channel I found some resources, that might help.
https://git.merproject.org/mer-core/transfer-engine/blob/master/example/ExampleShareUI.qml
https://github.com/kimmoli/scp-shareui

Is it possible to translate Quickddit somewhere? If not, I think it would be a good idea to apply for hosting at Weblate.

First of all thank you for all your work so far!
It would be really neat if one could open a reddit link from Browser in Quickddit. It would be probably easier if one could paste the link into Quickddit itself and Quickddit would jump to the thread.
Browsing reddit in sailfish browser is not nearly as comfortable as in Quickddit.

Wonder if it is Silica bug and should be reported there, but strikeout (strikethrough?) text is rendered as normal (or maybe it is good instead of having it not rendered at all, but thought will report it, not sure if seen silica strikeout, BTW totally GRATZ for fixing the non-rendering high resolution pics, it was awesome!!! Seeing now android users complain about gifv or something not rendering correctly for them and am just like: why not use the superior platform, quickddit is just better than xyz.

If you click an upvote/downvote on a comment sometimes the link icon gets highlighted, sometimes the parent-comment one, not really an issue/bug just a weird visual glitch. If you hold the press and move around it fixes itself and only the item under press is highlighted, weird

All videos hosted on Imgur are failing to load, showing "Error loading video" and "Problem finding stream URL". Console says:

[W] QPython::emitError:487 - Unhandled PyOtherSide error: Return value of PyObject call is NULL: Traceback (most recent call last):

  File "/usr/share/harbour-quickddit/youtube_dl/YoutubeDL.py", line 776, in extract_info
    ie_result = ie.extract(url)

  File "/usr/share/harbour-quickddit/youtube_dl/extractor/common.py", line 434, in extract
    ie_result = self._real_extract(url)

  File "/usr/share/harbour-quickddit/youtube_dl/extractor/imgur.py", line 67, in _real_extract
    expected=True)

youtube_dl.utils.ExtractorError: No sources found for video 8ONYfDM. Maybe an image?

I think this might be fixed here: ytdl-org/youtube-dl#16537

Edit: Yeah, that fixes it :)

Hello, it would be nice if Quickddit could parse and preview images uploaded to reddituploads.com

The hot section seems to rely on total upvotes too much, so smaller subreddits get drowned out, the current best tab on reddit seems to compensate for this (or at least smaller subs are more represented there even if having just a couple of upvotes)

Bit niche issue but current link validator doesn't allow ftp links for example: https://www.reddit.com/r/opendirectories/comments/dl3caj/ancient_ibm_stuff/ this will not pass quickddit checks

If I'm not mistaken, Quickddit currently has a dbus interface for handling incoming private messages.

Any thoughts on extending it with the capability of opening subreddits and posts through this interface?

I have an idea for an app that would scan running Kodi instance and show Reddit comments for currently playing (Youtube/Vimeo/...) videos (just like this Firefox addon). I could implement Reddit comments in the app itself, but as Quickddit is already an awesome choice for Reddit access, sending a call through nemo-qml-plugin-dbus would be an easier option. As this app is rather niche (for Kodi+Reddit+SailfishOS users), it wouldn't make sense to bloat Quickddit or Kodimote with it itself.

If the poster deletes their account or disowns their post, their username is shown as "[deleted]". If other users have disowned comments on the post, or commented then deleted their account, they also show up as [deleted]. Quickddit appends [S] to all [deleted] users, making it look like they are all the original poster. On the reddit website, the equivalent microphone symbol is not shown when the original poster is [deleted].

I assume this can be added as an exception to some string matching somewhere. I don't know if there are other 'special' usernames which should also be treated as exceptions.