Comments (4)
Not sure why this got closed, mobile view issue maybe
from quickddit.
Thanks for noticing this! It's a regression that appears on subreddits that have no flairs.
Your patch however could be even shorter. The check for subredditsFlair.length should I think be totally removed, and the check for linkTitle.text.length is already satisfied one line above.
Could you change the line to
&& ((selfLinkSwitch.checked && linkDescription.text.length > 0) || (!selfLinkSwitch.checked && linkUrl.acceptableInput))
from quickddit.
Updated, didn't want to touch the flair part as still never seen this feature in action, so no idea how that works, for normal subreddits checked and the submit button does light up now as expected, thanks!
from quickddit.
Merged, thanks.
Flair is a bit complex, there are subreddits that allow you to choose from a list (which is implemented in Quickddit) and there are subreddits where you can enter custom flair text (not implemented). The flair part in the button enable check was to allow choosing a new flair and submit, but that broke the button for subreddits without a flair list. So, corner case but good find!
from quickddit.
Related Issues (20)
- Allow for specifying a time interval when sorting a subreddit HOT 1
- [Bug] My comments are running away! HOT 2
- Reddit Thirdy Party App API issues and making API's pay to use [NOTABUG] HOT 4
- [ubuntu touch] Please make it possible to edit SubredditsPage.qml like in SailfishOS quickddit
- Videos on v.redd.it don't have audio HOT 1
- Add image gallery support HOT 1
- Crash during parsing reddit gallery HOT 2
- [UBPorts] Issue with multi-account. HOT 3
- Allow internationalization HOT 1
- Subscribed channels not appear in sidebar HOT 1
- Add a Kirigami UI HOT 9
- Not connecting HOT 1
- v1.2 unusable on Xperia X UBPorts HOT 2
- UI gripes in SFOS HOT 2
- Add Github Sponsors support so we can give you a coffee ;) HOT 23
- Logging in doesn't work
- Quickddit forgetting settings HOT 7
- New Organisation in the Sandbox domain doesn't match dbus service
- Register Reddit.com url
- Remove the need for application notification category
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickddit.