Code Monkey home page Code Monkey logo

Comments (21)

Brawmario avatar Brawmario commented on July 24, 2024 5

No headless binary for now, which is needed for this image to work afaik.

There's no headless binary anymore for Godot 4. The Windows, Mac, and Linux binaries now have a headless mode that's activated when ran with the --headless argument.

from godot-ci.

nlaha avatar nlaha commented on July 24, 2024 2

Any updates? Godot 4 is stable now.
https://godotengine.org/article/godot-4-0-sets-sail/

from godot-ci.

Brawmario avatar Brawmario commented on July 24, 2024 2

Hold on @realkotob, the current release of Godot CI 4.0 is broken! It even failed the action for the tag: https://github.com/abarichello/godot-ci/actions/runs/4309001784 . The fact is that the dedicated Linux headless binary is gone and needs to be adjusted in the Dockerfile, maybe PR #104 is still relevant?

from godot-ci.

TheOrioli avatar TheOrioli commented on July 24, 2024 2

The check releases is working correctly, but it seems that the current Dockerfile is incorrect, see workflow:
https://github.com/abarichello/godot-ci/actions/runs/4613295096

To fix 3.5.2 missing, someone with maintainer access to the repository needs to run the Manual Workflow, but first the issue with the Dockerfile should be fixed.

Unfortunately, I currently do not have the capacity to take a look at it.

What I can suggest for Godot 4 CI builds is https://github.com/chickensoft-games/setup-godot I've been using it successfully on our latest project.

from godot-ci.

Calinou avatar Calinou commented on July 24, 2024 2

I'm one of those people looking for 3.5.2 support smiling_face_with_tear Anyone that could help?

I've triggered a workflow run for 3.5.2 stable – check https://github.com/abarichello/godot-ci/actions/workflows/manual_build.yml.

from godot-ci.

Calinou avatar Calinou commented on July 24, 2024 1

As I understand it, only stable releases are planned to be supported by godot-ci. As a result, Godot 4 will only be supported once 4.0 stable is released.

from godot-ci.

maddawik avatar maddawik commented on July 24, 2024 1

Can confirm my CI stuff is "working"! (It is able to pull down and use the 3.5.2 docker image πŸ₯³ but it's failing for other reasons specific to my project, somewhat like this - #48 (comment) - might open a discussion while debugging that later πŸ˜„)

Thank you @Calinou @TheOrioli for the quick build and replies!

from godot-ci.

realkotob avatar realkotob commented on July 24, 2024

Yes, as Calinou mentioned, we do not see value in supporting non-stable releases, as that would add unnecessary overhead to the contributors.

However I have personally made images off of betas and alphas before, so it is very possible and easy (just change the download path).

Let me know if you have difficulty with this.

from godot-ci.

dmcallejo avatar dmcallejo commented on July 24, 2024

No headless binary for now, which is needed for this image to work afaik.

from godot-ci.

realkotob avatar realkotob commented on July 24, 2024

Support for Godot 4.0 was added as a release tag yesterday. πŸŽ‰

from godot-ci.

DavidOcacho avatar DavidOcacho commented on July 24, 2024

Hey guys, just to confirm, this: https://hub.docker.com/r/barichello/godot-ci will be updated to the 4.0 stable as soon as the problem is fixed? Thanks!

from godot-ci.

realkotob avatar realkotob commented on July 24, 2024

This PR has been merged so things should be fixed now
#104

from godot-ci.

Nauja avatar Nauja commented on July 24, 2024

But there is no Docker image because the action didn't run as the release tag already exists ?

from godot-ci.

seanmaxwell avatar seanmaxwell commented on July 24, 2024

I put together a PR for helping complete the support for Godot 4 (#105).

Hoping this can help. Let me know if there is anything I can do to help further. Thanks~

from godot-ci.

SushiWaUmai avatar SushiWaUmai commented on July 24, 2024

Seems like there still isn't a Godot 4 image available. Any updates?

from godot-ci.

Calinou avatar Calinou commented on July 24, 2024

See #107.

It seems that not even 3.5.2 is listed on https://hub.docker.com/r/barichello/godot-ci, so I guess the automated deployment that was merged in #79 isn't working. cc @TheOrioli

from godot-ci.

mattkanwisher avatar mattkanwisher commented on July 24, 2024

Looks like you can just use the official Godot one, and sunset this repo https://github.com/godotengine/godot-build-scripts

from godot-ci.

Nauja avatar Nauja commented on July 24, 2024

Looks like you can just use the official Godot one, and sunset this repo https://github.com/godotengine/godot-build-scripts

From godot-build-scripts:

This repository is not intended for end users, and thus not supported.
It's only public as a way to document our build workflow, and for anyone to use as reference for their own buildsystems.

from godot-ci.

maddawik avatar maddawik commented on July 24, 2024

The check releases is working correctly, but it seems that the current Dockerfile is incorrect, see workflow: https://github.com/abarichello/godot-ci/actions/runs/4613295096

I believe #107 has those fixes you're referring to - it was merged 2 weeks after that failed run which 404'd looking for a bad URL (the -headless bit in particular). Correct me if I'm wrong though

To fix 3.5.2 missing, someone with maintainer access to the repository needs to run the Manual Workflow, but first the issue with the Dockerfile should be fixed.

I'm one of those people looking for 3.5.2 support πŸ₯² Anyone that could help?

from godot-ci.

TheOrioli avatar TheOrioli commented on July 24, 2024

@Mawdac

The check releases is working correctly, but it seems that the current Dockerfile is incorrect, see workflow: https://github.com/abarichello/godot-ci/actions/runs/4613295096

I believe #107 has those fixes you're referring to - it was merged 2 weeks after that failed run which 404'd looking for a bad URL (the -headless bit in particular). Correct me if I'm wrong though

To fix 3.5.2 missing, someone with maintainer access to the repository needs to run the Manual Workflow, but first the issue with the Dockerfile should be fixed.

I'm one of those people looking for 3.5.2 support πŸ₯² Anyone that could help?

image

Seems the build worked🎊 Can you confirm your CI stuff is now operational?

from godot-ci.

Vennnot avatar Vennnot commented on July 24, 2024

What I can suggest for Godot 4 CI builds is https://github.com/chickensoft-games/setup-godot I've been using it successfully on our latest project.

Does this mean 4 will never be supported and instead should use the link provided?

Or would this here be better? https://github.com/marketplace/actions/godot-export

from godot-ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.