on click of "update from abapgit"
because of this: zcl_abapgit_password_dialog-> popup

      PERFORM password_popup
        IN PROGRAM (sy-cprog) <<<<<<<<<<<<<
        USING iv_repo_url
        CHANGING cv_user cv_pass.

When using the "Update from Git" function on a private repo, the program dumps.

Cause: the popup for the password prompt from abapgit (ZCL_ABAPGIT_PASSWORD_DIALOG=>POPUP) is called with sy-cprog , which is SAPLS_CODE_INSPECTOR instead of ZABAPGIT or ZABAPGIT_FULL.

Called in fetch_config:

https://github.com/abaplint/abaplint-abap-backend/blob/661765e887888b4632e82cc2c96448c23fd21bd8/src/zabaplint_ui.fugr.lzabaplint_uif01.abap#L465-L474

it should be valid json...

Suggest removing the following,

PROG XML: <DYNPROS> & <CUA>

FUGR XML: <FUNCTIONS>.<DOCUMENTATION> & <DYNPROS> & <CUA>

The reference to a test class (identification with FOR TESTING) is only possible in test classes.

for zcl_abapgit_injector=>set_longtexts( lo_longtexts ).

Values are empty in this loop:
https://github.com/abaplint/abaplint-abap-backend/blob/661765e887888b4632e82cc2c96448c23fd21bd8/src/zcl_abaplint_backend.clas.abap#L195-L203

Looks like the prefix is missing data-component, see JSON:

Effect:

after #32

There are more than 16 pages of errors.

The code-inspector returns this error:

The shortcut is pointing to sapevent:cinav:CLASZCL_ABAPGIT_DEPS|PROGZCL_ABAPGIT_DEPS==============CO|000001

which does not seem to do anything.

prerequsites: this repo is installed in satellite systems

this should kick in,
https://github.com/larshp/abapGit/blob/master/src/objects/zcl_abapgit_object_msag.clas.abap#L222

respect p_display in sci configuration

Error:
`FUGR /JCS/EXT_RUN_ERP > PROG /JCS/LEXT_RUN_ERPTOP [ @32 ]
Statement does not exist in ABAPv700(or a parser error), "CONSTANTS", #JCS#EXT_RUN_ERP.FUGR.#JCS#LEXT_RUN_ERPTOP.ABAP, p

FUGR /JCS/EXT_RUN_ERP > PROG /JCS/LEXT_RUN_ERPTOP [ @32 ]
Statement does not exist in ABAPv700(or a parser error), "CONSTANTS", #JCS#EXT_RUN_ERP.FUGR.#JCS#LEXT_RUN_ERPTOP.ABAP, p

FUGR /JCS/EXT_RUN_ERP > PROG /JCS/LEXT_RUN_ERPTOP [ @32 ]
Statement does not exist in ABAPv700(or a parser error), "CONSTANTS", #JCS#EXT_RUN_ERP.FUGR.#JCS#LEXT_RUN_ERPTOP.ABAP, p

FUGR /JCS/EXT_RUN_ERP > PROG /JCS/LEXT_RUN_ERPTOP [ @32 ]
Statement does not exist in ABAPv700(or a parser error), "CONSTANTS", #JCS#EXT_RUN_ERP.FUGR.#JCS#LEXT_RUN_ERPTOP.ABAP, p

`

Code:

The dependencies generated contain message area's named >0 etc.

The two function modules at the end are:
AA_DEP_KEY_IS_UOP?
AA_DEPR_KEY_IS_UOP?

The include a question mark in the name.

With some projects i get this message.

It is unclear what the problem is.

Identified class ZCL_ABAPGIT_OBJECT_ENHS.

The SAP message classes with strange names >4 are not recognized although they exist.

Also the message class "00" is not.
./src/xbp/#redwood#xbprsdbspva.prog.abap[1, 39] - Message invalid: Message class "00" not found (message_exists)

Or should the message classes also be generated as part of the dependencies?

What about renaming these 2 repos: the names are rather confusing currently and do not show the link between each other. e.g. ...backend is in fact a client application.

what about:

• abaplint-sci-client for this one
• and abaplint-sci-server or abaplint-sci-backend for the js server or just abaplint-backend (which will follow the docker hub name)

When errors are found in a SAP delivered object, then they can not be handled and should be ignored.

SAP Delivered = Source System is SAP.

see abaplint/abaplint#1010

Assertion failed - seems to fixed in the latest version, but UT does not pass, just with another error

which would allow for easier testing/development of the linter itself

In the message from SCI, the rule is not mentioned that was failing.
FUGR /JCS/BC > PROG LBTCHDEF [ @518 ] Variable "rc_tgt_host_chk_has_failed" not used, #JCS#BC.FUGR.LBTCHDEF.ABAP

like in the pipeline:
/tmp/abaplint-aigijg/src/cx_salv_bs_tools_conv_error.clas.abap[1, 1] - Expected CLASSDEFINITION (structure)

Extracted from #42.

The error description was getting to long. If the information is still required, how should it be made visible?

Old:

New:

Options for resolution:

• remove the file path (current implementation)
• put it at the end
• on a new line?
• as hover-text over the url
• only show it when required

the abaplint/dependencies project has dependencies defined.

Code Inspector messages:

AbapLint config:

The GitHub workflow did not have this issue. Does the Docker-Image require changes for this?

Running ZABAPLINT_DEPENDENCIES assert exception was raised due to an empty name in the node table

Node table

Based on Pull Request #61 (for issue 58).

After the dependencies are resolved, the program ZABAPLINT_DEPENDENCIES serializes the code (BUILD_CODE method). It gets the above exception while processing the interface IF_ADT_LIFECYCLE_MANAGER (from SAP).

What is the cause of this exception?

example with abapGit, following should be found as a dependency chain,

zcl_abapgit_popups -> cl_salv_events_table -> if_salv_events_actions_table

Looking at downporting possibilities ... for the moment stumbled upon 2 issues:

• /ui5/cl_json_parser at zcl_abaplint_json_reader: will try to replace with cl_fdt_json=>json_to_data ? or maybe leave the validation to the backend ???
• IF_T100_DYN_MSG at exception: hmm, what's the heck it this :)))) looks like a combination of IF_MESSAGE and IF_T100_MESSAGE and a couple of attrs ... do you think I can remove ?

@larshp

making PR for abapGit

We are using a gitlab server with self-signed certificates.
with git one can define "-c http.sslverify=false" to ignore the error " SSL certificate problem: self signed certificate".

Is it possible to add git options also in the dependencies definition of abaplint.json?

classes with backend logic should never WRITE

instead output the level as part of the returning

The backend does not show it's abap-lint version in the log or in the SCI results.

Both would be very helpfull with the handling of tickets.

much like
https://github.com/abapGit/dependencies/blob/master/src/zcl_abapgit_deps_find.clas.abap

Dependency detection currently only works for a certain number of objects. As many more objects are supported by AbapGit, this creates issues.

of

PROG ZABAPLINT_DEPENDENCIES

E.g. from

Based on #58

Currently, the SCI integration runs a dependency for each object separately. It needs to be run once for the object presented at the initial call.

Running Code-Inspector can take quite some time.
To make it easier, the packages are structured hierarchically. One can use the folder view to reduce the list of objects.

It would be a great improvement if only the current package (and its sub packages) would be checked by Code-Inspector.

Although it is configured

Based on #58

The list of dependencies does not have any duplicates. I've removed all entries from the target repository.

When these are serialized, the job stops with this message:

Duplicates: /kgal.fugr.rk_al_seq_delete.abap
OTR-Based Exception of Class: ZCX_ABAPGIT_EXCEPTION

What is causing this?

In the AbapLint Backend, the serializer is called to generate dependency code.

The package is filled

The resulting path does not contain it.

Is that meant to be this way?