Ignore errors found if Object is SAP delivered about abaplint-sci-client HOT 14 CLOSED

i exclude such SAP includes/objects:

   "keyword_case": {
      "exclude": [
        "<include_name>"
      ],

but it would be nice if there was a more general "exclude setting" to avoid processing all rules for SAP objects. Something like

{
  "global": {
     "skipSAPobjects":true,

from abaplint-sci-client.

This should also be done in AbapLint for the same reason.

from abaplint-sci-client.

set the errorNamespace = own objects only in the abaplint.json config

from abaplint-sci-client.

that is set to "errorNamespace": "^(\/REDWOOD\/)", or "errorNamespace": "^(\/JCS\/)",

The errors we are getting currently are in 3 area's that are already reported issues:

• structure not found (and dependend errors like "not a structure"
• Message invalid

But we also get these which are clearly outside of the namespace set

from abaplint-sci-client.

Just came about another exampled. We use the include LBTCHDEF.
It does not adhere to upper/lowercase settings and fails the keyword_case check.

from abaplint-sci-client.

Or when code is generated. Here an example of generated view include attributes (editor lock and done by SAP*)

from abaplint-sci-client.

its

  "syntax": {
    "errorNamespace": "^(Z|Y|LCL_|TY_|LIF_)",

from abaplint-sci-client.

It is not just this check... (there could be more). In my case:

FUGR /JCS/BC > PROG LBTCHDEF [ @113 ] 
Indentation problem, expected 0 spaces (indentation)

FUGR /JCS/BC > PROG LBTCHDEF [ @437 ] 
Keyword should be upper case: "type" (keyword_case)

FUGR /JCS/BC > PROG LBTCHDEF [ @113 ] 
Start statement at tab position (start_at_tab)

from abaplint-sci-client.

in my case, LBTCHDEF gives an error because the SAP standard TADIR entry for the object does not exist,

from abaplint-sci-client.

There is an additional case that causes similar problems.
When one has generated maintenance views, then several of the objects have an editor lock (set by user "SAP*") which can not be changed.

Also here, one gets numerous errors that can not be removed.
./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionsf00.abap[8, 17] - Remove space before "," or "." (space_before_dot) ./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionsf00.abap[8, 9] - Identifiers should be lower case: "LSVIMFTX" (keyword_case) ./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionsi00.abap[7, 17] - Remove space before "," or "." (space_before_dot) ./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionsi00.abap[7, 9] - Identifiers should be lower case: "LSVIMITX" (keyword_case) ./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionst00.abap[10, 1] - Chain mainly declarations (chain_mainly_declarations) ./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionst00.abap[13, 26] - Remove space before "," or "." (space_before_dot) ./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionst00.abap[14, 25] - Remove space before "," or "." (space_before_dot) ./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionst00.abap[17, 19] - Remove space before "," or "." (space_before_dot) ./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionst00.abap[17, 3] - Indentation problem, expected 0 spaces (indentation) ./src/fpa/#jcs#fpa_actions.fugr.#jcs#lfpa_actionst00.abap[7, 17] - Identifiers should be lower case: "STATUS_/JCS/FPA_ACTIONS" (keyword_case)

from abaplint-sci-client.

Now with a great effort from @larshp (many Thanks), most of the issues with syntax are resolved.

What now is left are +200 errors related to rules being applied to generated code or sap original code.
I do not wish to water down the rules more to keep the quality of our code up.

from abaplint-sci-client.

yes, if the INLCUDE is a dependency, and used in a main object, then the errors should be ignored

from abaplint-sci-client.

It’s pointless to check any SAP code. Just scan to find dependencies. But check the include if it is used in the repo code.

Thanks both for the hard work!

from abaplint-sci-client.

By squashing the FORMS and Functions in the dependency repository, the issue is resolved.

Thanks

from abaplint-sci-client.