Is it possible remove all console.log()? about ngx-scanner HOT 7 CLOSED

Logs removed in v1.1.0-dev.c38faf.

Wiki not ready yet.

Please, if someone has some step-by-step on how to debug in some IDE, please make a PR. 😉

from ngx-scanner.

Yes, sure. You're right. Thanks for answer me!

I think it's not a good solution because the logs for console.debug() are still there but hidden. So, maybe it's a best solution if you comment this line for users and uncomment only when you need fix or improve something.

Some applications use loggers and that makes impossible to read logs.

After a few seconds I see this in console:

Anyway, I hope this observation also helps someone else! Thanks for all! :)

from ngx-scanner.

So, I forgot to say, but if anyone has instructions on how to debug a Angular app in any editor and wants to remove that console.debug, we're accepting PRs in both Wiki and source code for that. 😉

from ngx-scanner.

Sure it is, also, we already have none. 😅

We have just one console.debug.

What browser are you using? I'm sure if it is Chrome >= 58, you can disable verbose level:

As long as we have the possibility to debug TypeScript code trought VSCode, I do think we can remove the debug method, but I will have to configure at least one environment and document it for future contributors first.

from ngx-scanner.

Hello @odahcam Excellent work with the scanner!
I think like @rastajpa. I'm trying to use it in an important project and it's impossible because of the amount of unnecessary logs. I would appreciate if they deleted, or at least commented on the lines they print on the console. I do not want to be forced to change the scanner module, since this is the best one for angular 4 of the ones I've tested.

Thank you and regards!

from ngx-scanner.

Don't worry! I just didn't knew if I would be able to make this change until v1.1, but please, that's too much log! So I'll remove it at v1.1 anyway.

from ngx-scanner.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from ngx-scanner.