ZxingScannerComponen.init method called twice when enable flag is set to true (leak once again) about ngx-scanner HOT 8 OPEN

the fix is indeed not addressing the root of the problem. with my upcoming vacation I'm not sure when I will find time to look deeper into it that's why I keep the issue open.

from ngx-scanner.

Is this still the case with the version from today? From looking at the code this should be resolved via #557

from ngx-scanner.

Is this still the case with the version from today?

Yes, your PR fixed problem with disposing scanning process on component destroy.

This issue is caused by initializing scanning process twice when enable input is set to true. Stackblitz repro is based on the newest version 17.0.2

from ngx-scanner.

Damnit, as setting enable to false calls the reset method I was hoping this would be resolved. I'll take a look then. Thanks

from ngx-scanner.

If you setup breakpoint in ZXingScannerComponent.scanFromDevice you'll see it's called twice on component creation and this._scanSubscription is overwritten.

from ngx-scanner.

Good point! Thank you

from ngx-scanner.

plz test 17.0.3

from ngx-scanner.

I'm afraid it solves my repro but the root of the problem is more complicated

IMO these leaks are caused by:

• calling async methods from sync context (ngOnInit and enable setter)
• parent component/template can toggle enable flag many times which leads to multiple ZxingScannerComponent.init calls without clearing previously created scanning processes

Simple example:

<button (click)="scannerEnable = !scannerEnable">Toggle scanner enable</button>
<zxing-scanner [enable]="scannerEnable"></zxing-scanner>

it causes leak when you toggle enable flag few times quickly

from ngx-scanner.