Code Monkey home page Code Monkey logo

Comments (5)

werthdavid avatar werthdavid commented on August 10, 2024 2

@csutorasr thanks for the example, looks very clean in deed.
I'd suggest to go with this solution, I think we're making our life harder by introducing more Inputs.
If somebody doesn't understand how to properly use that syntax he can still (for now) use the hacky /deep/ workaround but I don't like the idea of more complexity with Inputs just b/c some people might not understand it

from ngx-scanner.

csutorasr avatar csutorasr commented on August 10, 2024 1

Yes it must be removed. I posted some parts at the wrong issue (#55). I add a stackblitz to the other issue.

from ngx-scanner.

csutorasr avatar csutorasr commented on August 10, 2024

Please DO NOT do that. ::ng-deep is deprecated.

Use max-width attribute instead or something like that.

Please, do not forget you are using Angular built of components. (This is not the first issue where this is forgotten.)

from ngx-scanner.

odahcam avatar odahcam commented on August 10, 2024

It is deprecated because you shouldn't be able to do anything to the elements inside a component that's not yours.

::ng-deep is the recomended solution in emulated shadow DOM, but you shouldn't be able to change anything inside the component anyway.

I would like to hear more about your ngTemplate idea. The attribute will be removed anyway, it's a trouble generator.

from ngx-scanner.

lock avatar lock commented on August 10, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from ngx-scanner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.