Turn on flashlight about ngx-scanner HOT 5 CLOSED

It's a nice feature, but maybe it's not responsability of the scanner itself. Let's discuss about the architecture we gonna take for that before taking any premature decision.

• Changing the MediaStream to readonly is possible.
• I would not like to add more logic inside the startDecodeFromStream method, it is already too big.
• Maybe some refactor will be needed the same way I did with the component class for v1.

let torcherFunction = stream => {

    // Get track for image capture
    const track = stream.getVideoTracks()[0];

    // Create image capture object and get camera capabilities
    const imageCapture = new ImageCapture(track)
    const photoCapabilities = imageCapture.getPhotoCapabilities().then(() => {

        // todo: check if camera has a torch

        // let there be light!
        track.applyConstraints({
            advanced: [{
                torch: true
            }]
        });

    });
};

• Do we need the imageCapture.getPhotoCapabilities or can we work directly on the track object?
• Feel free to add more points. 😀

from ngx-scanner.

Sorry, as stream is being saved, only a new function is needed called setTorch. It should contain the code to set the torch on and off.

It would be better, if the startDecode function would be separated into private parts like bindSrc, bindEvents, checkTorchCombatibility (as it is needed to be checked once). A property could be saved to show torch compatibility.

setTorch checks if torch can be activated through the variable and sets on/off it.

Maybe instead of a variable an event would be better, as from the component it is easier to bind values to events.

Edit:
I would add it into the scanner, as it is really a workaround to set/get values of components in Angular. A compontent should not be modified from outside.

from ngx-scanner.

Sorry, as stream is being saved, only a new function is needed called setTorch. It should contain the code to set the torch on and off.

I like that.

I would add it into the scanner, as it is really a workaround to set/get values of components in Angular. A compontent should not be modified from outside.

I did not remember very well how their logic is separated, sorry, I gotta take a look again to see what insights I will have. xD

I work with a lot of things at the same, so sorry if I misundertood.

from ngx-scanner.

Closing as merged.

from ngx-scanner.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from ngx-scanner.