Code Monkey home page Code Monkey logo

Comments (8)

odahcam avatar odahcam commented on August 10, 2024

I think that 172561e should do the trick. I could not test it yet. The environment to test should be based on the angular-universal-starter template.

from ngx-scanner.

odahcam avatar odahcam commented on August 10, 2024

I noticed that this was breaking some SSR, also this could be an error with my polyfills.

from ngx-scanner.

csutorasr avatar csutorasr commented on August 10, 2024

Try this. If it is a browser do not load anything.

E. g. this line should be moved to the ctor.

If the platform is browser the component should not do anything. Maybe a placeholder class is good for this that's functions are implemented as dummy, but has the same interface as the qr reader class.

from ngx-scanner.

odahcam avatar odahcam commented on August 10, 2024

E. g. this line should be moved to the ctor.

Agreed.

I reduced that behavior by checking typeof navigator before using it, but it stills buggy sometimes.

from ngx-scanner.

csutorasr avatar csutorasr commented on August 10, 2024

The first link helps how to realize if it is a browser. You don't need the navigator object for that. (navigator may be tree-shaken and the build will remove it during AOT build.)

from ngx-scanner.

odahcam avatar odahcam commented on August 10, 2024

I've implemented that in a new branch, but I couldn't test it in server-side yet.

from ngx-scanner.

odahcam avatar odahcam commented on August 10, 2024

Fixed in #78.

from ngx-scanner.

lock avatar lock commented on August 10, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from ngx-scanner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.