zviadm / celoterminal Goto Github PK

Environment
Operating System: n/a
Celo Terminal Version: 1.0.16

Describe the bug
Connecting to a non existing node shows weird error message

To Reproduce

Expected behavior
Should show more clear error message that the connection is failing completely.

Environment
Operating System: all
Celo Terminal Version: 1.11.15

Describe the bug
If one uses a proxy pattern like EIP-1167 celoterminal gives no insights in the actual transaction data.

E.g. this contract was deployed using the ClonesUpgradeable lib from openzeppelin: https://explorer.celo.org/address/0x31927663bb737a1eD7655b0684986A836F52E548/read-contract

celoscan and the likes have support for that pattern, but celoterminal hides the transaction data, making the multisig pattern unusable, as there is no insight into what one is actually signing:

To Reproduce
Steps to reproduce the behavior:

1. Create a multisig wallet
2. Generate a tx to the contract above (e.g. using approve)
3. Submit it and review on celo terminal
4. See error

Expected behavior
See insights into the actual transaction data

Metamask only supports the Ethereum Ledger App for any EVM chain. This means, it's not possible to use wallets from the Celo Ledger App with Metamask. On the other hand, Celo Terminal only supports the Celo Ledger App.
If I want to use Celo Terminal to send, swap, mint, ... I need to transfer tokens between the Ethereum-derived wallet and the Celo-derived ones.

I was able to add a wallet from the Ethereum app using the custom path option when importing a wallet.
However, when making a transaction it fails saying "Ledger device: can not connect. Make sure your Ledger device is connected, unlocked, and the Celo app is launched."

Would it be possible to add support for Ethereum Ledger Wallets in Celo Terminal?
Thanks!

Describe the bug
When locking Celo not enough celo is left in wallet to perform a withdrawal in future.

To Reproduce
Steps to reproduce the behavior:

1. Lock Celo
2. Note balance

Please attach screenshots if you can.

Expected behavior
Keep at least 0.01 Celo or another reasonable amount or you could only lock up to the nearest full integer.

Environment
Operating System: macOS 12.0.1
Celo Terminal Version: 1.11.5

Describe the bug
Trying to update Celo Terminal, clicking on the "v1.11.5 → v1.11.13" button at the bottom of the left menu, leads to nothing after 30mins+ of waiting. Refreshing the page with cmd+r removes the loading bar under the clicked button and suggests the app wasn't really updating.

To Reproduce

1. open app
2. Click on "v1.11.5 → v1.11.13" button at the bottom of the left menu
3. See the progress bar animation, wait
4. Nothing happens (app update expected?)

Expected behavior
App should update after clicking that button? How should we update otherwise? Thank you

The workflow build.yml is referencing action actions/checkout using references v1. However this reference is missing the commit a6747255bd19d7a757dbdda8c654a9f84db19839 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

Currrently

Celoterminal only supports WalletConnect Protocol by copying and pasting the wc uri into celo terminal app.

Issue

Copying and pasting is not a nice User experience as a deep link. and means that celo terminal cant be used by many dapps that support wallet connect as not all provide the link to copy and paste

Comparisons

CeloWallet.app supports deeplinking on both web and desktop

request

was leaving the out deliberate or would you support this feature being added?

reference

https://developer.apple.com/documentation/xcode/defining-a-custom-url-scheme-for-your-app

Environment
Operating System: macOS 13.3.1
Celo Terminal Version: 1.14.6

Describe the bug
Trying to connect to a dapp using wallet connect v2, when copying the wallet connect connection string and pasting it into Celo Terminal, the connection does not connect and gives what seems like a Wallet connect V1 error:

Invalid WalletConnect v1 QRCode: Error: Invalid or missing bridge url parameter value

The Celo terminal docs state: "Celo Terminal supports WalletConnect v2.0 out-of-the box."

To Reproduce
Steps to reproduce the behavior:

1. Go to https://react-app.walletconnect.com/
2. Disable Testnets Only switch
3. Select Celo network
4. Click "connect" button to open wallet connect modal
5. copy connection string
6. open Celo Terminal
7. Select Wallet connect option
8. Paste connection string into "QRCode" field in Celo terminal

Please attach screenshots if you can.

Expected behavior
A wallet connect connection should be established

Environment
Operating System: macOS 13.5.1
Celo Terminal Version: [e.g. 1.0.16, version is located at the bottom of the app menu]

Describe the bug
Cannot connect Celo Terminal (local) wallet to stCelo app via WalletConnect.

To Reproduce
Steps to reproduce the behavior:

1. Go to app.stcelo.xyz
2. Click on connect > walletconnect > "open"
3. Copy the the URI
4. Go to Celo Terminal > WalletConnect
5. Paste URI
6. Click connect
7. See error ("Not initialized. subscription")

See attached video:

Attempted debugging:

• To debug, I attempted to follow guidance here: https://docs.celoterminal.com/guides/using-walletconnect
• Test: I’m able to connect Safe (app.safe.global) with stCelo (app.stcelo.xyz) over WalletConnect.

Expected behavior
When pasting a WalletConnect URI, Celo Terminal should connect.

Can the wallet be developed?
for mobile app

Environment
Operating System: MacOs 11.4
Celo Terminal Version: 1.9.12

Describe the bug
WalletConnect relayer connection can disconnect in the background if Celo Terminal remains in the background for extensive periods of time (>12-24 hours). Once background connection is dropped, WalletConnect features no longer work, until Celo Terminal is restarted or reloaded.

Expected behavior
WalletConnect relayer connection needs to automatically reconnect if it drops.

Temporary workaround is to reload CeloTerminal when this issue happens:
https://docs.celoterminal.com/guides/using-walletconnect#troubleshooting-issues

Environment
Operating System: Ubuntu 18, Ubuntu 20
Celo Terminal Version: 1.3.2

Describe the bug
Can not connect to Ledger device

To Reproduce
Steps to reproduce the behavior:

1. Go to Accounts
2. Click on "Add Ledger Account"
3. See error

Please attach screenshots if you can.

Expected behavior
A clear and concise description of what you expected to happen.

Environment
Operating System: MacBook Pro con Ventura 13.5
Celo Terminal Version: 1.18.2
Ledger version: Nano X firmware 2.2.1

Describe the bug
Mento app in Celo Terminal loose connection with Ledger Nano X during a trade.

To Reproduce
Steps to reproduce the behavior:
0. Ledger NanoX with Celo app and enough CELO to trade

1. Connect Ledger Nano X to Celo Terminal
2. Go to Mento app in Celo Terminal
3. Enter CELO amount to convert to cUSD and click on "Trade"
4. Scroll the information on Ledger screen, and you will see a "Ledger device: Can not connect: Make sure your Ledger device is connected, unlocked, and the Celo app is launched". Celo app in Ledger Nano X freezes, and it needs to be restarted.

Screenshots attached.

Expected behavior
Trade CELO for cUSD the same way it works with Ledger Nano S.

Environment
Operating System: Win10
Celo Terminal Version: 1.18.2

Bug description
I tried to create a new MultiSig using the 'Create MultiSig Account' in the Accounts tab.
I keep getting this error: 'ENS is not supported on network private' and the creation systematically fails, consuming the fee.
I tried swapping the owners' addresses but it does not seem to make a difference.
Looks like this is a known issue in the Ethereum community but I cannot find any trace of it in Celo dapps.

The tx initiating the smart contract goes through (e.g. here) but when I try to add the multisig by importing the contract's address, I run into an error code stating the execution was reverted: 'execution reverted: No Implementation set'

Can someone look into this and give a noob some help?

Needed for both multisig and simple accounts.

There is an ongoing issue with @celo/sdk and Ledger Hardware wallets.
This issue provides a brief summary and some potential work arounds.

CeloTerminal currently pins its dependencies on @celo/sdk v4:

• CeloTerminal and Ledger Nano X with Firmware <=1.2.4-4 should work in all cases.
• CeloTerminal and Ledger Nano S with Firmware <=1.6.1 should work in all cases.
• Ledger Nano devices with newer firmware (after support for Ethereum 2.0 was added) will work with CeloTerminal for some simple transactions, but they will start failing with "EthAppPleaseEnableContractData" errors for some more complex transactions.

@celo/sdk v5 (and maybe v8?) no longer work with any version of the Ledger Nano firmware. This is why CeloTerminal is using really old @celo/sdk v4.

Unfortunately there isn't much that can be done in CeloTerminal itself to resolve this issue. We are waiting on @celo/sdk to fix these issues.

Environment
Operating System: Windows 10
Celo Terminal Version: 1.9.19

Describe the bug
Trying to execute "executeMany" function on the 0x313bc86D3D6e86ba164B2B451cB0D9CfA7943e5c contract produces an error "param.map is not a function".

To Reproduce
Steps to reproduce the behavior:

1. Go to SC Inspector
2. Paste 0x313bc86D3D6e86ba164B2B451cB0D9CfA7943e5c in the Contract address
3. Click WRITE
4. Click executeMany
5. Type "0x313bc86D3D6e86ba164B2B451cB0D9CfA7943e5c,0x313bc86D3D6e86ba164B2B451cB0D9CfA7943e5c" into to() field
6. Type 0,0 into value() field
7. Type 0x12,0x12 into data() field
8. Click EXECUTE

Expected behavior
Transaction is sent.

Environment
Operating System: [e.g. macOS 14.5]
Celo Terminal Version: 2.0.6

Describe the bug
When trying to sign a transaction with wallet connect with a wallet in a ledger, the following error prompts: Gas must be provided to sign a transaction.

Signing messages under the same conditions do work.

To Reproduce
Steps to reproduce the behavior:

1. Go to any dApp that supports Wallet Connect (like stCelo) and get the QR/URL
2. Connect that URL with Celo Terminal
3. Try to sign a tx in the app.
4. Celo terminal promts, but then the error prompts. The frontends usually also acknowledge an error.

Expected behavior
Transaction should be signed and then broadcasted by frontends.

Environment
Operating System: Windows 11, Linux

Celo Terminal Version: 1.15.0, 1.11.1, 1.18.5

Describe the bug
I can't connect to autofarm using wallet connect and celo terminal. I used it one year ago on a macbook and it was working
I tried with ledger and also with wallet using private keys directly.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://autofarm.network/
2. Click on Wallet
3. Login with WalletConnect

Expected behavior
I expect to login on autofarm

Environment
Operating System: N/A
Celo Terminal Version: v1.8.0, v1.8.1

Describe the bug
In SC Inspector app, contract address only works if it is fully checksummed version. It should work for lower case addresses too.

To Reproduce
N/A

Expected behavior
N/A