zrosenbauer / tls-monitor Goto Github PK

Please do not report security vulnerabilities here. Submit all security issues to [email protected].

Thank you in advance for helping us to improve this library! Please read through the template below and answer all relevant questions. Your additional work here is greatly appreciated and will help us respond as quickly as possible. Finally, to avoid duplicates, please search existing Issues before submitting one here.

By submitting an Issue to this repository, you agree to the terms within the Code of Conduct.

Describe the problem you'd like to have solved

Add support for PagerDuty Alerting.

Describe the ideal solution

A clear and concise description of what you want to happen.

Alternatives and current work-arounds

A clear and concise description of any alternatives you've considered or any work-arounds that are currently in place.

Additional context

Add any other context or screenshots about the feature request here.

Description

Action reports success even if the domain could not be checked!
Action output see repro ->

Reproduction

Run bluenovaio/action-tls-monitor@main
  with:
    domain: deleteonerror.com
    expiration_days: 30
    approved_protocols: TLSv1.3
(node:2076) UnhandledPromiseRejectionWarning: Error: write EPROTO 139733454043008:error:1409442E:SSL routines:ssl3_read_bytes:tlsv1 alert protocol version:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1544:SSL alert number 70

    at WriteWrap.onWriteComplete [as oncomplete] (internal/stream_base_commons.js:87:16)
(node:2076) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2076) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Environment

 Current runner version: '2.278.0'
Operating System
  Ubuntu
  20.04.2
  LTS
Virtual Environment
  Environment: ubuntu-20.04
  Version: 20210504.1

Please do not report security vulnerabilities here. Submit all security issues to [email protected].

Thank you in advance for helping us to improve this library! Please read through the template below and answer all relevant questions. Your additional work here is greatly appreciated and will help us respond as quickly as possible. Finally, to avoid duplicates, please search existing Issues before submitting one here.

By submitting an Issue to this repository, you agree to the terms within the Code of Conduct.

Describe the problem you'd like to have solved

Move ALL logic out of main.ts as this will make it more testable so we can test uses cases such as raised in #24.

Describe the ideal solution

A clear and concise description of what you want to happen.

Alternatives and current work-arounds

A clear and concise description of any alternatives you've considered or any work-arounds that are currently in place.

Additional context

Add any other context or screenshots about the feature request here.