Code Monkey home page Code Monkey logo

sketch-android-assets's People

Contributors

bomberstudios avatar cjeffries avatar courtneyetc avatar henningms avatar kmorey avatar richardgazdik avatar sveinungkb avatar zmalltalker avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

sketch-android-assets's Issues

Generated Android assets are not correctly using slices

If I generate android assets from a document with different pages and artboards, some uf them are misplaced and add transparent parts to the side of the images. I tried to attach two examples which where generated to make it a bit easier to understand the issue.

I tried already to delete and re-create the slices but it didn't help so far.

edu_land_search_fr-2
edu_land_search_de 2

If you compare these two images, you will see, that the _fr version (1st file) is fine, but the _de version (2nd file) is kind of moved to the right and on the left there is a transparent part.

Create 9-patch images

It would be really cool (if possible) if you could create 9 patch assets too. The reason it doesn't work now is that the black bars on the side are scaled too, making them not always 1px. Maybe there is a way you could use the slice name to tell if the user intends the asset to be 9 patch.

Export size issues

I have 96x96px Artboard. When Artboard is selected export results in 136x136 px PNG, when Slice is selected it's OK 96x96px. Graphic is the same size, but there is 20px padding on Artboard export.

No longer work with Sketch 41

The plugin was working in Sketch 40.x even though it has been labelled as legacy plugin, but in v41, it no longer works. It is not exporting anything, and it strangely duplicated the selected artboard as a result.

@zmalltalker Wondering if you have some time to look at it and rewrite a working one? I wish I could write myself, but not really an engineer here :)

Change export base

I choose export from hdpi first time, and this plugin remembers my choice. However a later time I want to export from mdpi, how do I change the default export base?

Doesn't work in Sketch 3

Breaks on the following line:
slice = [MSSlice sliceWithRect:rect scale:factor];

With the error: "ReferenceError: Can't find variable: MSSlice."

Confused as to how this works

How do I select which assets to export? Do I have to take out the ones I want and put them in a separate sketch document, then generate from there?

Export Android assets for single artboards

It would be great if the possibility is given to export only single artboards instead of the whole document everytime. Or is it actually given, but I wasn't able to find? :)

Export adds a large amount of margin at the borders

When I use the Plugin in the current state, it is generating images with a huge amount of margin at all sides which makes the files useless. Is this a known issue?

The artboards in the test file look like this:
sketch_page

The results look like this:
result

Sketch Crashing

My Sketch crash every time i press on the export, and sometimes we need to open a new document and cmd+c and cmd+v og be able to export the assets. 2 huge issue i hope you are aware off.

We have this issue on 2 computeres that is running Sketch 3.4.3 (16044)

I have attached the Crash report.
Crash.txt

.android_assets is autogenerated

For some reason the file .android_assets gets generated and saved to the same directory as the sketch file every time i try to export android assets. Is this a bug or a feature?

Plugin isn't working properly in Sketch 3.4

Hey @zmalltalker I use this plugin every day, it's quite useful 😄

Unfortunately it's not working properly in Sketch 3.4 – all of my assets are larger than they should be. For instance, a 96 x 96 asset has turned into a 481 × 145 asset somehow. Hopefully you can fix it soon!

Not Working for Skech 3.3.1

I'm using this plugin before Sketch 3 came.I upgraded my sketch version to 3.3.1 now the plug seems not working for generating the assets..

Update for Sketch 3 support?

Do you plan to update this plugin for Sketch 3? Although there is better Export in Sketch 3 I would still use it. ETA?

Generated Android assets are mixed up

I created a document with 3 pages. Each of these pages has 4 artboards and 4 slices for export. If I Generate Android Assets, the artboards and file names seems to be totally mixed up. With a bit of investigation I noticed, that all the artboards in the pages are filled with the contents of the page which is choosen while execute the Generate Process. Means:

  • artboardExample1_de = English contents
  • artboardExample1_en = English contents
  • artboardExample1_fr = English contents

The document structure is built like this:
-- PageGerman
---- ArtboardExample1_de + Slice
---- ArtboardExample2_de + Slice
---- ArtboardExample3_de + Slice
---- ...
-- PageFrench
---- ArtboardExample1_fr + Slice
---- ...
-- PageEnglish
---- ArtboardExample1_en + Slice
---- ..

CocoaScript Support

Good Morning / Afternoon / Night (depending on your timezone :)!

As you probably know, Sketch will switch its scripting backend from JSTalk to CocoaScript in the upcoming version 3.0.2.

As a result of this change, some plugins will stop working unless you fix them.

Guess what? Yours seems to be one of them. But worry not! We've identified some of the issues, and the fixes are easy to do (so far :)

Please take a look at the info we've compiled at https://github.com/sketchplugins/cocoascript-migration/, make your changes, and test your scripts with the latest beta. Please don't hesitate to get in touch if you need more help!

Sorry about the extra work, and thank you for your contribution to the amazing Sketch Plugins community :)

Ale M — Bohemian Coding

Generated slices are not transparent

In Sketch 3 when exporting through the plugin the background of the slices are not transparent. On the contrary, when exporting through the native Sketch feature (File > Export) the slices do have a transparent background...

How can I export against a transparent background?

PS: Please also tell people they need to select the slices before running the plugin.

Cmd + Shift + A clashes with a new Sketch keyboard shortcut

Hi there,

we just added a new keyboard shortcut to Sketch for an upcoming version, and the shortcut you're using (Cmd + Shift + A) will clash with that.

I'm letting you know in advance in case you want to modify the shortcut in your Plugin. Thanks in advance!

Organize Android Assets into Folders & "Export Group Contents Only" Features

Pixi-Stix has a branch of your code (https://github.com/pixi-stix/sketch-mobile-assets) where assets are organized into folders, saving lots of time. Though one feature that lacks in comparison to sketches default exporter, is the feature where you can click on the slice and select ""Export Group Contents Only", this prevents you from having to hide other background layers, again, saving lots of time. It would be great to implement a similar feature. Thanks!

Ps. Sorry for the "pull request earlier", i'm a github noob :)

Android Assets not working in 3.3 GM

Hi,

Generate Android Assets has stopped working for me in the 3.3 series, running Version 3.3 (11920).

No assets are exported any longer, so I have to copy everything over to a Sketch 3.2 version to export. Any ideas? Thanks for building an awesome tool!

Pierre

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.