I do not know how to reproduce this happened to me twice now on master <a href="https:

<a class="user-mention notranslate" data-hovercard-type="user" data-hover

Many transaction notifications when opening a wallet.,about zksnacks/walletwasabi

soosr commented on June 16, 2024 1

I also encountered it once recently. But I was playing with SkipSynchronization flag and I thought it was because of it.
Normally it shouldn't happen.

Taking a look at the code a notification is popped when the WalletRelevantTransactionProcessed event fires:

WalletWasabi/WalletWasabi.Fluent/ViewModels/WalletManagerViewModel.cs

Line 22 in 57edd43

    
           .FromEventPattern<ProcessedResult>(Services.WalletManager, nameof(Services.WalletManager.WalletRelevantTransactionProcessed))

But if the wallet is not logged in and the WalletState is not Started, it won't show a notification.

So the only thing I can think of is something changed on the business side, around transaction processing. And all of those transactions trigger the event even after the state turned to Started.

@yahiheb Do you know about any change around it recently?

Full code

WalletWasabi/WalletWasabi.Fluent/ViewModels/WalletManagerViewModel.cs

Lines 21 to 58 in 57edd43

    
           		Observable 
        
           			.FromEventPattern<ProcessedResult>(Services.WalletManager, nameof(Services.WalletManager.WalletRelevantTransactionProcessed)) 
        
           			.ObserveOn(RxApp.MainThreadScheduler) 
        
           			.SubscribeAsync(async arg => 
        
           			{ 
        
           				var (sender, e) = arg; 
        
           				if (Services.UiConfig.PrivacyMode || 
        
           					!e.IsNews || 
        
           					sender is not Wallet { IsLoggedIn: true, State: WalletState.Started } wallet) 
        
           				{ 
        
           					return; 
        
           				} 
        
           				if (TryGetWalletViewModel(wallet, out var walletViewModel) && walletViewModel?.WalletViewModel is { } wvm) 
        
           				{ 
        
           					if (!e.IsOwnCoinJoin) 
        
           					{ 
        
           						void OnClick() 
        
           						{ 
        
           							if (MainViewModel.Instance.IsBusy) 
        
           							{ 
        
           								return; 
        
           							} 
        
           							wvm.NavigateAndHighlight(e.Transaction.GetHash()); 
        
           						} 
        
           						NotificationHelpers.Show(wallet, e, OnClick); 
        
           					} 
        
           					if (walletViewModel.IsSelected && (e.NewlyReceivedCoins.Any() || e.NewlyConfirmedReceivedCoins.Any())) 
        
           					{ 
        
           						await Task.Delay(200); 
        
           						wvm.History.SelectTransaction(e.Transaction.GetHash()); 
        
           					} 
        
           				} 
        
           			});

from walletwasabi.

yahiheb commented on June 16, 2024 1

@yahiheb Do you know about any change around it recently?

No I am not aware of any change around that.

I also encountered it once recently. But I was playing with SkipSynchronization flag and I thought it was because of it.
Normally it shouldn't happen.

For me it happened on master without any changes, but I didn't find a way to reproduce it, but it happened twice.

Maybe someone from the @zkSNACKs/code-team knows.

from walletwasabi.

turbolay commented on June 16, 2024

It never happened to me, AFAIR, but it will be possible to happen with TurboSync for wallets that reused an internal key after spend because the wallet will open, and then we will process some transactions.

The only cases I can imagine this to happen are scenarios where your wallet starts synchronizing a long synchronization (lot of blocks to dl, struggle to dl blocks...). Meanwhile, some transactions of the same wallet are being confirmed during the synchronization. So then, the wallet will open, and the new filters received will finally be processed and therefore you will receive notifications.

from walletwasabi.

yahiheb commented on June 16, 2024

It happened again to me, and whenever this happens is when I open a second wallet.

from walletwasabi.

Many transaction notifications when opening a wallet. about walletwasabi HOT 4 OPEN

Comments (4)

Full code

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	Observable
	.FromEventPattern<ProcessedResult>(Services.WalletManager, nameof(Services.WalletManager.WalletRelevantTransactionProcessed))
	.ObserveOn(RxApp.MainThreadScheduler)
	.SubscribeAsync(async arg =>
	{
	var (sender, e) = arg;

	if (Services.UiConfig.PrivacyMode \|\|
	!e.IsNews \|\|
	sender is not Wallet { IsLoggedIn: true, State: WalletState.Started } wallet)
	{
	return;
	}

	if (TryGetWalletViewModel(wallet, out var walletViewModel) && walletViewModel?.WalletViewModel is { } wvm)
	{
	if (!e.IsOwnCoinJoin)
	{
	void OnClick()
	{
	if (MainViewModel.Instance.IsBusy)
	{
	return;
	}

	wvm.NavigateAndHighlight(e.Transaction.GetHash());
	}

	NotificationHelpers.Show(wallet, e, OnClick);
	}

	if (walletViewModel.IsSelected && (e.NewlyReceivedCoins.Any() \|\| e.NewlyConfirmedReceivedCoins.Any()))
	{
	await Task.Delay(200);
	wvm.History.SelectTransaction(e.Transaction.GetHash());
	}
	}
	});