zikaari / aspen-decorations Goto Github PK

Implementation Proposal

const deco1 = new GlobbyDecoration('cssClassname')

console.log(deco1 instanceof Decoration) // > true

deco1.addGlobRule('src/vendor/**/*.css')
deco1.addGlobRule('**node_modules**')

setTimeout(() => {
  deco1.removeGlobRule('**node_modules**')
}, 5000)

Behaviour

• Should automanage everything as described by glob rule
• At the low-level should keep everything efficient by adding/negating a minimum number of targets, and instead rely on inheritance.
• When matching a path against a glob pattern, it should adjust pattern or path according to pathStyle specified by the host.
• Actual targetting and negation should be deferred until absolutely necessary.

Notes

node-ignore is a great glob matcher with no external dependencies. (No interal deps eithers, like fs or path)

The TypeScript compiler is preventing me from calling decorationsManager.getDecorations(itemRendererProps.item) because it's an intersection that includes more than just FileEntry | Directory. Maybe you should expand the definition of getDecorations, if it supports those, or just document the fact that getDecorations doesn't support those (if it doesn't, of course).