Code Monkey home page Code Monkey logo

Comments (9)

ZhengPeiRu21 avatar ZhengPeiRu21 commented on July 3, 2024

Thank you for reporting the issue. I will investigate.

For ItemRewards, they are sent to you in the mail. This is to avoid complex logic checking if the player has enough bag space.

from mod-challenge-modes.

dkapte avatar dkapte commented on July 3, 2024

Thank you and indeed i have noticed that by looking at the source at player->SendItemRetrievalMail. Didn't receive any mail on the character on the set level in the config although the mail time is set to 10 in the worldconfig so it should be instant. Let's hope you got the time to review that as well and if you need any help or testing i'm more than willing to help

from mod-challenge-modes.

ZhengPeiRu21 avatar ZhengPeiRu21 commented on July 3, 2024

It looks like this is due to a core issue. I have opened an AC PR to resolve it.

I am not able to reproduce your issue with items. They are mailing for me correctly. If you are still experience the issue, could you share more details about your configuration and how you are testing?

from mod-challenge-modes.

dkapte avatar dkapte commented on July 3, 2024

Zheng do you have any update on how to solve this? Thanks

from mod-challenge-modes.

dkapte avatar dkapte commented on July 3, 2024

Zheng , I have changed the playerstorage and altered the table characters as you described in the core issue and now the talents are not resetted so that works, thank you. But I have noticed another thing; when you enable challengemode on a character... the settings are not saved on logout.

I can enable the challenge mode and everything now works, from talents to items and titles being given.
But when I logout and login the challenge mode is disabled once again. I noticed you are using getPlayerSettings and updatePlayerSettings but I can't find any reference table in the database containing data for mod-challenge-mode as described in the code. So for now the player needs to activate challengemode every time on the gameobject when they log back in.

Furthermore challengemode can be enabled at any level. Is it possible to set a configure parameter for this to disable entering challenge mode when higher than lvl x (so for example level 1). The XP is also getting overruled by module-weekend-xp and module-individual-xp but when the bool 1 or 0 for challengemode is present in the database I can make a check for that in the XP modules.

Thanks again for the provided solution on extra talents being saved, that works great

from mod-challenge-modes.

jshplayer avatar jshplayer commented on July 3, 2024

Hi there, great module - i notice the challenge modes still drop and don't persist after a relog. Was there a fix or work around to this? Currently players would have to complete a challenge in a single session.

from mod-challenge-modes.

ZhengPeiRu21 avatar ZhengPeiRu21 commented on July 3, 2024

Do you have EnablePlayerSettings set to 1 in your worldserver config? This is required to save player challenges.

from mod-challenge-modes.

jshplayer avatar jshplayer commented on July 3, 2024

Thanks so much for replying Zhen, such simple thing - i didn't realize that toggle existed and was required. Hopefully this helps someone in future.

from mod-challenge-modes.

ZhengPeiRu21 avatar ZhengPeiRu21 commented on July 3, 2024

Thanks so much for replying Zhen, such simple thing - i didn't realize that toggle existed and was required. Hopefully this helps someone in future.

Thank you for noticing that it wasn't documented that this is required, I will add a note to the README. Please let me know if there is any more trouble!

from mod-challenge-modes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.