Comments (3)
void OnGiveXP(Player* player, uint32& amount, Unit* /victim/, uint8 /* xpSource */)
from mod-challenge-modes.
this is the fix:
From:
void OnGiveXP(Player* player, uint32& amount, Unit* / * victim * /) override
To:
void OnGiveXP(Player* player, uint32& amount, Unit* / * victim * /, uint8 / * xpSource * /) override
(delete spaces between / and victim and xpSource above except the space after Unit)*
From:
void OnGiveXP(Player* player, uint32& amount, Unit* victim) override
{
ChallengeMode::OnGiveXP(player, amount, victim);
}
To:
void OnGiveXP(Player* player, uint32& amount, Unit* victim, uint8 xpSource) override
{
ChallengeMode::OnGiveXP(player, amount, victim, xpSource);
}
From:
void OnGiveXP(Player* player, uint32& amount, Unit* victim) override
{
if (!sChallengeModes->challengeEnabledForPlayer(SETTING_QUEST_XP_ONLY, player))
{
return;
}
if (victim)
{
amount = 0;
}
else
{
ChallengeMode::OnGiveXP(player, amount, victim);
}
}
To:
void OnGiveXP(Player* player, uint32& amount, Unit* victim, uint8 xpSource) override
{
if (!sChallengeModes->challengeEnabledForPlayer(SETTING_QUEST_XP_ONLY, player))
{
return;
}
if (victim)
{
amount = 0;
}
else
{
ChallengeMode::OnGiveXP(player, amount, victim, xpSource);
}
}
Pastebin link to the fixed ChallengeModes.cpp file
from mod-challenge-modes.
Thank you for the reports. This should be fixed in ffbb266.
from mod-challenge-modes.
Related Issues (20)
- Disable mode once level limit is reached HOT 5
- Invisible game object HOT 2
- Mods are weakened after character login HOT 1
- (Feature Request) Challenge Mode Only
- BUG HOT 6
- QuestOnlyExp Affects Hunter's Pets HOT 1
- problem disconnecting HOT 1
- Hardcore Disconnects after death (when trying to resurrect) HOT 1
- Disconnection after death HOT 7
- [Request] Ideas for New Challenge Modes HOT 1
- ChallengeModes.cpp concern HOT 1
- DEATH_KNIGHT ChallengeModes not visible HOT 1
- Soulstones not working. HOT 1
- Question
- Is it possible to show the challenge mode under the name HOT 1
- Battlegrounds give massive XP on all challenge modes.
- [Feature Request] Sulfuras & Self-Crafted HOT 1
- [Feature Request] Fishing for Self-Crafted
- Exploit to Cheat Challenge Modes (Lvl 1 Bypass for Self-Crafted)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mod-challenge-modes.