Code Monkey home page Code Monkey logo

Comments (3)

ddk2001 avatar ddk2001 commented on July 3, 2024

void OnGiveXP(Player* player, uint32& amount, Unit* /victim/, uint8 /* xpSource */)

from mod-challenge-modes.

RazorX2016 avatar RazorX2016 commented on July 3, 2024

this is the fix:
From:
void OnGiveXP(Player* player, uint32& amount, Unit* / * victim * /) override
To:
void OnGiveXP(Player* player, uint32& amount, Unit* / * victim * /, uint8 / * xpSource * /) override

(delete spaces between / and victim and xpSource above except the space after Unit)*

From:
void OnGiveXP(Player* player, uint32& amount, Unit* victim) override
{
ChallengeMode::OnGiveXP(player, amount, victim);
}
To:
void OnGiveXP(Player* player, uint32& amount, Unit* victim, uint8 xpSource) override
{
ChallengeMode::OnGiveXP(player, amount, victim, xpSource);
}

From:
void OnGiveXP(Player* player, uint32& amount, Unit* victim) override
{
if (!sChallengeModes->challengeEnabledForPlayer(SETTING_QUEST_XP_ONLY, player))
{
return;
}
if (victim)
{
amount = 0;
}
else
{
ChallengeMode::OnGiveXP(player, amount, victim);
}
}
To:
void OnGiveXP(Player* player, uint32& amount, Unit* victim, uint8 xpSource) override
{
if (!sChallengeModes->challengeEnabledForPlayer(SETTING_QUEST_XP_ONLY, player))
{
return;
}
if (victim)
{
amount = 0;
}
else
{
ChallengeMode::OnGiveXP(player, amount, victim, xpSource);
}
}

Pastebin link to the fixed ChallengeModes.cpp file

from mod-challenge-modes.

ZhengPeiRu21 avatar ZhengPeiRu21 commented on July 3, 2024

Thank you for the reports. This should be fixed in ffbb266.

from mod-challenge-modes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.