zhaque / django-subscription Goto Github PK

I worked on the upgrade to Django 1.10.5 and Python 3.5 but I am stock now. I get the above error and dont understand why the form is generated inside a template tag but I guess thats why its called shortcut? Any chance you can help?

#from django.views.generic.list_detail import object_list
from django.views.generic import TemplateView
from .models import Subscription, UserSubscription

_formclass = getattr(settings, 'SUBSCRIPTION_PAYPAL_FORM', 'paypal.standard.forms.PayPalPaymentsForm')
_formclass_dot = _formclass.rindex('.') 
_formclass_module = __import__(_formclass[:_formclass_dot], {}, {}, [''])

PayPalForm = getattr(_formclass_module, _formclass[_formclass_dot+1:])
get_paypal_extra_args = Signal(providing_args=['user', 'subscription', 'extra_args'])

My WIP repository (django 1.10.5 and python 3.5) is here:

https://github.com/finnerds/django-paypal-subscription

I tried to add an example and make it more understandable for me what actually happens and how it could be used.

When UserSubscription expires, it is not deleted from database.
When user first cancels old UserSubscription and then upgrades or resubscribes, old UserSubscription does not get deleted.

UserSubscription model should get a "cancelled" BooleanField, so it can be reaped after expiration, deleted on upgrade, and properly reactivated ("uncancelled") on resubscription.

PayPal's "trial period" feature should be used to charge less for first billing period on upgrade; the rebate should be equal to part of old subscription plan's billing period that is left unused.

To reproduce:

1. Use postgres_psycopg2 in db engine settings.
2. syncdb, migrate.
3. Go to admin panel.
4. Create a new Subscription with "None" trial unit or recurring unit and save.

The result will be an exception that the value of trial unit has bigger length than the max_length accepted by the DB.

On the other hand, if sqlite3 is used, the result will be an entry with the 'None' string as a value instead of the null.

I did not use mysql yet, so I do not know, if there is some issue for this engine, too.