zfigura / wine Goto Github PK

The game have audio issues with the wineesync=1 but its very playable at 60 fps.

errorlog: AL lib: (EE) ReleaseThreadCtx: Context , 0x7c32c480 current for thread being
destroyed, possible leak!

I've been testing some games with Proton 3.7-5 Beta (all of them with esync enabled), and so far this is the only game I've experienced this audio issue. If esync is enabled, the menu sound effects get really distorted and they kind of play in an infinite loop, but the background music plays just fine. That does not happen when esync is disabled.

I've recorded two short videos of me launching the game with esync on and off (the logs I'm attaching were also generated during the recording of the videos). The debug flags I used: +esync,+server,+pid,+timestamp,+seh,+xaudio2

• Pro Evolution Soccer 2013 (+ESYNC)
  Log file: steam-221430+esync.tar.gz
  Demo video: https://www.youtube.com/watch?v=6jbYjN1WQmo

• Pro Evolution Soccer 2013 (NO ESYNC)
  Log file: steam-221430+noesync.tar.gz
  Demo video: https://www.youtube.com/watch?v=kHeTgmYm75U

Let me know if you need anything else.
Thank you

I build obs for the dependencies, enabled the architecture for 32 bit and installed xserver-xorg-dev:i386. The OS in use is Debian testing with tkg-linux 5.16 Kernel.
I can't get past this error of the script.

./configure
make
.
.
.
5: first defined here
ld: store.o:/home/profile/wine/dlls/crypt32/crypt32_private.h:155: multiple definition of hInstance'; cert.o:/home/profile/wine/dlls/crypt32/crypt32_private.h:155: first defined here ld: str.o:/home/profile/wine/dlls/crypt32/crypt32_private.h:155: multiple definition of hInstance'; cert.o:/home//profile/dlls/crypt32/crypt32_private.h:155: first defined here
winebuild: ld failed with status 1
winegcc: ../../tools/winebuild/winebuild failed
make[1]: *** [Makefile:605: crypt32.dll.so] Error 2
make[1]: Leaving directory '/home/niko100/wine/dlls/crypt32'
make: *** [Makefile:8571: dlls/crypt32] Error 2

May somebody have a suggestions what the halt is about ?

Because it closes one of its thread handles while waiting on it.

To fix this I think we need to somehow keep an extra reference to the server-side object. This is difficult for obvious reasons, so I'm not going to fix this until something really requires it.

This is on Debian sid with gcc/g++ 8.2.0. Looking to use your esync variant for Witcher 3. Anyway, here's the configure details and the last bit of output that shows the error. Using the latest on the esync branch.

./configure --prefix=/opt/wine3-esync --enable-win64

make[1]: Leaving directory '/home/wls/git/wine-witcher-esync/dlls/npptools'
make[1]: Entering directory '/home/wls/git/wine-witcher-esync/dlls/ntdll'
gcc -m64 -c -o esync.o esync.c -I. -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall \
  -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \
  -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits \
  -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 \
  -gstrict-dwarf -g -O2
esync.c:322:17: error: conflicting types for ‘create_esync’
 static NTSTATUS create_esync( enum esync_type type, HANDLE *handle,
                 ^~~~~~~~~~~~
esync.c:111:17: note: previous declaration of ‘create_esync’ was here
 static NTSTATUS create_esync( enum esync_type type, HANDLE *handle,
                 ^~~~~~~~~~~~
esync.c:111:17: warning: ‘create_esync’ used but never defined
make[1]: *** [Makefile:343: esync.o] Error 1
make[1]: Leaving directory '/home/wls/git/wine-witcher-esync/dlls/ntdll'
make: *** [Makefile:9367: dlls/ntdll] Error 2

Works fine without ESync, but never finishes loading on startup if ESync is enabled (the loading spinner just goes on forever).

The game manages to start, and go through the intro videos, but halfway there it hangs and stops responding until killed.

Download link for the logs.

Using the build of wine provided by Steam's Proton bundle.

Not sure if this is related to #7, I'll try to compile a fresh build to see if it fixes anything and report back.

ValveSoftware/Proton#380

This is a regression against 02f7a52 that has been working fine.

The game will hang, seemingly randomly. The sound still plays in the background and no error prompt will show up. I'll add a log if I'm able to reproduce the issue.

@zfigura hi! Thank you very much for you greatest work!
But why you do not merge Esync with Wine Staging or Wine development branch?
Regards

Are there are plans for mainlining these patches upstream in the Wine project itself, or maybe better, the Wine-staging patches with a respective esync toggle? Or will these patches always remain a separate patchset? Thanks :)

Copy and pasting from a wine program into a non-wine program does not work. Though it works the other way around.
With a clean wine prefix I run:

wine notepad

then open a native text editor (e.g., kate) and copy and paste text back and forth between them. Sometimes it takes a few copies before it fails.
This happens with esync enabled and disabled.
Please let me know if any logs would be useful.

Esync currently is a modified fork of the base Wine repo. Are there any plans on making it available specifically as a patchset (or single patch file, depending on how big it actually is) to make it easier to apply to an existing Wine source? (e.g. so it can be easily paired with Staging, PBA, etc).

Or is the idea for this to always be used as a base, to which Staging and other patch sets are then applied to?

This is a regression against 02f7a52 that has been working fine.

Origin currently is broken with esync and will hang then crash, usually silently. You'll find both esync on and off logs in the attached archive :

https://drive.google.com/file/d/1yuAgk97uwzjts-rWWiyoC9IS6xyShAL3/view?usp=sharing

Note : Origin is also broken on current staging 3.13 e1fb783 . It crashes and triggers its own error reporting tool which happens to be functional. Reverting f0d3ae8, 18f4be0 and 12be01 (the last 3 PA patchset related commits) fixes it.

Arch Linux, Wine Staging git (4.0-RC2), using the wine-tkg-git with Esync patches.

/usr/lib/gcc/x86_64-pc-linux-gnu/8.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: x11drv_main.o: in function `set_queue_display_fd':
x11drv_main.c:(.text+0x1bfa): undefined reference to `__wine_esync_set_queue_fd'
collect2: error: ld returned 1 exit status
winegcc: x86_64-pc-linux-gnu-gcc failed
make[1]: *** [Makefile:1269: winex11.drv.so] Error 2

Am using staging, but that is hopefully irrelevant?

in 32-bit mode, off_t is long long. minor issue but worth fixing.

Game starts and gets to the login screen, but after a few seconds it hangs, until the games crash reporter finishes, at which point the game gets closed silently.
No related messages in system logs.

The command run in a clean WINEPREFIX:
WINEDEBUG=+seh,+pid,+esync,+server,+timestamp WINEESYNC=1 wine eso64.exe > winedebug.log 2>&1

The produced log file can be found here: winedebug.log.gz. I closed the game's crash reporter early to help end the log sooner.

Other notable configuration:

• Arch Linux
• Linux-ck patchset
• numfiles 1048576

Please let me know if there is anything else I can do.

This is a regression against 02f7a52 that has been working fine.

Final Fantasy XIV will, most of the time, hang during character loading on the character select screen. The music still plays in the background and no error prompt will show up. Tracing makes the issue very hard to trigger (I've failed so far).

You'll find both esync on (without the crash) and off logs in the attached archive :

https://cdn.discordapp.com/attachments/464945901950205963/473557803190190091/ffxiv.tar.gz

With esync enabled, Crysis seemingly hangs on a black screen. Sometimes, after a while, the first frame of the opening video will show. 30-60 seconds later the second frame may or may not appear, ultimately ending up in what looks like a freeze.

Here's a log : https://drive.google.com/file/d/1vPyCKEb-FwH9otxYMFJWguwj64z9RPPq/view?usp=sharing

Not a regression.

Is this repo maintained? I.e. how can esync be used with current Wine master?

The game "Tree of savior" freezes when you zone to a different map. Also when you exit the game.

Disabling Esync fixes the issue.