Code Monkey home page Code Monkey logo

Comments (4)

zesterer avatar zesterer commented on May 20, 2024

Hello!

This pattern is actually even easier to achieve in chumsky with repeated and foldr. You can see this in the nano_rust example or in the tutorial. The basic pattern is as follows:

let sum = expr
    .then(just('+').ignore_then(expr).repeated())
    .foldl(|(lhs, rhs)| Expr::Add(lhs, rhs));

You can also define it recursively as per your original example, although in practice there's no real need to (iteratively is both faster and won't potentially result in stack overflows):

let sum = recursive(|sum| {
    expr.then(just('+').ignore_then(sum))
        .map(|(lhs, rhs)| Expr::add(lhs, rhs))
        .or(expr)
});

from chumsky.

zesterer avatar zesterer commented on May 20, 2024

Closing this in lieu of a response, tell me if it's not solved and I can reopen it.

from chumsky.

HKalbasi avatar HKalbasi commented on May 20, 2024

Is it possible to not use recursive for LL or LR grammars? It will blow the stack very easily, for example in the Foo example I can get a stack overflow with "(".repeat(500). I wonder if a tail_recursive or something like that is possible or make sense.

And sorry if it is off-topic of this issue.

from chumsky.

zesterer avatar zesterer commented on May 20, 2024

Yes, it is possible to blow the stack by using recursive patterns in this way. On master, there is now a spill-stack feature, enabled by default, that will spill the stack on to the heap if very deep recursion occurs rather than resulting in a stack overflow. I've found that it has almost no impact on performance in practice.

from chumsky.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.