Code Monkey home page Code Monkey logo

Comments (4)

nodir-t avatar nodir-t commented on June 2, 2024

I can live with it though. Now the code looks like this:

fn string<'i>() -> impl Parser<'i, Expression> { ... }
fn boolean<'i>() -> impl Parser<'i, Expression> { ... }

which isn't too bad

from chumsky.

Zij-IT avatar Zij-IT commented on June 2, 2024

The example you’ve posted is definitely how the lifetimes are intended to be used. I can totally understand how switching from .9 to 1.0 was rough though.

There is work being done on a migration guide if I am not mistaken, that should hopefully limit these pains in the future (:

from chumsky.

nodir-t avatar nodir-t commented on June 2, 2024

Yeah, a guide would definitely help. I think I already figured out most of it (I was missing chain, for example), but it took me a day. A guide would reduce that time spend

from chumsky.

zesterer avatar zesterer commented on June 2, 2024

Unfortunately, this is mostly due to limitations in Rust's lifetime solver. Ideally, we'd have retained Parser not having a lifetime and instead do something like this:

trait Parser {
    type Input<'a>;
    type Output<'a>;

    fn parse<'src>(&self, input: Self::Input<'src>) -> ParseResult<Self::Output<'src>>;
}

// And therefore parser functions could look like
// (on second thoughts, this signature is far more horrible to read than 1.0 today)
fn expr_parser() -> impl for<'src> Parser<Input<'src> = &'src str, Output<'src> = Expr<'src>> { ... }

Unfortunately, due to horribleness around variance rules, Rust doesn't currently accept this (and is unlikely to any time in the near future), so we're stuck with binding parsers to the lifetime of the input that they parse. In 1.0.0-alpha.6 we introduced Cache, which allows safely writing parsers independently of a specific lifetime thanks to a GAT trick, although it's admittedly a little more awkward than I'd prefer.

Regarding chain: this functionality is mostly replaced by the ability to take slices of the input (see the to_slice combinator).

from chumsky.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.