zertovitch / zip-ada Goto Github PK

The ZIP specification has added 93 as the method ID of Zstd.

Some programs already supports using Zstd in ZIP, such as WinZip and libzip.

Dear Developers,

Why is on line

a constant introduced that is only used once?

Why is the division not just executed on its usage?

Greetings,
Pierre

Dear developers,

In lzma-decoding.adb I am puzzled by a number of statements like

Why do they contain x + x instead of 2*x?
Is it due to the translation from C(pp), since Ada doesn't have the += increment assignment operator and so x += x + a; is translated to x := x + x + a; ?
Is it due to performance reasons, which would surprise me since normally using both + and * results in faster code?
Or is there even another reason?

Thanks in advance for your clarification!

Pierre

When searching for atypical patterns in Ada code.
I found an instance of the atypical pattern var := cond or else var;
on the following line:

Why do you use this pattern?
There is no side effect in the condition will_fill, so would the typical pattern var := var or else cond; not only result in more typical but also potential faster code?

Thanks in advance for your answer!

Pierre