Code Monkey home page Code Monkey logo

mh-z19-rs's People

Contributors

kolen avatar mexus avatar zenria avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

mh-z19-rs's Issues

u16->bytes conversion is wrong, as is set_detection_range

This library converts a u16 to bytes as follows:

(value & 0xff00 >> 8) as u8,
(value & 0xff) as u8,

However, because of operator precedence, this is actually just (value & 0xff) as u8 twice. Attempting to set detection range to 2000 (0x07D0) instead creates the number 53456 (0xD0D0).

And in set_detection_range this library tries to set the range by writing bytes 3 and 4, but the actual bytes are 6 and 7.

(Supposedly MH-Z19B actually respects bytes 4,5,6,7 as range, in which case trying to set detection range to 0-2000 is actually setting it to 0-3489660928.)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.