zenoxygen / bayespam Goto Github PK

Hi there, awesome create! Trained on some ~18k messages and works really well.

• Docs are outdated: Not a real issue, but yeah
• Usage of the classifier is a bit verbose

extern crate bayespam;
extern crate csv;
extern crate serde;

use bayespam::classifier::Classifier;
use serde::Deserialize;
use std::fs::File;

#[derive(Debug, Deserialize)]
struct Message {
    message: String,
}

fn main() -> Result<(), Box<dyn std::error::Error>> {
    let file_path = "my_super_model.json";

    // Create a new classifier with an empty model
    let mut classifier = Classifier::new(file_path, true);

    ...

    // Serialize the model and save it as JSON into a file
    classifier.save(file_path);

    Ok(())
}

In this example I'm training a new model:

1. I supply a file-path, and indicate this is a new model Classifier::new(file_path, true)
2. Then I supply the same file-path, to save the model classifier.save(file_path)

I didn't look too closely, but wouldn't something like this be enough:

1. Classifier::new(file_path) <- default to new model
2. classifier.save() <- no need to supply path

If I have time, I'll provide a PR.

Consider using Unicode-Segmentation crates split_at_word_bounds function to break up into unicode words in your load_word_list function.

Would it be possible (and a good idea?) to change the required File type to Reader here?

pub fn new_from_pre_trained(file: &mut File) -> Result<Self, io::Error> {

So something like this can be performed:

let faux_model_file = include_str!("./perform_contact_spam_filter_model.json");
 
 let classifier = Classifier::new_from_pre_trained(&mut std::io::Cursor::new(faux_model_file)).expect("Failed to load spam filter model");

Without the need to touch the file system?

It seems like it should take something more like a &str, and then the user is responsible for however that &str gets to the function.