zenika-open-source / terraform-azure-cli Goto Github PK

Need to add Microbadger token as secret

Instead of using arbitrary tag numbers like 2.3, it might be better to implement a real tagging strategy to display toolling version like so:

tf-0.12.9-az-2.0.74

Is it possible to update cli version to 2.0.80
Im looking to use: az apim backup
It haves some issues in earlier versions.
Now they added som arguments, but when i apply them i get this:

**ERROR: az: error: unrecognized arguments: --backup-name a-name --storage-account-name a-storage --storage-account-container backup --storage-account-key *****

I tried it local with 2.0.80 and it is supported in the latest version.

Check CLI tools (version , etc) inside the created image

using https://circleci.com/docs/2.0/artifacts/

options to consider:

• with dependabot : https://github.com/zenika-open-source/terraform-azure-cli/security/code-scanning
• Docker Bench Security: https://github.com/docker/docker-bench-security
• Anchor Engine Github Action : https://github.com/anchore/scan-action
• Clair: https://github.com/quay/clair

cross-link both repository

We have a comprehensive set of modules availables though our GitLab repos and we are referencong them in TF with the syntax source = "git::https://urlofmymodulerepo"
It seems the image does not include the Git package thus breaking this feature.
I think it's important to make it part of the standard image by default (we can of course build a custom image) as Terraform relies on it.

Thanks

Need to setup a CI first (CircleCI ? Travis ? Codeship ?)
run Dockerfile against Hadolint before build

https://github.com/orgs/Zenika/projects/93

Pain in the ass to convert project note to issue (need a repository to create issues in)

Maybe each repository should have it's own project ?

See kefranabg/readme-md-generator or frinyvonnick/gitmoji-changelog for exemples

We could use https://allcontributors.org/

Hello,

trying to get az version thrown me an error:

root@447eecc32209:/workspace# az version
Traceback (most recent call last):
  File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/local/lib/python3.7/dist-packages/azure/cli/__main__.py", line 33, in <module>
    az_cli = get_default_cli()
  File "/usr/local/lib/python3.7/dist-packages/azure/cli/core/__init__.py", line 628, in get_default_cli
    from azure.cli.core.azlogging import AzCliLogging
  File "/usr/local/lib/python3.7/dist-packages/azure/cli/core/azlogging.py", line 30, in <module>
    from azure.cli.core.commands.events import EVENT_INVOKER_PRE_CMD_TBL_TRUNCATE
  File "/usr/local/lib/python3.7/dist-packages/azure/cli/core/commands/__init__.py", line 28, in <module>
    from azure.cli.core.extension import get_extension
  File "/usr/local/lib/python3.7/dist-packages/azure/cli/core/extension/__init__.py", line 14, in <module>
    from distutils.sysconfig import get_python_lib
ModuleNotFoundError: No module named 'distutils.sysconfig'

so to fix it, I did an:

apt-get update -y
apt-get install -y python3-distutils

inside the container.

then I correctly get an az version

root@447eecc32209:/workspace# az version
{
  "azure-cli": "2.5.1",
  "azure-cli-command-modules-nspkg": "2.0.3",
  "azure-cli-core": "2.5.1",
  "azure-cli-nspkg": "3.0.4",
  "azure-cli-telemetry": "1.0.4",
  "extensions": {}
}

Could you please fix the Dockerfile ?

Best regards,

MacFlurry

The dependency management in Alpine with version pinning is hell: older package versions often disappears from the repository.
Maybe we should drop the alpine image, and focus only on the Debian one ?
Image size are quite similar, so there is no big advantage for Alpine here.

Microbadger image analysis and size report seems dead, remove ?

It would allow to test all tools supported versions when releasing, and not only the default one (Dockerfile Args)
The best approach would be to add this feature to container-structure-test itself (PR).

linked to #87

required for #85 and #67

EDIT: after an issue on container-structure-test, it seems that the best option is to use some templating tool to do placeholder replacement.

In order to provide a fallback option if breaking changes or bugs occurs between 2 Azure CLI version, an option could be to support both the latest and n-1 versions in each release.

Using the Github Actions matrix strategy in the release job:

strategy:
      matrix:
        tf_version:
          - "0.11.14"
          - "0.12.28"
          - "0.13.0-beta3"
        azcli_version:
          - "2.7.0"
          - "2.8.0"

https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#fromjson

Instead of using arbitrary tag numbers like 2.3, it might be better to implement a real tagging strategy to display toolling version like so:

r1.2-tf0.12.9-azcli2.0.74

with:

• r= release tag version
• tf = Terraform CLI version
• azcli= Azure CLI version

Might want to wait the CI setup to be tested and stable enought.

https://pip.readthedocs.io/en/stable/reference/pip_install/#hash-checking-mode

Allow watching

• Github Actions updates : https://github.blog/2020-06-25-dependabot-now-updates-your-actions-workflows/
• Docker dependancies

Available Packages ecosystem: https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates#package-ecosystem

Configuration : https://docs.github.com/en/github/administering-a-repository/configuration-options-for-dependency-updates

Instead of saving images as artifacts in workflow, use Github packages (in addition of the Docker Hub): https://docs.github.com/en/actions/publishing-packages-with-github-actions/about-packaging-with-github-actions

I have a concourse build that runs every 4 hours and uses Azure CLI commands. On Friday April 17th at 10am the build ran successfully. However starting at 2pm the image no longer contains Azure CLI.

In my concourse build I display versions of products for informational purposes. When attempting to get the version number and when attempting to use the cli tool I received command not found.

Here are examples from the build:

Command to be run... 'az --version'
/bin/bash: az: command not found

Run az login for service-account...
/bin/bash: az: command not found

I am not sure what has happened, but the website says a change went in 3 days ago. I would like to use the image before this change but all the metadata states nothing has changed in 7 months.

Images tags should contain info on included CLI version.
Use existing build args to setup version at build time in CI.

config + readme badge

Using conditionals, merge lint, build, test and push jobs in one workflow.

Maybe even merge the Release job in the same workflow, and improve the test job so all version combinations are correctly tested (not the case for the moment).

1. Use a cron workflow / webhook to retrieve latest available Azure and Terraform released versions.
2. lint / build / test the new image using new version as args
3. if ok, publish a new tag / release

Resources:

• https://github.com/actions/create-release

Choose one of the following:

• https://semver.org/
• https://calver.org/
• other ?

Using the Azure provided script:

• doc : https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-linux?view=azure-cli-latest#install-or-update
• python script : https://azurecliprod.blob.core.windows.net/install.py

Using apt:

• https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-apt?view=azure-cli-latest#manual-install-instructions

Use advanced auto-build options:
* trigger the readme refresh
* override the build command to do nothing (instead of overriding the image already pushed by github actions)

Using Action : https://github.com/peter-evans/dockerhub-description

• Create a CONTRIBUTING.md: https://docs.github.com/en/github/building-a-strong-community/setting-guidelines-for-repository-contributors
• Enable Github actions on forked repository: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories

for instance : https://github.com/marketplace/actions/markdown-link-check.
Or ad this step in the current CircleCI setup.

The image zenika/terraform-azure-cli:release-5.1_terraform-0.14.0-rc1_azcli-2.15.1 has terraform 0.14.2 installed, instead of 0.14.0.

As seen here, some paramters for the image push are missing.

Must provide --username with --password-stdin

Should the Azure CLI telemetry be turned off, for privacy purpose ?

(update the user .azure/telemetry config)

https://docs.microsoft.com/en-us/cli/azure/authenticate-azure-cli?view=azure-cli-latest#sign-in-with-credentials-on-the-command-line