zeldaret / mm Goto Github PK
View Code? Open in Web Editor NEWDecompilation of The Legend of Zelda: Majora's Mask
Decompilation of The Legend of Zelda: Majora's Mask
The PlayerAgeProperties
name is a holdover from the OoT decomp project because it is used for the two ages in OoT, but it is used for each transformation (and Kafei) in MM.
It would be nice if we could rename it to something that better reflects what it represents in MM. We should also consider if we want to keep the name synced with OoT.
Currently there are two possible options:
PlayerTransformationProperties
PlayerFormProperties
We should fix up the code to remove as many compiler warnings as possible while still keeping OK.
Further, we should implement something like this PR for OOT until we are ready to elevate warnings to errors.
zeldaret/oot#768
a typo on the progress graph site, thought you'd like to know.
format.sh
was run.make
builds a matching ROM (jenkins)code
and boot
segment files are documented. Overlays with documentation are complete.
TitleCase
(DmRavine
)
DmRavine_Init
)camelCase
(actionFunc
)
g
(gSaveContext
)s
(sSphereInit
)SCREAMING_SNAKE_CASE
(DM_RAVINE_STATE_ACTIVE
)EnJcMatoDamageTable
)Whenever we use u32
or s32
to hold a pointer, we should change it to use uintptr_t
or intptr_t
instead.
There has been the never ending discussion of how we should treat the various type of addresses that do not point to vram (ie, can't be derefernced directly).
Currently we use the void*
type for holding vram pointers in struct members, temps, function parameters, etc. And cast them to uintptr_t
when we need to do arithmetic on them.
We may want to have a distinction for the other numerical addresses.
RomOffset
type, which would be the uintptr_t
equivalent for rom addresses, allowing to represent this type, differentiate it from virtual addresses and allow arithmetic on them.what it says on the tin.
We will no longer be using submodules.
We also want to move tools that are used as part of building to a separate folder in the tools folder.
We need a specific directory for tools that are meant to be run manually on the command line.
We also want to ensure that there is a good reason for a tool in the root directory of the project.
Structs to rename
GameState
-> Game
GlobalContext
-> GamePlay
Variable names for Game
will be game
where possible.
Variable names for GamePlay
will be play
where possible.
Actor this
variables will be renamed to self. These are the derived class actor structs.
Actor thisx
variables will be called super or maybe actor. These are the based class actor structs.
Actor constructor/destructor/update/draw methods will be changed to accept the Game
base state rather than the GamePlay
/GlobalContext
derived class.
hi, been a lurker of this project for a while, and i have noticed that "Please don't rebase and force-push: it makes it harder to review since GitHub loses all the comments and it's hard to see what's actually changed." or something along those lines as had to be say more than once(here and on the ocarina), wouldn't it be appropriate then to add this warning on the "Contributing" section of README.md?
Hey I was trying to build this on my Raspberry pi 4 but I ran into a issue
Log:
https://gist.github.com/coreybruce/c3d9916c43bfa0124be599a02a53b9d5
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.