zeevox / ocquarium Goto Github PK

On Mon, 28 May 2018, 10:18 Eliyahu Gluschove-Koppel wrote:

Hello there,
Could you make the alpha icon colour different to the production/beta (like chrome canary) to easily differentiate it

@egkoppel

The PR does not necessarily fix any existing issues, but instead works on improving syntax.

To achieve this, Align-YAML, Beautysh, Uncrustify, and ShellCheck have been used.
The octoStyle.cfg file is used to configure Uncrustify, and is based on ben.cfg.txt.

Dependabot updated dependencies, and ImgBot optimised images.

We could add the ability to set a randomly chosen color or gradient, like uigradients.com

To implement with good UX we'd need a custom preference however.

Add a SwitchPreference (toggle) to SettingsActivity that allows hiding the settings icon so that Ocquarium can look like the original again.

This feature was suggested by Arghadip Das on Google Play.

Sent by Eliyahu Gluschove-Koppel (@egkoppel). Created by fire.

After updating to alpha 56, ocquarium still crashes when opening the octopus size control

Device info

- Ocquarium build version: Alpha build #56
- Device fingerprint: google/taimen/taimen:P/PPP2.180412.013/4763960:user/release-keys

Attachments:

1. 2018_05_30_10_12_37.mp4

The settings icon in the main application should be set to be visible by default, however this is not the case until the user flips the SwitchPreference on and then off again.

If the octopus size is set to over 500 it doesn't fit on the screen and hangs to application usually ending with an ANR message.

Sent by Leonardo Gualandris on 7 Sep 2018 at 09:47. Created by fire.

The app is nearly perfect, but when rotating the device with "show platform logo" enabled, the octopus won't change its size but the platform logo will appear once again.

Device info

- Ocquarium build version: 3.4.2
- Device fingerprint: OnePlus/OnePlus3/OnePlus3:8.0.0/OPR1.170623.032/47:user/release-keys

Sent by @ZeevoX ([email protected]). Created by fire.

On lower DPI devices (primarily tablets), the octopus tentacles seem to be made of particles despite having "particle legs" switched off in settings. Attached are screenshots. 1st screenshot has particle legs disable, second has particle legs enabled for comparison.

Device info

- Ocquarium build version: 3.4.1
- Device fingerprint: Lenovo/LenovoTB-X304L/X304L:7.1.1/NMF26F/TB-X304L_S000045_180126_ROW:user/release-keys

Attachments:

1. Screenshot_20180602-211219.png
   

2. Screenshot_20180602-211241.png
   

Sent by Thanapum Balpo ([email protected]). Created by fire.

OREO

Device info

- Ocquarium build version: 3.4.2
- Device fingerprint: samsung/dream2ltexx/dream2lte:8.0.0/R16NW/G955FXXU3CRGH:user/release-keys

If the user doesn't input anything into the octopus Min/max EditTextPreference the application crashes with a NumberFormatException.

Having changed the color value and pressed OK, the preview stays the same however.

Sent by Thanapum Balpo ([email protected]). Created by fire.

9.0

Device info

- Ocquarium build version: 3.4.2
- Device fingerprint: samsung/dream2ltexx/dream2lte:8.0.0/R16NW/G955FXXU3CRGH:user/release-keys

Build crashes due to outdated Gradle version, see https://travis-ci.org/ZeevoX/Ocquarium/builds/435319734

FAILURE: Build failed with an exception. 

* Where: 
Build file '/home/travis/build/ZeevoX/Ocquarium/app/build.gradle' line: 20 

* What went wrong: 
A problem occurred evaluating project ':app'. 
> Failed to apply plugin [id 'com.android.application'] 
   > Minimum supported Gradle version is 4.10.1. Current version is 4.9. If using the gradle wrapper, try editing the distributionUrl in /home/travis/build/ZeevoX/Ocquarium/gradle/wrapper/gradle-wrapper.properties to gradle-4.10.1-all.zip 

* Try: 
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. 

* Get more help at https://help.gradle.org BUILD FAILED in 19s

Pretty self-explanatory - allow setting Ocquarium as a live wallpaper on the device.

This feature was suggested by Michael Mouton on Google Play.

Here is how the octopus should look (screenshot taken from an Oreo device)

Notice that the octopus has a line for its mouth.

Here is a screenshot from a Marshmallow device

The octopus doesn't have a mouth.

I believe that this is the source of the problem.

This issue has been reported by multiple users on Google Play.

Sent by Thanapum Balpo ([email protected]). Created by fire.

Ocquarium 9.0

Device info

- Ocquarium build version: 3.4.2
- Device fingerprint: samsung/dream2ltexx/dream2lte:8.0.0/R16NW/G955FXXU3CRGH:user/release-keys

Currently, the only way to access preferences and configure Ocquarium is done either through app shortcuts (Android 7.1+) or via the Screensaver (formerly Daydream) options in Settings > Display > Screensaver > Ocquarium > Settings.

Since these settings affect the whole application they should be made easier to access and available on all supported Android version.

Hence, I suggest adding a settings icon in the top left hand corner of the main application to access settings.

This settings cog icon would not exist in the screensaver option since we must try and make the screensaver more of an ambient program that has fewer features.

For the screensaver, options can already be configured as previously mentioned anyway.

Sent by Trajce Playz ([email protected]). Created by fire.

Is it just me, or does the size of the octopus change sometimes? Like, I haven't set to be pretty large (it's usually small), and sometimes it becomes a bit larger. Also, when rotating it just resizes as well.

Device info

- Ocquarium build version: 3.4.4
- Device fingerprint: samsung/j7xeltexx/j7xelte:8.1.0/M1AJQ/J710FXXU5CRK3:user/release-keys

Sent by ZeevoX DEV ([email protected]). Issue created by fire.

Test issue

That is, disable the "Set live wallpaper" Preference once the wallpaper has been set, so we need to check whether it has been set if the user returns to the SettingsActivity.

Something along the lines of onResume() for a fragment.

Now that getClipBounds() is only called once, when the live wallpaper is (re)started, if the clip bounds change the change is not reflected in the live wallpaper.

To fix this, we should call getClipBounds() in onSurfaceChanged too.

https://travis-ci.org/ZeevoX/Ocquarium/builds/441000110#L1572

find: unknown predicate `-1'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (43) A libcurl function was given a bad argument

Could you add more padding to the transparent settings icon (or make the touch target larger) as it is very hard to tap on pixel 2 xl because it is mostly cut off by the rounded corners. - @egkoppel

Device info

• Ocquarium build version: 3.3.0
• Device fingerprint: google/taimen/taimen:P/PPP2.180412.013/4763960:user/release-keys

Show the Oreo icon first, which has to be tapped multiple times and then long pressed in order to actually play with and view the octopus in Ocquarium. Preferably, this should be optional.

This feature was suggested by Arghadip Dap on Google Play.

Sent by @ZeevoX ([email protected]). Created by fire.

It'd be nice if you could drag the octopus in the live wallpaper...

Device info

- Ocquarium build version: 3.4.1
- Device fingerprint: OnePlus/OnePlus3/OnePlus3:8.1.0/OPR1.170623.032/02281230:user/release-keys

Sent by WebDevelopers ([email protected]). Created by fire.

If i press back button force open a ocquarium menu, thanks for read my feedback.

Device info

- Ocquarium build version: 3.4.3
- Device fingerprint: ADVAN/S4Z/ADVAN_S4Z:6.0/MRA58K/8:user/release-keys

Sent by @ZeevoX ([email protected]). Created by fire.

The octopus appears to be shooting from one side of the screen to the other all the time. This only started happening in the latest alpha.

Device info

- Ocquarium build version: Alpha build #41
- Device fingerprint: OnePlus/OnePlus3/OnePlus3:8.0.0/OPR1.170623.032/02281230:user/release-keys

Attachments:

1. ScreenRecord-2018-05-29-00-02-12-2.gif
   

Sent by sopha zidany ([email protected]). Created by fire.

[email protected]

Device info

• Ocquarium build version: 3.4.3
• Device fingerprint: HUAWEI/CLT-L29/HWCLT:8.1.0/HUAWEICLT-L29/154(C185):user/release-keys

مُرسل من هاتف Huawei الخاص بي

Support Android™ Oreo 8.1's WallpaperColors feature to appropriately set a light or dark system theme.

Permit devices with a navigation bar to hide it and make Ocquarium truly full screen.

Greetings, fire here!

@ZeevoX recently invited @fire-bot to this repository. Before fire is enabled, @ZeevoX needs to complete a few steps:

Complete fire setup now

Only @ZeevoX will be able to enable fire using the above link. If someone added fire by mistake, feel free to remove @fire-bot from your repo's collaborators.

Sent by ZeevoX DEV (@ZeevoX). Created by fire.

Whenever I open settings the octopus size is always set to roughly 20% on the seek bar no matter how large the octopus drawable is.

Device info

- Ocquarium build version: Alpha build #49
- Device fingerprint: OnePlus/OnePlus3/OnePlus3:8.0.0/OPR1.170623.032/02281230:user/release-keys

Attachments:

1. Screenshot_Ocquarium_alpha_20180529-171611.png
   

Add a Preference to the SettingsActivity that will reset the background colors to default.

This feature was suggested by Syed Omar Ali on Google Play.

Hide / disable / grey out the "Set as live wallpaper" option in settings if Ocquarium has already been set as the user's live wallpaper.

Sent by @ZeevoX ([email protected]). Created by fire.

Android Pie now supports displays with cutouts, however, Ocquarium doesn't wrap around the notch, instead leaving a large black status bar.

The same applies for displays longer than 16:9.

Device info

- Ocquarium build version: 3.4.2
- Device fingerprint: OnePlus/OnePlus3/OnePlus3:8.0.0/OPR1.170623.032/02281230:user/release-keys

Attachments:

1. Screenshot_20180908-135616.png
   

The "Settings" app shortcut (available on Android 7.1+) does not work on Travis or debug builds due to a package name mismatch.

Device info

• Ocquarium build version: Alpha build #26
• Device fingerprint: OnePlus/OnePlus3/OnePlus3:8.0.0/OPR1.170623.032/02281230:user/release-keys

A README.md file with a link to Google Play and some screenshots would be nice.

On Mon, 28 May 2018, 10:15 Eliyahu Gluschove-Koppel wrote:

In alpha 36, after the eyes close to blink, the eyes stay closed and do not open again
egkoppel

Device info

• Ocquarium build version: Alpha build #36
• Device fingerprint: google/taimen/taimen:P/PPP2.180412.013/4763960:user/release-keys

Sent by ANJI IS LOVE ([email protected]). Created by fire.

Please

Device info

- Ocquarium build version: 3.4.3
- Device fingerprint: motorola/potter_n/potter_n:7.0/NPNS25.137-92-14/16:user/release-keys

Sent by Thanapum Balpo ([email protected]). Created by fire.

Ocquarium 8.0+

Device info

- Ocquarium build version: 3.4.2
- Device fingerprint: samsung/dream2ltexx/dream2lte:8.0.0/R16NW/G955FXXU3CRGH:user/release-keys

Sent by ArghadipDasCEO ™ ([email protected]). Created by fire.

ActionBar actionBar = getSupportActionBar();
if (actionBar != null) {  
    actionBar.setDisplayHomeAsUpEnabled(true);
}

You might did this in the Settings activity, but you forget to call this

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    switch (item.getItemId()) {
        case android.R.id.home:
            finish();
    }
}  

And because of that the left top back arrow not working...

Your friend Arghadip

Device info

- Ocquarium build version: 3.4.1
- Device fingerprint: motorola/sanders_n/sanders_n:7.1.1/NPSS26.116-61-8/15:user/release-keys

Sent by Thanapum Balpo ([email protected]). Created by fire.

8.0+

Device info

- Ocquarium build version: 3.4.2
- Device fingerprint: samsung/dream2ltexx/dream2lte:8.0.0/R16NW/G955FXXU3CRGH:user/release-keys

Sent by Bowman, Max ([email protected]). Created by fire.

Feedback

Device info

- Ocquarium build version: 3.4.1
- Device fingerprint: motorola/potter_n/potter_n:7.0/NPNS25.137-93-10/12:user/release-keys

St Paul's School is a charitable company limited by guarantee registered in England.

Registered office at Lonsdale Road, London SW13 9JT.

Registered Company Number 6141973. Registered Charity Number 1119619.

Important Email Notice
This e-mail and/or any attached documents are solely for the individual(s) to whom they are addressed. If you have received this e-mail in error, you must not use, disclose, copy, distribute or retain this message or any part of it. Please notify the sender immediately and delete this correspondence from your system. The statements and opinions expressed in this message are those of the author and do not necessarily reflect those of the School.

Whilst this e-mail has been scanned for viruses, St Paul's School deems it the responsibility of the recipient to scan the message and attachments for viruses, worms or other unwelcome content prior to opening them.

To conserve resources please do not print this e-mail unless it is absolutely necessary.

------------------------------------------------------------------------------------------------------------------------------
Scanned by Trustwave SEG - comprehensive email content security solution.
------------------------------------------------------------------------------------------------------------------------------

See screenshot attached. Ripple is larger on top than below of the Share option in the About page of the settings menu

Device info

• Ocquarium build version: Alpha build #30
• Device fingerprint: OnePlus/OnePlus3/OnePlus3:8.0.0/OPR1.170623.032/02281230:user/release-keys

That is, if the colours are already at their defaults, we can disable the "set to default" button

I have been receiving many error stacktraces on Google Play with NumberFormatException's due to the fact that people are entering invalid input into the Octopus size preferences in settings.

The main issues in this case are:

1. People enter a decimal value.
2. People enter a string instead of an int (one instead of 1)
3. People enter a larger minimum value than maximum and vice-versa.

The input should be limited to purely whole integers.

This would probably require changing the EditTextPreference into a custom SeekBarPreference.

When in settings, accessing a sub-menu such as "Octopus" or "Background" doesn't have a button to navigate back up in the toolbar.

Device info

• Ocquarium build version: Alpha build #19
• Device fingerprint: OnePlus/OnePlus3/OnePlus3:8.0.0/OPR6.170623.013/10250816:user/release-keys

Allow enabling/disabling touch functionality for the screensaver.