zdenham / diamond-etherscan Goto Github PK

When I try to add function selectors by calling diamondCut() function on louper.dev, I have input this tuple data as the first argument
(0x2cb01a89b7c474b0fd0b7958dcda5077ab50227b0,1,[0x5c60da1b,0xc39aa07d])
But I have faced this error (seems svelte.js input filed validation error)

Hey, I know this was just a small project for you but I was really interested in trying to get it implemented and maybe do some improvements. But I'm hitting a wall trying to test it out. I can create the dummy implementation. Attach the etherscan facet. All that, even in your example project. But when I actually go on etherscan and try to attach the proxy I get this issue

The proxy contract verification completed with the below message:

This contract does not look like it contains any delegatecall opcode sequence.

The Diamond I deployed is here.

Louper for the Diamond is here

The DummyDiamondImplement is here.

It's when I go to the Diamond etherscan page and try to connect the proxy as 0x962956885a86825Ee65F01dF7ceFc413436750ac that I get that error. Do you see anything that I'm doing obviously wrong here? Or is it possible Etherscan updated how they handle proxies in the past few months?

Hello,
Shouldn't the DiamondEtherscanFacet.sol facet implement the implementation() function in order to implement EIP 1967? Right now it implements the dummyImplementation() function.