zdavatz / amiko-ios Goto Github PK

1. Open App
2. Rotate iPhoneX to the left
3. Rotate iPhoneX back to the right (portrait mode).
4. Searchbar is now displaced.

maybe related:

• https://stackoverflow.com/questions/46318022/uisearchbar-increases-navigation-bar-height-in-ios-11/46945190
• https://stackoverflow.com/questions/28552967/uisearchcontroller-not-redisplaying-navigation-bar-on-rotate/28698405
• https://stackoverflow.com/questions/45350035/ios-11-searchbar-in-navigationbar
• https://stackoverflow.com/questions/46364224/uisearchbarcontroller-ios-11-issue-searchbar-and-scope-buttons-overlap
• http://ioscake.com/using-uisearchcontroller-with-uisearchbar-in-tableheaderview-in-ios11.html
• https://stackoverflow.com/questions/28326269/uisearchbar-presented-by-uisearchcontroller-in-table-header-view-animates-too-fa

If you start the App, there is a black right bottom corner. What is that black?
https://files.slack.com/files-tmb/T27F6280H-F9WURQQ4R-c90e20ed34/_1024.png

The error is the following:

2018-04-05 21:43:24.192642+0200 generika[29669:1525985] -[__NSCFNumber isEqualToString:]: unrecognized selector sent to instance 0xb0000000000005a3
2018-04-05 21:43:24.197255+0200 generika[29669:1525985] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[__NSCFNumber isEqualToString:]: unrecognized selector sent to instance 0xb0000000000005a3'
*** First throw call stack:
(
	0   CoreFoundation                      0x0000000107b2c1e6 __exceptionPreprocess + 294
	1   libobjc.A.dylib                     0x00000001071c1031 objc_exception_throw + 48
	2   CoreFoundation                      0x0000000107bad784 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132
	3   CoreFoundation                      0x0000000107aae898 ___forwarding___ + 1432
	4   CoreFoundation                      0x0000000107aae278 _CF_forwarding_prep_0 + 120
	5   generika                            0x0000000103065c83 -[ReceiptViewController entriesCountForViewOfField:] + 1555
	6   generika                            0x000000010306410d -[ReceiptViewController layoutFrames] + 1597
	7   generika                            0x0000000103064e3c -[ReceiptViewController viewWillAppear:] + 140
	8   UIKit                               0x0000000104bafdc0 -[UIViewController _setViewAppearState:isAnimating:] + 442
	9   UIKit                               0x0000000104bb062f -[UIViewController __viewWillAppear:] + 131
	10  UIKit                               0x0000000104bf17f3 -[UINavigationController _startTransition:fromViewController:toViewController:] + 817
	11  UIKit                               0x0000000104bf267e -[UINavigationController _startDeferredTransitionIfNeeded:] + 870
	12  UIKit                               0x0000000104bf38cc -[UINavigationController __viewWillLayoutSubviews] + 150
	13  UIKit                               0x0000000104e4bbd7 -[UILayoutContainerView layoutSubviews] + 231
	14  UIKit                               0x0000000104ad5808 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1515
	15  QuartzCore                          0x00000001045cc61a -[CALayer layoutSublayers] + 177
	16  QuartzCore                          0x00000001045d082b _ZN2CA5Layer16layout_if_neededEPNS_11TransactionE + 395
	17  QuartzCore                          0x000000010455729f _ZN2CA7Context18commit_transactionEPNS_11TransactionE + 343
	18  QuartzCore                          0x0000000104584940 _ZN2CA11Transaction6commitEv + 568
	19  QuartzCore                          0x00000001045856be _ZN2CA11Transaction17observer_callbackEP19__CFRunLoopObservermPv + 76
	20  CoreFoundation                      0x0000000107ace607 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23
	21  CoreFoundation                      0x0000000107ace55e __CFRunLoopDoObservers + 430
	22  CoreFoundation                      0x0000000107ab2b81 __CFRunLoopRun + 1537
	23  CoreFoundation                      0x0000000107ab230b CFRunLoopRunSpecific + 635
	24  GraphicsServices                    0x000000010aac0a73 GSEventRunModal + 62
	25  UIKit                               0x0000000104a060b7 UIApplicationMain + 159
	26  generika                            0x000000010306a97f main + 111
	27  libdyld.dylib                       0x00000001080e9955 start + 1
	28  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb) 

I just sent two Emails with attachments to test importing the attachments out of the real Mail App on your iPhone to a...@i..com. Something is still really wrong there. Please test the import of all prescriptions on your real device. Steps to reproduce:

1. Set doctor address on real device, with selfie. Click save.
2. Now start importing prescriptions from Mail app from the Mails I just sent (Test Emese and Test Yuka)
3. The user is not taken to the correct prescription when importing the prescriptions

Get inspired by Generika App for iOS.

At the moment it is all set in the .xib file via Info View.Leading and Info View.Trailing.

I guess we need to set this programmatically.

My Tab Bar Bottom does not reload correctly after rotation. Have a look at the items at the end of the movie.

https://ywesee.slack.com/files/U27FC8WLA/FA0G4PAR4/icons_need_to_be_reloaded_as_well.mov

This seems to be a similar issue like #37

Clicking on Send should save or overwrite the open prescription if it has not yet been saved and then should open the ActionSheet Sharing Options. So clicking on Send will not give you any options to Save as New or overwrite existing. It will do that automatically for you if you have not done it manually before.

Be it an entry field (patient or doctor) or a view, the ZIP is always before the City in Switzerland.

1. Select patient A with 3 prescriptions
2. Open an existing prescription of patient A
3. Add a package
4. Click save as new prescription
5. Delete all 4 prescriptions
6. Create a new prescription with 2 packages for the same patient A.
7. Click Save as new prescription
8. App crashes with below message

2018-03-20 11:54:30.919787+0100 AmiKoDesitin[4142:1627088] Replaced right VC
2018-03-20 11:54:50.496053+0100 AmiKoDesitin[4142:1627088] lastUsedPrescription: RZ_2018-03-20T115428.amk, amkFiles[rowIndex] RZ_2018-03-20T114029.amk
2018-03-20 11:54:53.272085+0100 AmiKoDesitin[4142:1627088] lastUsedPrescription: RZ_2018-03-20T115428.amk, amkFiles[rowIndex] RZ_2018-03-20T115428.amk
2018-03-20 11:55:00.285040+0100 AmiKoDesitin[4142:1627088] long press began on table view at row 8
2018-03-20 11:55:00.292335+0100 AmiKoDesitin[4142:1627088] MLMedication id:2845, regnrs:54268, 55431, 43225 <Orfiril®/- long>
2018-03-20 11:55:04.821240+0100 AmiKoDesitin[4142:1627088] signatureImg {333, 312}
2018-03-20 11:55:04.862946+0100 AmiKoDesitin[4142:1627088] uncaught exception: *** -[__NSDictionaryM setObject:forKey:]: object cannot be nil (key: patient_id)
2018-03-20 11:55:04.863040+0100 AmiKoDesitin[4142:1627088] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSDictionaryM setObject:forKey:]: object cannot be nil (key: patient_id)'
*** First throw call stack:
(0x182f63164 0x1821ac528 0x182efbc9c 0x182e30b0c 0x102e96d74 0x102eb21e0 0x18ca26b28 0x18ca27520 0x18c866698 0x18c86a394 0x18c62e87c 0x18c556188 0x18c555afc 0x18c555808 0x18c5558a8 0x186fb6dc4 0x102fd128c 0x102fd5ea0 0x182f0b344 0x182f08f20 0x182e28c58 0x184cd4f84 0x18c5815c4 0x102e9b75c 0x18294856c)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb) 

https://files.slack.com/files-tmb/T27F6280H-F9WKH69NE-a0b239f130/_1024.png

Generika.cc App uses a UIPickerView to set the expiry date. We could do the same to pick a package from the Preparation-Search. The UIPickerView should also have a title:
https://stackoverflow.com/questions/18999115/add-header-to-uipickerview

1. Open App
2. Import Prescription 1 for Patient A.
3. Import new, different prescription 2 for Patient A.
4. Import new, different prescription 3 for Patient A.
5. Create a new prescription for patient A on the Phone by selecting one package. Click Save as New.
6. Try to reimport prescription 1. App should say that Prescription was already imported and take the User to that prescription that was already imported.

Set the name, surname and date of birth of the Patient in the subject line followed by the Doctor Name and Surname.

Subject: Rezept: "Name Surname", "Date of Brith" von "Title" "Name Doctor" "Surname Doctor"

Body: Only contains the AMK File, nothing else.

https://files.slack.com/files-tmb/T27F6280H-F9W23RP0X-9a0d25b415/_1024.png

Whenever there is am "Hamburger" the view should be swipeable.

Hamburges need to be linked always with the same view. We discussed this once.

seems to be related #40

so if you click New the buttons Interactions, Save and Send should be disabled.

1. Download App
2. Got to prescriptions
3. Add patient
4. Add package
5. Save and Send Buttons are not yet enabled as long as the doctor address is not filled and saved in the AmiKo App
6. Interaction Button has to work if their is more then one package in the prescription

1. Open App
2. Goto Prescription view.
3. Click new.
4. Select a patient
5. Add some packages.
6. Click save as new.
7. Swipe right.
8. Add more packages.
9. Click Save new again. This should create another AMK file. Now comes the first problem:
10. The List of AMK files only reloads if you click the "Hamburger". You can test this with a completely new patient.
11. Signature is lost on all AMK files that where save as "New".

See: https://files.slack.com/files-tmb/T27F6280H-F9RJ8D317-ddb9c66459/_1024.png

1. Import AMK File into AmiKo for macOS.
2. Patient Data is "Null" and is not being imported.

1. Open Prescription
2. Click New
3. Select patient
4. Add package
5. Click Save New
6. Add another package
7. Now you should get the options Save as New or Overwrite existing. At the moment I only get one option Save as New again.

Empty new lines in prescription are not yet correctly saved.

1. Create a prescription with patient, doctor and package in iOS simulator.
2. Add the following text to the package:

asdfasdfasdf
asdfasdf asdfasdf

asdfasdfasfd
asdfasdfasdf

3. The text after the new line will be lost after you import the file into AmiKo for macOS.

1. Create a new patient via navigating over the Pill, select Taylor David from the Simulator Address Book. Save him.
2. Add a package to the prescription.
3. Click save.
4. Click Hamburger.
5. No AMK files in the list.
6. Click Hamburger again then click it again.
7. Now the AMK file appears in the list.

Whenever there is am "Hamburger" the view should be swipeable.

1. Open App in Simulator
2. Access iPad address book
3. Select a person not yet in AmiKo address book like John Appleseed
4. Set the Sex
5. "Save Button" is not visible. You first have to click into another mandatory field, to access that button.

Open AMK file from Messages App

1. Attach file via "Senden" Button
2. Send AMK File to Mobile number.
3. Recipient should be able to open the AMK File with Generika or AmiKo App. Probably iOS has to have a filehandler for AMK files set.

At the moment the layout is not recalculated in the app when changing orientation, unless it's done by the system.

As mentioned by @bettar on 30.3. in the AmiKo-Slack channel:

I have a feeling, that when you rotate the device the TextView is not reloaded, and still thinks it has to stick to the PT mode, but in fact it is in LS mode.

1. Open App
2. Goto prescription, swipe right.
3. Select a package.
4. Click save.
5. App crashes.

This has to be set for all files:

If the doctor address is missing please create a link:
"Please add doctor's address." (EN)
"Bitte Arztadresse hinzufügen." (DE)
"Rajoutez l’adresse du médecin svp." (FR)

If you tap the link, it opens the address view to edit the doctor's address.
https://files.slack.com/files-tmb/T27F6280H-F9VUKPWL8-e48d9423d1/_1024.png

1. Open patient
2. Select prescription from AMK list
3. Click patient
4. Select new patient
5. Now the User should only have one option: Save as new. There is no use for an option Overwrite prescription, because this is a new prescription for that patient.
6. Overwrite prescription basically only happens for editing an existing prescription for the same patient. If you swap the patient there is only one option: Save as new.

https://files.slack.com/files-tmb/T27F6280H-F9S55SC91-8a21091ed0/_1024.png

1. Import AMK File (#9 has to work).
2. Swipe right.
3. Search a brand like Ponstan. Add a package with selector.
4. Swipe left to show full prescription.
5. Save -> Save as new prescriptionü
6. The doctor signature does not change. The imported doctors signature is still there.
7. Selfie is also not shown.

This needs to be checkt for the other languages as well.

1. Open App
2. Click prescription
3. Choose a patient
4. Swipe to the right
5. Add a pacakge (Ponstan)
6. Add another package (Inderal)
7. Swipe in the Prescription
8. Click save as New
9. Select another prescription from another a patient
10. Add a package
11. Click `Overwrite Prescription"
12. Swipe Left to show amk Files. Select the file you overwrote.
13. Result: added packages are lost and not show. Prescription was not overwritten.

At the moment I can not set any separate constraints for the WebView for MLSecondViewController~iphone.xib for the iPhoneX in LS mode. There should be a leading and trailing 62 for the iPhoneX in LS mode for the WebView. In PT mode there shouldn't be any leading or trailing constraints for the WebView.

I seems the Hash of the prescription is changed, every time you click the the send Button.

Like this the Generika App imports the same prescription again and again.

1. Create prescription in AmiKo iOS
2. Click send
3. Open in Generika App
4. Repeat with the same prescription
5. Same prescription can be imported again

This is "wrong"

This is correct or better.

https://files.slack.com/files-tmb/T27F6280H-F9Y69QSG2-a57bf32885/image_uploaded_from_ios_1024.png

Make menu point to correct entry when using iPad to select package.

Suggestion: Use UITextField

1. Longtap on Package should give two options
   a) edit Comment b) delete c) Cancel
   a) will open the keyboard so the user can type or dictate with Siri what he wants to say about that package.
   b) will delete that line with the package and the comments.
2. Text should automatically be saved or like with the Messages App text can be saved by clicking on a small Icon.

Edit a prescription in AmiKo iOS with comments. They will not show in the Generika App. This works for the macOS App.

1. Open existing patient in prescription view
2. Click New
3. Select a patient
4. Add a package
5. Click save as new
6. Crash with below message

2018-03-20 11:40:50.163643+0100 AmiKoDesitin[4133:1620990] Replaced right VC
2018-03-20 11:40:56.793248+0100 AmiKoDesitin[4133:1620990] signatureImg {333, 312}
2018-03-20 11:40:59.706078+0100 AmiKoDesitin[4133:1620990] long press began on table view at row 0
2018-03-20 11:40:59.713204+0100 AmiKoDesitin[4133:1620990] MLMedication id:2437, regnrs:56923 <Minerva®>
2018-03-20 11:41:04.994895+0100 AmiKoDesitin[4133:1620990] signatureImg {333, 312}
2018-03-20 11:41:05.034570+0100 AmiKoDesitin[4133:1620990] uncaught exception: *** -[__NSDictionaryM setObject:forKey:]: object cannot be nil (key: patient_id)
2018-03-20 11:41:05.034616+0100 AmiKoDesitin[4133:1620990] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSDictionaryM setObject:forKey:]: object cannot be nil (key: patient_id)'
*** First throw call stack:
(0x182f63164 0x1821ac528 0x182efbc9c 0x182e30b0c 0x102bb6d74 0x102bd21e0 0x18ca26b28 0x18ca27520 0x18c866698 0x18c86a394 0x18c62e87c 0x18c556188 0x18c555afc 0x18c555808 0x18c5558a8 0x186fb6dc4 0x102f1928c 0x102f1dea0 0x182f0b344 0x182f08f20 0x182e28c58 0x184cd4f84 0x18c5815c4 0x102bbb75c 0x18294856c)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb) 

To reproduce, see:
Landscape
https://ywesee.slack.com/files/U27FC8WLA/F9ZQ3TZPZ/screenrecording_03-30-2018_10-11-29.mp4
Portrait
https://ywesee.slack.com/files/U27FC8WLA/F9YRWDW4D/screenrecording_03-30-2018_10-20-13.mp4