zapico / klimatneutral Goto Github PK

Is it tied to the current sliders to the right? Is there a formula to compute the values based on their input?

Do the two donut charts at the top right monitor the same dataset? They are the same at the beginning, but only one of them is updated when the sliders are changed. I'm assuming that they should both be updated, but in that case, why do we have two identical ones?

I didn't get exactly the rule to update the icicle chart from the "elbilar" slider. Right now it's written as

dataKlimatutslapp.children[0].children[0] = dataKlimatutslapp.children[0].children[0] / antalElBilar

but dataKlimatutslapp.children[0].children[0] is an object, so I'm assuming you mean its "value" property. Even then, I didn't get the meaning of the division by the number from the slider..?

There are right now three functions for making donut charts, which share a lot of code. They could have a super class to minimize duplication (or a common prototype if we don't want to have object-orientation).

Then, in order to deal with the specific behavior/looks of each, we might either use some extra parameters, or pass in an object that looks like config but only contains the actual differences from the base one (instead of being fully defined).

There are many code refactorings that we can do like:

• Making classes for each view / dataset,
• Separating them in different files,
• Exporting modules,
  but I think we can do that slowly after things are working.

The reason why the Icicle sometimes gets buggy is because the "saved" attribute of the model becomes negative.

Right now I'm just considering that all data is in the global scope, so it's accessible by everyone. It might be interesting, for example, to make the data itself hidden away and only be accessible through some specific methods that change it, in order to maintain the integrity.