When upgrade enabled for a user like this:

# upgrade oh-my-zsh for a single user
ohmyzsh::upgrade { 'user1': }

It should then be disabled in the user .zshrc file:
Currently it's set like so:

# DISABLE_AUTO_UPDATE="true"

Should be:

DISABLE_AUTO_UPDATE="false"

Otherwise it prompts the user frequently to check for updates even though puppet is managing the updates.

Currently none of the params are exposed so you can't override them with an ENC like foreman. I propose to extend this module to allow $home to be overridden, you can do this by exposing the $home as a class parameter in the manifests/params.pp.

Something like this should suffice for now:

manifests/init.pp

# View README.md for full documentation.
#
# === Authors
#
# Leon Brocard <[email protected]>
# Zan Loy <[email protected]>
#
# === Copyright
#
# Copyright 2014
#
class ohmyzsh (
  $home = $::ohmyzsh::params::homedir
) inherits ::ohmyzsh::params {}

manifests/params.pp

# Parameters class for ohmyzsh
class ohmyzsh::params (
  $homedir = '/home'
) {
  case $::osfamily {
    'Redhat': {
      $zsh = '/bin/zsh'
    }
    default: {
      $zsh = '/usr/bin/zsh'
    }
  }

  $home = $homedir

}

I will submit a PR for this if you like (although I am still fairly new to puppet), I also was thinking about creating a wrapper for this module so you can use an ENC via hiera/yaml to define something like the following:

users:
  root:
    set_sh: true
    disable_auto_update: true
    homedir: /root
    theme: 'robyrussell'  
  mike:
    set_sh: true
    disable_auto_update: true
    homedir: /mnt/home/mike
    theme: 'robyrussell'
    plugins:
      - git
      - github

due to changes in https://github.com/robbyrussell/oh-my-zsh/blob/master/templates/zshrc.zsh-template#L62 generated .zshrc file cannot be sourced properly.
Now it looks like:

plugins=(foo bar)
    git
)

and it should looks like

plugins=(foo bar)

For performance reasons (and other reasons) would be best not to check for upgrades for each user on every puppet run. Therefore one can use the schedule metaparameter to only check for updates once a day. I do this with the Exec override though currently I have to specify the username like so:

    ohmyzsh::upgrade { 'user1': }
    Exec <| title == 'ohmyzsh::git upgrade user1' |> {
      schedule => 'everyday',
    }

Would be nice if could specify the schedule in the ohmyzsh::upgrade class like so:

    ohmyzsh::upgrade { 'user1': }
    frequency => 'everyday',