zacps / alacritty Goto Github PK

System

Windows 10 with Intel HD Graphics P630

Description

The buffer seems stretched when using Intel HD Graphics. The origin for this stretch seems to be centered around 0.5, 0.5 - leading characters to fall outside the terminal window and the text to be blurry:

I've messed about with DPI settings and that seems to have no effect (my DPI is 100% in any case).

Workaround

The issue disappears if I allocate my NVIDIA (presumably AMD would work too) chip to Alacritty:

Which operating system does the issue occur on?
Windows 10 - WSL

I tried the last compiled build from AppVeyor, but the colors don't seem to be displayed correctly. This is what it looks like:

This is what it looks like on wsltty:

As a side question. I am starting bash by simply typing 'bash' in de cmd prompt that starts. Would this be the proper way?

Which operating system does the issue occur on?

Windows 10 client talking to a Ubuntu 16.04 host via the v7.6.0.0.p1-beta release of Windows SSH client (https://github.com/PowerShell/Win32-OpenSSH/releases/tag/v7.6.0.0p1-Beta)

Resizing the window seems to be ignored in the reported terminal size. This is especially noticable after a maximize operation.

Steps to reproduce:

1. ssh user@linuxbox
2. run the resize command which should report the current screen size
3. resize the window
4. run resize again. The reported values are the same as before

Another thing that I noticed is that closing the SSH connection, resizing the window and then starting a new SSH connection seems to cause the values reported by resize to be correct.

The documentation is already pretty well explained in winpty/src/include/winpty.h should just be a matter of copying it across and getting rid of c-isms.

From jwilm/alacritty#28.

Now however I am getting a different error when I try to run alactritty.exe.

Welcome to Alacritty.                                                                                                                                            
Configuration loaded from C:\Users\gavin\alacritty.yml                                                                                                           
device_pixel_ratio: 1                                                                                                                                            
width: 1024, height: 768                                                                                                                                         
thread 'main' panicked at 'gl function was not loaded', E:\Development\alacritty\target\release\build\alacritty-aabf91f3f7e36563\out/gl_bindings.rs:20617:13     
stack backtrace:                                                                                                                                                 
   0: std::panicking::default_hook::{{closure}}                                                                                                                  
             at C:\projects\rust\src\libstd\panicking.rs:386                                                                                                     
   1: std::panicking::rust_panic_with_hook                                                                                                                       
             at C:\projects\rust\src\libstd\panicking.rs:563                                                                                                     
   2: std::panicking::begin_panic<str*>                                                                                                                          
             at C:\projects\rust\src\libstd\panicking.rs:538                                                                                                     
   3: alacritty::gl::missing_fn_panic                                                                                                                            
             at .\build\alacritty-aabf91f3f7e36563\out\gl_bindings.rs:20617                                                                                      
   4: alacritty::main                                                                                                                                            
             at E:\Development\alacritty\src\main.rs:45                                                                                                          
   5: std::rt::lang_start::{{closure}}<()>                                                                                                                       
             at C:\projects\rust\src\libstd\rt.rs:74                                                                                                             
   6: main                                                                                                                                                       
   7: __scrt_common_main_seh                                                                                                                                     
             at f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283                                                                                       
   8: BaseThreadInitThunk    ```                                                                                                                                 

Which operating system does the issue occur on?

Windows 10 client connecting to a Linux 16.04 machine via ssh

Steps to reproduce:

1. Make sure that dialog is installed
2. Execute dialog --yesno Testing 10 30
3. Attempt to use the mouse to click on either the Yes or No button. Nothing happens

Expected bahavior:

Clicking on either of the buttons should cause the dialog process to exit

Steps to reproduce:

1. Maximize window
2. Un-maximize the window
   Expected result: Font size does not change
   Actual result: Font renders weirdly until any window message is received (Including events like lost focus)

Currently alacritty's build.rs fetches winpty-agent.exe from the nuget package. This is currently one release behind the github releases.

We should change the build script to fetch, and extract from, github instead.

To reproduce:

• Run git diff when there are modifications

Example output:

I haven't implemented any of the OS-specific tests so far. Just add cases to cover what the current OS-specific tests are on other operating systems if they're applicable.

Currently we use the xdg crate on unix systems and implement our own logic on windows.

Moving to directories-rs (or an alternative) would let us remove the platform specific code and let the lib worry about it.

Prior discussion.

Which operating system does the issue occur on?

Win 10.1803

Build provided by dparnell here: alacritty#28 (comment)

Run alacritty with any of cmd, bash, powershell.
Run exit.
Expected behaviour: alacritty closes.
Actual behaviour: alacritty stays open.

Information about the API is located here: https://blogs.msdn.microsoft.com/commandline/2018/08/02/windows-command-line-introducing-the-windows-pseudo-console-conpty/

• Add bindings for the new API. Ideally we'd add support for this to winpty-rs, but I'm not sure how they deal with insider APIs.
• Figure out whether we can use the insider SDK on Appveyor. It may have to be feature-gated if we can't.
• Add an implementation of the EventedReadWrite (src/tty/mod.rs) trait for the ConPTY API.
• Add config option for PTY backend on Windows and runtime switching based on Windows version.

A few things that need doing here.
First the current appveyor stuff is copy-pasted from rust-everywhere as I don't really have any experience with appveyor.
Second the build currently fails because of our dependencies but works fine on my local machine (Fix it!).
Finally add a badge to show off the passing build status :).

If there are any appveyor settings that should/need to be changed I'm happy to make them upon request.

Unfortunately cargo build is not quite enough to setup all dependencies.
Winpty requires msbuild and fontconfig-sys requires a library from somewhere (See servo-fontconfig-sys repo).
Bindgen also relies on llvm being installed.

Running alacritty --working-directory 'C:\' does not start alacritty in the C drive root.

See src/window.rs#456466. Calling this method hangs for some reason.

In your comment linking this repo you mention there's a lot of work that still needs to be done. Do you have a vague list of what things still need to be changed?

Also it seems that your fork still fails for me on building servo-fontconfig. Did you switch to a different create locally or are using something different for rendering?

Window title is blank for some reason.
The title should be set in src/window.rs#186.
Also set the executable icon to the one from jwilm/alacritty#285 possibly using winres.

On first run alacritty attempts to write an initial config file if it does not exist.
Currently, this fails.

Which operating system does the issue occur on?
Win10

I use winpty for other command line tools and winpty-agent.exe is already in the path environment variable. Would be good to load it from there if it doesn't find it with alacritty.exe

Current main issue.