Code Monkey home page Code Monkey logo

roenglishre's People

Contributors

daegaladh avatar jezztify avatar lemongrass3110 avatar llchrisll avatar locien avatar megaminobisho avatar zackdreaver avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

roenglishre's Issues

ItemInfo.lua

Zack tolong cek pada item nomor 13081

disana masih berbahasa korea, dikarang saja daripada begitu.

oiya untuk editor teks pakai apa ya? saya pakai notepad++ selalu bahasanya jadi UTF dikembalikan ke ANSI hasilnya berbeda tidak seperti notepad biasa bisa ASCII

kamu editor teks lua pakai apa?

makasih zack

Which one is correct?

Which of these two descriptions is correct according to the kRO? because here in git is one way, but in another repo is otherwise ...

Does it need updating here or is it correct?

	[SKID.RL_HEAT_BARREL] = {
		"Heat Barrel (Acceleration Bullet)",
		"Max Level: 5",
		"^CC3399Requirement: Rich's Coin 1^000000",
		"Skill Form: ^339900Buff^000000",
		"Description: ^777777Consumes all coins to",
		"increase ASPD and ATK, reduces fixed cast",
		"time at the cost of HIT. Skill's level",
		"affect ASPD, ATK and fixed cast time bonus",
		"and HIT reducement. If the caster",
		"switches equipment during the duration,",
		"the skill's effect will dissapear. This skill",
		"can't be used with Madness Canceller or",
		"Platinum Alter. Skill duration is 60 sec.^000000",
		"[Lv 1]: ^777777ASPD +1, HIT -30^000000",
		"[Lv 2]: ^777777ASPD +2, HIT -35^000000",
		"[Lv 3]: ^777777ASPD +3, HIT -40^000000",
		"[Lv 4]: ^777777ASPD +4, HIT -45^000000",
		"[Lv 5]: ^777777ASPD +5, HIT -50^000000"
	},
	
	[SKID.RL_HEAT_BARREL] = {
		"Heat Barrel (Acceleration Bullet)",
		"Max Level: 5",
		"^CC3399Requirement: Fire Dance 2^000000",
		"Skill Form: ^339900Buff^000000",
		"Description: ^777777Consumes all coins to increase",
		"ASPD and ATK at the cost of FLEE. Higher",
		"skill level increases ASPD and ATK bonus",
		"and FLEE reducement. After the duration,",
		"caster will not be able to attack or use",
		"skills and items for 10 seconds. This skill",
		"cannot be used with Madness Canceller or",
		"Platinum Alter. If the caster switches",
		"equipment during the duration, the skill",
		"will end and give 10 second penalty.^000000",
		"[Lv 1]: ^777777FLEE -70, Lasts for 60 sec.^000000",
		"[Lv 2]: ^777777FLEE -65, Lasts for 60 sec.^000000",
		"[Lv 3]: ^777777FLEE -60, Lasts for 60 sec.^000000",
		"[Lv 4]: ^777777FLEE -55, Lasts for 55 sec.^000000",
		"[Lv 5]: ^777777FLEE -50, Lasts for 50 sec.^000000"
	},

itemID: 20515 - Position

I have a problem and at the same time a doubt about this item, it uses hateffect to be displayed in the character, however after updating with the files here of the repository the item appears in the incorrect position in the character, I tried to correct the position but it does not work, he is not below the character.

Does this have any connection to the client version? Use 2017-05-31.

IMG: https://i.imgur.com/cka7bTY.png

suport for new clients

to run with new clients
needs some changes
i noticed on 2017-11-01bRagexeRE was it has 8th argument on itemInfo.lua
the costume line (true or false)
I tested on an iteminfo with just one item
but the change has to be done on all items
Do you know any easy way to do it?
intends to work with new clients ?

[607] = {
unidentifiedDisplayName = "Yggdrasil Berry",
unidentifiedResourceName = "이그드라실열매",
unidentifiedDescriptionName = { "" },
identifiedDisplayName = "Yggdrasil Berry",
identifiedResourceName = "이그드라실열매",
identifiedDescriptionName = {
"Fruit from the Yggdrasil tree which brings life to our world. Its fantastic taste is full of life.",
"^FFFFFF_^000000",
"Class:^0000FF Restorative item^000000",
"Heal:^006600 100%^000000 HP, ^006600100%^000000 SP",
"Weight:^006600 30^000000"
},
slotCount = 0,
ClassNum = 0,
costume = false
},

and smal change on function

main = function()
for ItemID, DESC in pairs(tbl) do
result, msg = AddItem(ItemID, DESC.unidentifiedDisplayName, DESC.unidentifiedResourceName, DESC.identifiedDisplayName, DESC.identifiedResourceName, DESC.slotCount, DESC.ClassNum, DESC.costume)
if not result == true then
return false, msg
end
for k, v in pairs(DESC.unidentifiedDescriptionName) do
result, msg = AddItemUnidentifiedDesc(ItemID, v)
if not result == true then
return false, msg
end
end
for k, v in pairs(DESC.identifiedDescriptionName) do
result, msg = AddItemIdentifiedDesc(ItemID, v)
if not result == true then
return false, msg
end
end
k = DESC.costume
k = DESC.unidentifiedResourceName
v = DESC.identifiedDisplayName
end
return true, "good"
end

I tested on an iteminfo with just one item

Wrong quest2display info

62617#Bounty Board Thara Frog#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Thara Frog monsters and return to the Bounty Board at El Dicastes# it suppose at Comodo

62618#Bounty Board Sea Otter#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Sea Otter monsters and return to the Bounty Board at El Dicastes# it suppose at Comodo

62619#Bounty Board Seal#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Seal monsters and return to the Bounty Board at El Dicastes# it suppose at Comodo

62620#Bounty Board Raggler#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Raggler monsters and return to the Bounty Board at El Dicastes# it suppose at Comodo

62621#Bounty Board Grove#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Grove monsters and return to the Bounty Board at El Dicastes# it suppose at Comodo

62622#Bounty Board Alligator#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Alligator monsters and return to the Bounty Board at El Dicastes# it suppose at Comodo

62623#Bounty Board Golem#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Golem monsters and return to the Bounty Board at El Dicastes# it suppose at Comodo

62624#Bounty Board Stalactic Golem#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Stalactic Golem monsters and return to the Bounty Board at El Dicastes# it suppose at Comodo

62625#Bounty Board Medusa#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Medusa monsters and return to the Bounty Board at El Dicastes# it suppose at Comodo

62644#Bounty Board Willow#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Willow monsters and return to the Bounty Board at El Dicastes# it suppose at Payon

62645#Bounty Board Wolf#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Wolf monsters and return to the Bounty Board at El Dicastes# it suppose at Payon

62646#Bounty Board Munak#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Munak monsters and return to the Bounty Board at El Dicastes# it suppose at Payon

62647#Bounty Board Bongun#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Bongun monsters and return to the Bounty Board at El Dicastes# it suppose at Payon

62648#Bounty Board Sohee#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Sohee monsters and return to the Bounty Board at El Dicastes# it suppose at Payon

62649#Bounty Board Dokebi#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Dokebi monsters and return to the Bounty Board at El Dicastes# it suppose at Payon

62650#Bounty Board Nine Tail#SG_FEEL#QUE_NOIMAGE#
Hunt 150 Nine Tail monsters and return to the Bounty Board at El Dicastes# it suppose at Payon

Overbrand skill description issue

btw our Overbrand skill description is not upto date and we still used old description:
kRO default description now are:
[SKID.LG_OVERBRAND] = {
"¿À¹ö ºê·£µå",
"MAX Lv : 5",
"^777777½ÀµæÁ¶°Ç : ¹® ½½·¡¼Å 3 / ÇÉ Æ÷ÀÎÆ® ¾îÅà 1 ^000000",
"°è¿­ : ^777777 ¾×Ƽºê / µ¥¹ÌÁö ^000000",
"³»¿ë : ^777777 â Àü¿ë ½ºÅ³. ÇÇÀÇ ½ÊÀÚ°¡¸¦ ±×¸®¸ç ¿¬¼ÓÀ¸·Î °Å¸® 6 ¼¿±îÁöÀÇ Â±â¿Í Á¿ì 6 ¼¿±îÁöÀÇ Èֵθ£±â °ø°ÝÀ» ÇÑ´Ù. Èֵθ£±â µ¥¹ÌÁö¸¦ ÀÔÀº ´ë»óÀº ³Ë ¹é µÇ¸ç, ³Ë ¹é Áß º® µî¿¡ ºÎ‹HÈ÷¸é Ãß°¡ µ¥¹ÌÁö¸¦ ÀԴ´Ù. Â±â °ø°ÝÀº ½ÃÀüÀÚÀÇ BaseLV ¹× ½ºÇǾî ÄûÅ« ·¹º§¿¡, Èֵθ£±â °ø°ÝÀº ½ÃÀüÀÚÀÇ BaseLV , STR ¹× DEX ¿¡ ¿µÇâÀ» ¹Þ¾Æ µ¥¹ÌÁö°¡ »ó½ÂÇÑ´Ù. ^000000",
"[Level 1] : ^777777 Â±â °ø°Ý·Â 200% / Èֵθ£±â °ø°Ý·Â 100% ^000000",
"[Level 2] : ^777777 Â±â °ø°Ý·Â 400% / Èֵθ£±â °ø°Ý·Â 200% ^000000",
"[Level 3] : ^777777 Â±â °ø°Ý·Â 600% / Èֵθ£±â °ø°Ý·Â 300% ^000000",
"[Level 4] : ^777777 Â±â °ø°Ý·Â 800% / Èֵθ£±â °ø°Ý·Â 400% ^000000",
"[Level 5] : ^777777 Â±â °ø°Ý·Â 1000% / Èֵθ£±â °ø°Ý·Â 500% ^000000"
},

missing some english translation for msgstringtable

tested on 2016-12-28 client..

below is the screenshot

screen1asiaro000
screen1asiaro001
screen1asiaro002
screen1asiaro003

i would believe these 4 above should be displaying "Message"

screen1asiaro004

and this should be "More"

screen1asiaro005

but, for this achievement, i can't figure out the english translation.

ID 12265 error

Before I update today i got no error now i got error like this:

Resource loading fail

this is the item info v5 before and after the update:

BEFORE:

[12265] = {
unidentifiedDisplayName = "Life Insurrance",
unidentifiedResourceName = "생명보험증서",
unidentifiedDescriptionName = { "" },
identifiedDisplayName = "Life Insurrance",
identifiedResourceName = "생명보험증서",
identifiedDescriptionName = {
"A life insurance certificate issued by Kafra Headquarter.",
"^FFFFFF_^000000",
"Usable:^6666CC Supportive^000000",
"Effect:^006600 Disable EXP loss penalty when character dies^000000",
"Duration:^006600 30^000000 minutes",
"Weight:^006600 1^000000"
},
slotCount = 0,
ClassNum = 0,
costume = false
},

AFTER:

[12265] = {
unidentifiedDisplayName = "Life Insurrance",
unidentifiedResourceName = "생명Life Insurrance Certificate",
unidentifiedDescriptionName = { "" },
identifiedDisplayName = "Life Insurrance",
identifiedResourceName = "생명Life Insurrance Certificate",
identifiedDescriptionName = {
"A life insurance certificate issued by Kafra Headquarter.",
"^FFFFFF_^000000",
"^0000CCType:^000000 Supportive",
"^0000CCEffect:^000000 Disable EXP loss penalty when character dies",
"^0000CCDuration:^000000 30 minutes",
"^0000CCWeight:^000000 1"
},
slotCount = 0,
ClassNum = 0,
costume = false
},

[Development] Removing official LUA files from this project

To avoid copyright issue in the future,
one by one files in this repository will be replaced and/or deleted.

The second goal is to remove LUA files that not related to translation,
User will be forced to find the lua files that needed by client on their own.

You're welcome to post your opinion here.

need update for item 22072 Hiking Boots

Dear Zack, i'm need update for item description 22072
here what i've got from Indonesia official server

[22072] = {
unidentifiedDisplayName = "Boots",
unidentifiedResourceName = "ºÎÃ÷",
unidentifiedDescriptionName = {
},
identifiedDisplayName = "Hikingboots",
identifiedResourceName = "µî»êÈ­",
identifiedDescriptionName = {
MaxHP +4%, MaxSP +4%
every +3 refine upgrade,
MaxHP +3%, MaxSP +3%
if refine into +10,
increase movement when wear this item
Type : ^777777Shoes^000000 Def : ^77777710^0007955000
Weight : ^77777750^000000
Lv Minimum : ^777777100^000000
Job : ^777777All Jobs^000000
},
slotCount = 0,
ClassNum = 0

i think this is already similiar to item_db renewal effect rathena

22072,Hikingboots,Hikingboots,4,0,,500,,10,,1,0xFFFFFFFF,63,2,64,1,100,1,,{ .@r = getrefine(); bonus bMaxHPRate,4+(.@r/3); bonus bMaxSPRate,4+(.@r/3); if (.@r > 9) bonus bSpeedRate,25; },{},{}

`

Medal Of valor acc

Hi, can u help me update into iteminfo.lua please. here my update from idro.
and this description already fix with rathena item_db.txt
image
Thanks

[2895] = {
unidentifiedDisplayName = "Accessory",
unidentifiedResourceName = "½Å±âÇѸ޴Þ",
unidentifiedDescriptionName = {
},
identifiedDisplayName = "Medal Of Valor1",
identifiedResourceName = "½Å±âÇѸ޴Þ",
identifiedDescriptionName = {
"^ff0000Can not be traded with other players.^000000",
"A special accessories which there are magic.",
"It could enhance the ability of the wearer.",
"Reduces the casting time by 2%.",
"If you use one set complete it will give bonus HP + 500 , SP + 300 , Def +10 +10 + ATK.",
"Type : ^777777Accessories^000000 Tk Def : ^7777774^000000",
"Weight : ^7777770^000000",
"Lvl Requirements : ^7777771^000000",
"Profesi : ^777777All Jobs^000000",
},
slotCount = 0,
ClassNum = 0
},
[2896] = {
unidentifiedDisplayName = "Accessory",
unidentifiedResourceName = "½Å±âÇѸ޴Þ",
unidentifiedDescriptionName = {
},
identifiedDisplayName = "Medal Of Valor2",
identifiedResourceName = "½Å±âÇѸ޴Þ",
identifiedDescriptionName = {
"^ff0000Can not be traded with other players.^000000",
"A special accessories which there are magic.",
"It could enhance the ability of the wearer.",
"Increases ASPD by 3 %.",
"If you use one set complete it will give bonus HP + 500 , SP + 300 , Def +10 +10 + ATK.",
"Type : ^777777Accessories^000000 Tk Def : ^7777774^000000",
"Weight : ^7777770^000000",
"Lvl Requirements : ^7777771^000000",
"Profesi : ^777777All Jobs^000000",
},
slotCount = 0,
ClassNum = 0
},

missing summoner expanded skills in skill tree window

based on this PR & update branch on rathena repo

rathena/rathena#1965
https://github.com/rathena/rathena/tree/update/summoner_expanded

those following are the missing for summoner expanded skills in skill tree window
skill ID 5044 SU_SOULATTACK##
skill ID 5045 SU_POWEROFFLOCK## -
skill ID 5046 SU_SVG_SPIRIT## -
skill ID 5047 SU_HISS## -
skill ID 5048 SU_NYANGGRASS## -
skill ID 5049 SU_GROOMING## -
skill ID 5050 SU_PURRING##
skill ID 5051 SU_SHRIMPARTY## -
skill ID 5052 SU_SPIRITOFLIFE##
skill ID 5053 SU_MEOWMEOW## -
skill ID 5054 SU_SPIRITOFLAND## -
skill ID 5055 SU_CHATTERING## -
skill ID 5056 SU_SPIRITOFSEA##

Khalitzburg Knight Card description causes error

With the current (original) version that is published here, newer clients force close/crash upon right-clicking this card in-game. Without the plus-sign the description can be opened without issues.

Original:
"+[^008800White Knight Card^000000]",

Proposed fix:
"[^008800White Knight Card^000000]",

resource errors from Hell Fly (Mob-ID#1872)

Client version: 2015-11-04a (fully updated as of 2018-01-07)
ROenglishRE version: 631eb6f

I'm getting the following resource errors whenever a Mob-ID#1872 ("Hell Fly") appears:

Spr :: Cannot find File : sprite????\hell_fly.spr
Cannot find File : sprite????\hell_fly.act

I also managed to fix it myself by changing its sprite from HELL_FLY to HUNTER_FLY. However, I'm not sure if that's the correct solution.

The following line was changed:

[jobtbl.JT_BEELZEBUB_FLY] = "HELL_FLY",

request

can you add new sura bodystyle please? :) thanks in advance!

Missing Files?

Some buttons here make Lua's error such as "SET Default settings"

2017-06-14bRagexeRE

New Line - Optimization

My recommendation is to replace all new lines with the following.
I've been using this since the earliest days for my custom items, it works perfectly fine.

Current Usage:
"^FFFFFF_^000000",

Optimized:
" ",

This reduces the sign count by times 15.
It also allows people to use different UI background colors without being able to see the white line.

I understand that the white line might be the official way.
But it's nonsense.

The only possible issues that can come out of it is that the color code which was used before the new line was different than ^000000.

But i haven't seen a single item using that yet.

Quest Windows Client Crash

Hi, well everything works fine but, in Quest Window (Alt + U) special in mora Daily Hunting Quest when select your quest Client Crash. Using 2015-11-04aRagexe in rAthena.

15095 - Heroic Judgement Shawl

Heroic Judgement Shawl translation is based on the iRO description, which is wrong.
The 2 effects mentioned below were either false translated by iRO or kRO fixed it in the meantime.
Should be as follows:

Korean Official:
마법 공격시, 일정 확률로 렉스 에테르나 1스킬을 발동한다.
물리 공격시, 일정 확률로 기리에 엘레이손 10스킬을 발동한다.

Translation:
When attacked by magic, you have a chance to activate Lex Aeterna Level 1.
When physically attacking, activate Kyrie Eleison Level 10 at a certain probability.

In your words :
"Randomly autocasts Level 1 ^0000FFLex Aeterna^000000 when wearer attacked by magical attack.",
"Randomly autocasts Level 10 ^0000FFKyrie Eleison^000000 when dealing physical attack.",

Official Information:
https://www.divine-pride.net/database/item/15095
Please note:
The Korean version is correct.
The iRO version is wrong.

System/Iteminfo.lua

When trying to add new lines such as a custom item you are met with a series of bad lines such as "'n��?U���?y�???, (taken from line 133985) and will not allow you to log into the game.

Bug Fixes for skilldescript.lub

I'm not really into git, so i created a patch file instead which includes some very very old bug fixes.
There are also some smaller typo fixes included.

Applies to:
\DEV\SkillDescUpdate\2nd+3rdClasses\skilldescript.lub

skilldescript_fixes.txt

Missing ^000000

You didn't include all fixes from my last report.

Following skills miss a ^000000 at the end of their description which renders all following colors wrong:

SKID.LG_PINPOINTATTACK
SKID.LG_OVERBRAND
SKID.LG_MOONSLASHER

Example:
image

Affected files:
Skill Description Lua

SNS Button

I think the name of the Twitter icon is wrong, as soon as it shows an error in the call:

Rename and disappeared.

error in achievement_list.lub

Quoted from @Tokeiburu

There's an error with your achievement file, look up the achievement IDs 220009~220013.

resource = { [1] = { text = "Spend 10,000 zeny on vending merchant", count = 10000 }, count = 500000000 },
should be

resource = { [1] = { text = "Spend 10,000 zeny on vending merchant", count = 10000 } },

Item #6457

On current iteminfo.lua (in this repo), item 6457 is Safe to 10 Certificate
But on http://ro.gnjoy.com/guide/runemidgarts/itemview.asp?itemSeq=7&ID=6457 is +5 ticket for Armor
Google Translate:

5 armor smelting guaranteed rights
Armor 5 images smelting guaranteed rights
It can through the Frontera smelting researchers also strengthen the smelting of armor to step 5. Limited -1 times -
Weight: 0

Unable to Edit itemInfo.lua

Hi,
I am wondering for this itemInfo.lua, if this .lua is fresh from it source, it will be ok.
But when i try to put custom item, there are missing lot of coma ( , ) after ( " ) in item description.

[Development] Custom textures to replace official textures

To avoid copyright issue in the future,
one by one files in this repository will be replaced and/or deleted.

The first goal is to replace all textures in this project with custom made one by fans.
If you willing to contribute or just giving point of view, you're welcome to post it here,
otherwise, please don't post unnecessary things.

[20285] Costume Blowing Scattered Sakura

The view ID of this item is 1331, and this is supposed to be animation headgear like Moonstar, Superstar,
The problem is, in status window and char selection, this item will displaying [19023] Queen Scaraba Crown, view ID 1231, maybe there's something wrong with sprite? Because 1231 and 1331 is quite similar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.