zabaow / brewformer Goto Github PK

the catch method found attached to fetch method for the retrieval of information from the brewerydb api, returns errors found in the module that parses the information.

TypeError: Cannot read property 'length' of undefined
    at getBreweries (search.js:19)
    at fetch.then.then.contents (search.js:10)
    at <anonymous>

This error occurs after pressing the search button when either there is nothing in one/both of the text input fields, or when there is a type in one/both of the text input fields. The goal is to correctly interpret what is causing the error and convey the error to the user in an easy to understand fashion.

when i send a request to brewerydb's api, i am returned an error caused by the request response where the request includes ":" where the website would want "," to be. While researching the issue, i found that i am sending the request as a JSONP and brewerydb is only compatible with JSON format. The only way I've found so far to get around this problem is via php, which i have now knowledge of how to use.

BreweryDB has gone under a major update. They have created new features and updated older ones. One of the more notable ones being a new free sandbox server for developers to use to play with the API. However, they have also changed their unlimited use server's payment plans. The price for use was $6/month. They have changed that to two different plans $20/month (non-commercial) and $250/month (commercial). I tested brewformer to see if everything was still up and running. So far everything still checks out, but with any online service updates, there is a high potential for code deprecation.

beers listed under their respective breweries should be anchor elements that include a link to a review site for that respective beer or a google search.

when the application generates the tooltips for the beers on the list, the descriptions inputted into the tooltip will halt if a comma exists in the string. need to find out how to avoid this.

Finding that if too many requests are sent to brewrydb in too short amount of time, an error appears telling the user that they have made too many requests. This issue has been posted on the brewerydb google groups forum and is currently awaiting an answer.

Thinkful release issues:

• create nav bar for help, search, and about pages.
• create an about and a help page for the user.
• filter beers so that they display under respective brewery.
• find a way to display beer data prior to user click.
  description of beer in a tooltip that displays while hovering beer
• figure out where the site should send the user if a beer is clicked.
  should it be a specific site or just a google search?
• provide clarity for the user with hover effects (materialize.js).
  want both the brewery container to have shadow effect.
want beer items to have font color changing effects.
• make sure the footer has the proper elements.
  read through brewerydb, materialize.js for api request requirements.
• make sure site is aria compatible.

After Thinkful release issues:

• integrate app icon into site.
• improve styling choices for the site.

I believe that i have hit the limit of request that i can make to the BATTUTA! api. This means that im back to square one. I believe that i'll have to resort to a text form instead. However, this would allow me to use the materialize autofill feature now.

I am utilizing both jquery ver 3.2.1 and materialize. I have been receiving errors that say that the variable "Velocity" is not defined. This should not occur since jquery should already contain the velocity variable. I have already tried installing a separate file of velocity.js, however the newly installed file called one of its errors saying that multiple instances of velocity had been loaded. This led me to conclude that jquery is loading the velocity variable. So the question is, why materialize is not receiving the velocity variable? Either i didn't correctly load jquery or materialize, or something else.

When ever there is a change in value within the drop-down menus an error appears stating that callback() is not a function. This error originates from materialize.js, however, it does not affect the overall functionality of the state/city selector.

When brewformer loads up, an error concerning jQuery appears:

Uncaught ReferenceError: $ is not defined

It is believed that this may be due to the timing of the script in the html that initializes tooltips. This is supported by the fact that the application and tooltips still function still function as intended. This means that the issue is isolated to the HTML responsible for initializing tooltips and the solution would be about where to place this specific snippet of code:

    $(document).ready(function(){
        $('[data-toggle="tooltip"]').tooltip();
    });

As it stands, the drop down menu for cities is way to long for anyone to want to manually scroll through to find their desired city. I want to have a way for the user to simply type the name of the city and have the menu snap to that city, thus keeping thing simple for the user.

Brewformer could use aria attributes in order to make sure that it meets accessibility guidelines and so that valid and valuable information is provided to screenreaders.