z80z80z80 / autocrop Goto Github PK

If a photo is really in diagonal, this function fails:

 ---------------------------------
|                          *tr
|
|       * tl
|
|                                *br
|
|             *bl
|

I propose the following code:

def order_rect(points):
    # initialize result -> rectangle coordinates (4 corners, 2 coordinates (x,y))
    res = np.zeros((4, 2), dtype=np.float32)

    left_to_right = points[points[:, 0].argsort()] # Sorted by x

    left_points = left_to_right[:2,:]
    left_points = left_points[left_points[:, 1].argsort()] # Sorted by y
    right_points = left_to_right[2:,:]
    right_points = right_points[right_points[:, 1].argsort()] # Sorted by y

    res[0] = left_points[0]
    res[1] = right_points[0]
    res[2] = right_points[1]
    res[3] = left_points[1]

    return res

Hey,
Thanks a lot for your this code!

I noted that one bracket is not being closed on line 114 currently:

should be
print("WARNING: This seems to be an edge case. If the result isn't satisfying try lowering the threshold using -t")

Cheers.

These are questions before I start experimenting with this autocropping tool. It was not clear in the description on these items.

Does this work with RAW (Canon CR2) input files? Can the tool produce JPG and preferably TIFF output files on the cropped images?

How fast (cropped files per minute)?

Thanks for your help and time.

I am getting error in this line.
for f in files[0]:

IndexError: list index out of range

Hi,
I just stumbled uppon your very cool script:) Would it also be possible to cut black borders?
Which variables would have to be changed for this? I looked at the code but my python is to basic to fully understand it. I assume it would be somewhere in the cont function?
I am digitizing old dias for my mother and they look as follows:

Thank your for your work done with this script, and I would be very happy to hear from you :)

My scanner produces images like the attached example. The algorithm does not terminate with the attached file.

Hi
I am trying to run the script, but it gives me an error:

python autocrop.py

File "autocrop.py", line 87
print(f"Adjust Threshold: {user_thresh}")
^
SyntaxError: invalid syntax

What could be the problem?

Found your script useful for a similar issue I'm running into for photo scans. It works well for me, but the file size increases significantly. E.g. uncropped, my images are 300-500kB but cropped they are about 1.5-2.5MB. Any idea why this is happening?