Comments (6)
Thank you for your contribution and kind words :)
from redux-object.
Hey @JakeDluhy,
it is supposed to normalize data first before saving in store. Have a look at https://github.com/yury-dymov/json-api-normalizer
from redux-object.
Right, I'm using the json-api-normalizer
. I misrepresented what my store looks like. I suppose it's more like
{
users: {
'1': {
id: '1',
attributes: {},
relationships: {
books: {
data: {
[{
id: '1',
type: 'books'
}, {
id: '2',
type: 'books'
}]
}
}
}
}
},
books: {}
}
My point is that if I've just made a request like GET /users/1
, not GET /users/1?include=books
then I won't have any books loaded into the store. Which means that when I do user.books
it's going to return [null, null]
(because it's trying to find the related resource and is unable to do so). I think that if it can't find the related resource, it should fall back to providing the relationship object, i.e.
console.log(user.books);
// output
[{
id: '1',
type: 'books'
}, {
id: '2',
type: 'books'
}]
from redux-object.
Here's the diff of my changes: JakeDluhy@aa76ec0, to help you understand what I'm talking about
from redux-object.
oh, now I see. Yeah, feel free to submit PR, I am happy to merge it
from redux-object.
Thanks! Btw, I'm loving this library (and json-api-normalizer
). It's really cleaning up our implementation of JSON API!
from redux-object.
Related Issues (20)
- Suggestion: Remove Lodash dependencies from the production build HOT 2
- Suggestion: Include unminified + minified bundles in dist
- Suggestion: Optionally include 'type' attribute in results HOT 2
- Should not return empty array for relationships without data HOT 1
- support for resource object 'meta' tag HOT 1
- Change properties to be enumerable HOT 2
- 'meta' properties on relationships HOT 2
- Is it possible to convert an Object back to plain JSON? HOT 2
- Ability to do reflection on what is a relationship and what's not HOT 4
- Preserve type information for each object HOT 3
- Creating new objects across subsequent (identical) calls HOT 5
- {fetchFromMeta} missing? HOT 1
- It's not possible for resources and relationships to live under different reducers HOT 1
- Cyclical state HOT 1
- How do I make a change? HOT 4
- Selecting data when fetching from relationship JSONAPI endpoint HOT 2
- [Feat. Request] "resolved" optional? HOT 2
- redux-object/dist/bundle.min.js consists es6 syntax. Does not work with IE11 HOT 1
- Remove the core-js dep HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redux-object.