yumike / pointhq Goto Github PK

Hi Mike,

I've found a small problem with your module when the base64 PointHQ auth credentials are longer than 76 characters. The encoded output wraps at this point, which causes the request header to be invalid. You end up with something like this:

GET /zones HTTP/1.1
Host: pointhq.com
accept-encoding: gzip, deflate
content-type: application/json
accept: application/json
authorization: Basic dXNlcm5hbWVAZXhhbXBsZWRvbWFpbi5jb206YWhma2poYXNsa2Rmamhsa2oyMzRpeW9paGZzbGtk
amhma2xzc2pkaGY=
user-agent: Python-httplib2/0.8 (gzip)

Note that the authorization header is wrapped over two lines. The second line is invalid HTTP, and you get a 500 back from the Point API. I've fixed the problem in my own code by stripping newlines from the encoded output so the authorization header uses a single line. This appears to be the approach taken by the Python requests library, and by curl.

I will send a pull request referencing this issue that includes my fix.

Thanks for the great module,
Richard