Code Monkey home page Code Monkey logo

askq's Introduction

Hi there ๐Ÿ‘‹

I'm a software engineer aiming to write clean, maintainable, and reliable software.

Mainly writing code in .NET (C#/VB).

Youssef's github stats

Streak stats

askq's People

Contributors

dependabot[bot] avatar fiseni avatar sucrose0413 avatar youssef1313 avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

askq's Issues

Services implementation issue

Currently, the Services exist in the web project and depend on AppDbContext. However, the Services in eShopOnWeb are placed in ApplicationCore and doesn't depend on AppDbContext.

For complex applications, I think the Services may contain business logic, which wouldn't be ideal to be placed in the web layer.

cc: @fiseni If you got time, I hope you can provide help in this area

IdentityUser exposure

You might start refactoring the usage of IdentityUser in the models:

  • Models should not contain properties of type IdentityUser, just id of the user (in this case guid). Make the property type string. The responsibility of the services would be to reconcile the id with the appropriate user persisted in db (if required for some operation)
  • ViewModels should not contain IdentityUser properties either. Here just add properties that you would show on the view, name, email or whatever. Dont expose more information than needed.

Ps. I'll add other hints tomorrow, kinda late here :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.