boostcamp_android's Introduction
boostcamp_android's People
Contributors
Watchers
boostcamp_android's Issues
과제리뷰
페이스북의 UI를 동일하게 구현함은 좋으나 코드 전반적인 완성도가 떨어짐이 아쉽습니다.
아래는 코드를 리뷰하고 드리는 코멘트 입니다.
- Toolbar를 사용하지 않고 Layout을 직접 잡아서 사용한 부분에 대해서 Toolbar에 대해 조사하고 활용을 해보았으면 좋겠습니다.
- 패키지가 UI, Domain이 분리되어 있지 않는 부분과 도메인 네이밍과 은닉화등에 좀더 신경썼으면 합니다.
- 추가된 리소스 중 미사용되는 리소스들이 너무 많습니다.
- 코드내에 중복코드 및 하드코딩(String)이 많습니다.
- RecyclerView의 DividerItemDecoration을 사용하여 각 아이템의 Margin값을 잡아서 하였으면 합니다.
https://developer.android.com/reference/android/support/v7/widget/DividerItemDecoration.html
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.