Code Monkey home page Code Monkey logo

Comments (4)

si458 avatar si458 commented on July 3, 2024

ok yes i can confirm this issue, will look into it over weekend as running out of time today

from meshcentral.

si458 avatar si458 commented on July 3, 2024

ok just had another quick look and this is not a bug but by design.

allowSavingDeviceCredentials should read Allow users to save SSH, RDP, VNC device credentials on the server

it is not used to share credentials between each user, but rather for each user to save there own credentials.

this is because the backend saves the credentials against the node and used the userid to identify which credentials to use

SO

if user1 saves generic creds,
then user2 saves his own creds,
when user3 says lets see creds,
which credentials would you use?

we would have to display a list of saved credentials, and by which user, then u select which creds to use and use them

so in theory what your asking for is actually a feature request, to allow another option like
allowSharingOfSavedCredentials: true

that way when we see allowSharingOfSavedCredentials == true we can then display all credentials and u pick

rather than just displaying your own credentials

p.s: commit here to fix description 5a7e3d9

from meshcentral.

si458 avatar si458 commented on July 3, 2024

ive also spotted the mstsc.html page which is the Web-RDP should also pre-fill credentials but it doesnt.
this is because its using old code to look for node.rdp.u and node.rdp.p (user/pass)
but the new code saves data in node.rdp[obj.userid].u and node.rdp[obj.userid].p (user/pass)
BUT it also clears legacy credentials

delete node.rdp.u;
delete node.rdp.p;

p.s: old commit here changing from a global store to per user store 753b6c2

p.s: commit here to fixing the mstsc not reading credentials 26ac23c

from meshcentral.

si458 avatar si458 commented on July 3, 2024

duplicate feature request is here - #5285
so will close this for now

from meshcentral.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.