yipit / cron-sentry Goto Github PK

This would make it look nice on PyPI.

Based on raven.Client arguments string_max_length (default is 200) and max_list_length (default is 50): https://raven.readthedocs.org/en/latest/advanced.html#client-arguments

The original project is not being maintained. This fork should be renamed, add a new executable (keep raven-cron too for backwards compatibility purposess), and push to PyPI.

Unfortunately it's not possible to use argparse and force a positional argument to be specified. We should check if the cmd parameter was passed and decide if we exit successfuly or not.

Right now the exception it raises isn't helpful:

$ cron-sentry
Traceback (most recent call last):
  File "/Users/hugo/.virtualenvs/cron-sentry/bin/cron-sentry", line 9, in <module>
    load_entry_point('cron-sentry==0.4.2', 'console_scripts', 'cron-sentry')()
  File "/Users/hugo/projects/cron-sentry/cron_sentry/runner.py", line 72, in run
    if opts.cmd[0] == '--':
IndexError: list index out of range

I'd really like to see an option that would cause gathered data to also be written to syslog. In our case, we write everything to syslog and then forward syslog to a log aggregator. So this would be a great way to get success messages into a place that they can be reviewed if needed while also getting Sentry alerts for known errors.

Bonus points for an option to log as JSON:

cron-sentry --syslog ...
# same as the above
cron-sentry --syslog=plain
# log as json
cron-sentry --syslog=json

If you are interested in this option, I could most likely submit a PR that does the heavy lifting.

There would be reasons to send a limited message to sentry (limited by sting max length option) but still pass stdout and stderr without limiting the length.

When raven gives errors, they are not printed at all. You only get "No handlers could be found for logger "sentry.errors"". There is a PR to fix this.

Currently it's not possible to use have commands that use the shell capabilities. For example, it's not possible to wrap completely the following command with cron-sentry:

ls /dir | mycommand

With cron-sentry it would be possible to wrap the ls /dir part, but not the whole thing (unless cron-sentry is executed twice). So, if the ls command works, but mycommand fails, cron-sentry wouldn't catch it.

The above is true for |, ||, &&, >, >>, etc.

Each list element is a string. For some reason, each string is missing the last character.

hi,
thanks for keep maintaining cron-sentry!
I'd find useful to add job-specific data when using cron-sentry, is it something you'd consider adding? happy to try it too and submit a PR but wanted to know what you think first

thanks!
filippo