yiisoft / router-fastroute Goto Github PK

For example, Route::get('/i/{image}')->name('image').

What steps will reproduce the problem?

Add into RouterFactory

        $router = (new RouterFactory(new FastRouteFactory(), $routes))($container);
        $router->addGroup('/blog', static function (RouteCollectorInterface $r) use (&$container) {
            $r->addRoute(
                Route::get('/index')
                     ->to(new ActionCaller(SiteController::class, 'index', $container))
                     ->name('blog/index')
            );
        });
        return $router;

Go to /blog/index

What is the expected result?

Response with HTTP 200 and index page

What do you get instead?

Response with HTTP 405

Additional info

Works strange with next code:

$router->addGroup('/blog', ... $r->addRoute(Route::get('/') ...) # /blog/

Performs as path /

Good day. After last releases methods generate and generateAbsolute was failed on that string $parameters = array_map('\strval', $parameters); if send multilevel array like this (generated from Yiisoft\Form\FormModel attributes)

[
    'Search' => [
        'address.with_data' => false
        'address.objects.type_ids' => [
            0 => '4'
        ]
        'address.objects.is_active' => true
        'address.pageData.page.source_ids' => [
            0 => '6'
        ]
    ]
]

What steps will reproduce the problem?

Config routes

What is the expected result?

Url successfully generated

What do you get instead?

Error

Additional info

Good afternoon. The basic implementation of UrlGeneratorInterface lacks parameters for __construct(). Thanks in advance

What steps will reproduce the problem?

What is the expected result?

What do you get instead?

Additional info

Test fails:

$urlGenerator = $this->createUrlGenerator([
	Route::get('/home/index')->name('index'),
]);
$urlGenerator->setLocaleParameterName('_locale');
$urlGenerator->setLocales(['uz' => 'uz-UZ', 'en' => 'en-US', 'ru' => 'ru-RU']);

$url = $urlGenerator->generate('index', ['_locale' => 'uz']);

$this->assertEquals('/uz/home/index', $url);

What steps will reproduce the problem?

Route::get('/articles')->name('article')

$urlGenerator->generate('article', [], ['query' => null])

What is the expected result?

/articles

What do you get instead?

/articles?
'?' at the end url

Additional info

Now use yiisoft/router, should be yiisoft/router-fastroute.

See docs:

Parameters should be namespaced with vendor/package-name

What steps will reproduce the problem?

config/routes.php

Route::get('/images/{file}')
    ->name('images')
    ->host('example.com'),

view

var_dump($url->generateAbsolute('images', ['file' => 'test.png']));

What is the expected result?

string(29) "//example.com/images/test.png"

What do you get instead?

string(27) "example.com/images/test.png"

Additional info

Currently Route's host isn't taken into account when matching. It should be implemented.

See https://github.com/yiisoft/router/blob/master/src/Route.php#L310

Proposal to not add not substituted arguments if they a not in route. I think this not need here, in UrlGenerator::generate() has the separate argument for query string. If it ok, I can make PR.

What steps will reproduce the problem?

// routes
Route::get('/view/{mode}')->name('view');

$urlGenerator->setDefaultParameter('mode', 'simple');
$urlGenerator->setDefaultParameter('type', 'any');

$urlGenerator->generate('view');

What is the expected result?

/view/simple

What do you get instead?

/view/simple?type=any

Additional info

What steps will reproduce the problem?

For the code below, I would expect to use the default value when I use NULL when generating.

        $routes = [
            Route::get('/view/{test:\w+}')->name('view')->defaults([
                'test' => 'test'
            ]),
        ];
        $routerCollector = $this->createRouterCollector($routes);

        $url = $routerCollector->generate('view', ['test' => null]);

        $this->assertEquals('/view/test', $url);

this would be particularly useful for the following uses:

$url = $routerCollector->generate('view', ['name' => $any->name ?? null]);

What is the expected result?

success

What do you get instead?

RuntimeException: Route `view` expects at least parameter values for [test], but received [test]

Additional info

• configuration file
• fix badge in readme