yihangho / emoji-for-jekyll Goto Github PK

Seems to only handle page body. (It is really great).

HI, could you please provide some examples of syntax for integrating the emojis in blog text?

Exactly as it sounds, emojis do not render in excerpts.

hi @yihangho
I'm using your pluggin with jekyll and it's fun.
It works fine for rendering pages at the root of my site and also into posts.
But seems not working with pages in collections, something to do ?

regards

Copied over *rb and json to _plugins. Works locally but not on prod. My site is deployed on github.

Hi,

I'm new to Ruby. Just curious how to call this plugin from another plugin? I'd like to apply your code to a string of markdown text.

Thanks!

My blog isn't located at the root of my webspace but in a subdirectory. So I've set the baseurl accordingly in my _config.yml.
After installing your plugin and trying to use emoji from a local directory instead of including them from GitHub I've noticed that the plugin correctly found the image files in the local directory but generated the wrong URL for the img-tags: The baseurl-part of the URL was missing.
Adding the baseurl to emoji-images-path didn't work either as the look up of the local image files failed that way.

As a start here's my quick&dirty patch:

diff --git a/_plugins/emoji_for_jekyll.rb b/_plugins/emoji_for_jekyll.rb
index 39eb05d..1d0f04b 100644
--- a/_plugins/emoji_for_jekyll.rb
+++ b/_plugins/emoji_for_jekyll.rb
@@ -38,7 +38,7 @@ module EmojiForJekyll
         Dir.foreach(images_dir) do |image_filename|
           if /^(?<tag>.*)\.(?:svg|png|jpg|jpeg|gif)/ =~ image_filename
             @master_whitelist << tag
-            @images_path[tag] = File.join("/", images_path, image_filename)
+            @images_path[tag] = File.join("/", site.config["baseurl"], images_path, image_filename)
           end
         end

This solved the problem for me but obviously needs some additional checking if baseurl exists at all.

Sorry for not just providing a merge request with a final solution, but I don't really know Ruby and just don't want to deliver a botched C++-style solution. 😉

Hello,

I placed emoji_for_jekyll.rb and emoji.json into _plugins.
In _config.yaml I added emoji: true. In a post I edited the text and added :smile: into it. When using jekyll build then it gets not changed to a img element.
What am I doing wrong?
I am using the latest version of that plugin from here and jekyll is version jekyll 3.1.6.

You can view the page at: https://github.com/wirehack7/capsop.com