yi-jiayu / bus-eta-bot Goto Github PK

In Bus Eta Bot v2 there was a "Resend" button on eta messages which would cause the bot to resend the eta message as a new message, bumping it to the end of the conversation.

Backlog

• Announcements for service disruptions
• Scheduled ETA messages
• Improved favourites
• Automated, regular bus stop data updates
• Remove appengine dependency

The Bus Arrival API v1 endpoint will be removed on 31st October. We need to change over to the v2 endpoint and implement the missing functionality before that, and hopefully add some new features at the same time.

Travis CI has served Bus Eta Bot well for years, but with the recent intermittent timeouts on Travis, its recent acquisition, how far other services like Semaphore CI and CircleCI have come, it's time to experiment a little.

Seems like data all is not giving all the bus eta timings any more?

Kenneth Lim:
Opp Cycle & Carriage (20059)
AYE
| Svc | Next |  2nd |  3rd |
|-----|------|------|------|
| 154 |    4 |   14 |   22 |
| 198 |   15 |   24 |    ? |
| 201 |    5 |   18 |   25 |
Showing 3 out of 3 services for this bus stop.

Last updated at 14 Sep 18 20:49 SGT

Last time:

Kenneth Lim:
Opp Cycle & Carriage (20059)
AYE
| Svc | Next |  2nd |  3rd |
|-----|------|------|------|
| 154 |    0 |    3 |   15 |
| 197 |    6 |   10 |   19 |
| 198 |    0 |    2 |    6 |
| 201 |    3 |   14 |   27 |
| 97  |    0 |    8 |   17 |
Showing 5 out of 5 services for this bus stop.

Last updated at 07 Dec 17 07:01 SGT

When updating messages in response to a refresh callback query, if the updated message content is unchanged, the request to the Telegram Bot API editMessageText endpoint returns an error:

{
    "ok": false,
    "error_code": 400,
    "description": "Bad Request: message is not modified"
}

This does not affect the end user, since the answerCallbackQuery request still succeeds and the updated etas are the same, but perhaps the unnecessary editMessageText request could be skipped in such cases.

Go 1.8 on App Engine Standard recently went GA: https://cloudplatform.googleblog.com/2017/10/announcing-Go-1-8-on-App-Engine-Standard-Environment.html

We should try to update to the new runtime. There shouldn't be too many changes required.

On smaller phones, or if a user's text size in Telegram is large enough, the table that etas are presented in may wrap and become unreadable:

There should be a way for users to fall back to the more compact eta layout without dividers in this case.

It looks like some bus stop information has been updated since the data used by Bus Eta Bot was populated, for example:

  {
    "BusStopCode": "56099",
    "RoadName": "Upp Thomson Rd",
-    "Description": "Opp Former Seletar Inst",
+    "Description": "Aft Springleaf Rd",
    "Latitude": 1.39606817759915,
    "Longitude": 103.8188299218487
  },

  {
    "BusStopCode": "92141",
    "RoadName": "East Coast Rd",
-    "Description": "Ocean Apts",
-    "Latitude": 1.30920026668367,
-    "Longitude": 103.91306896175426
+    "Description": "Nafa Arts Kindergarten",
+    "Latitude": 1.30939538245506,
+    "Longitude": 103.91428724575974
  },

It would be good to refresh this information on a regular basis, perhaps monthly.

Not sure why this is happening but all requests to the Telegram API from App Engine are returning DEADLINE_EXCEEDED errors. Changed webhook to point at v2.2.0 Cloud Function in the meantime.

Currently, the bot responds to a /start command with a welcome message which teaches users how to get etas for a single bus stop and search for bus stops using an inline query. However, this does not showcase the other bot features and may be too much text at once. Maybe a multiple-step tutorial may be more effective.

Version 2 of the DataMall Bus Arrival API now includes the type of the bus (whether it is a double or single decked or bendy), in addition to the bus load (seats available, standing available or limited standing) and whether the bus is wheelchair-accessible. This information could be useful for users.

Bus Eta Bot hasn't been updated in some time, but I was thinking of giving it some attention again soon. Here are some goals I have in mind for the next release:

• Simplification
  • Remove unused features like group chat support (superseded by inline messages)
  • Massively reduce LOCs
• Announcements
  • Mainly to inform users about Datamall outages, eg. during the recent F1
• Bus routes information
  • Ever since the transition to the bus arrival API v2, Datamall does not show buses which aren't in service. It's finally time to include this missing data for bus stops.

Not sure why this is happening but all requests to the Telegram API from App Engine are returning DEADLINE_EXCEEDED errors. Changed webhook to point at v2.2.0 Cloud Function in the meantime.