Code Monkey home page Code Monkey logo

pe's People

Contributors

yeppog avatar

Watchers

 avatar

pe's Issues

Application may not be feasible for real world use

From the UG:

image.png

We would assume the target audience to not be particularly technologically savvy, and they would process many patients per day due to the COVID-19 situation in Singapore.

In this case, the GUI only serves as means to view, but there is no GUI functionality for the CLI actions. Given that the users of the application may not be technologically savvy, having CLI as the only means of operations could render the application very much unlikely to be used since. Furthermore, with no means of repeating actions, importing from external sources, the data processing method is extremely tedious and not feasible for the scale the application is set out to be built for.

While I understand that it is optimised for CLI use, the GUI only serves as a display means, which could be easily done through CLI eitherways.

Lastly, the target audience of this application may not be the most correct, as it is meant for contact tracing personnel, but is only built for people who prefer CLI.

Unable to add phone number with country code.

Given that this is a app for tracking, it is not safe to assume that every single person being added will have a phone number belonging to the same country code, in this case Singapore, hence country codes should be allowed in the phone number field.

image.png

Bad performance when using find and list.

find takes a considerable amount of time to look through the list to filter. It took me about 2-3 seconds to return all results.

list ends up taking about 5-8 seconds to reset the filter with a size of only 20 contacts. Given that this is an app to trace covid patients and that the covid infection rate in singapore is very high, this app would be unable to support the scale required. Furthermore, given that the limit is 6 digit for the case number, I would be expecting smooth operation for up to 999999 cases.

Find feature slightly limited

find is not able to look through all possible fields of Person, which may be troublesome if there is a need to search through NOK names or NOK phone number.

image.png

Unable to view full string

image.png

In the above example, if a user has a long address, it is not possible to view the entirety of it. Furthermore, the app width is fixed and cannot be expanded, hence there is absolutely no way of viewing the address other than going into track2gather.json, which defeats the purpose of the app due to to poor UX.

Cluttering in Command summary

image.png

The example and command format could have been separated into different columns to increase readability.

e.g

Action Command Example
Add add n/NAME p/PHONE_NUMBER e/EMAIL cn/CASE_NUMBERha/HOME_ADDRESS [wa/WORK_ADDRESS] [qa/QUARANTINE_ADDRESS][sh/SHN_PERIOD] [kn/NEXT_OF_KIN_NAME] [kp/NEXT_OF_KIN_PHONE][ka/NEXT_OF_KIN_ADDRESS] add n/Charlie p/12345678 e/[email protected] cn/2103ha/123 Changi Road #01-100 700123 wa/50 Jurong Road 120050qa/12 Harbourfront Ring 123012 sh/2021-01-01 2021-01-14kn/Peter kp/90011234 ka/73 Yishun Drive #10-301 310073
List list

Overall experience rather choppy (high ram usage)

image.png
2021-11-12 17-06-53.mp4

The application runs rather choppily (really laggy while scrolling as seen in the video) with only 50 people in the list. Furthermore, it is taking up 2gb of my ram with only 50 contacts, even chrome with 23 tabs doesnt take up that much ram. This is a huge issue if the application is to be used by contact tracing personnel, as their computers might not be capable to handle this much load, especially when there are way more contacts to be involved in a real situation.

image.png

Inaccuracy in json behaviour.

image.png

A new .json file is not actually generated until the first command is input. The original .json file stays in the folder until the app writes something to a new .json file.

Unable to expand window

image.png

The application has a fixed width and it is frustrating to use such a small window on a big monitor. The window width show be allowed to be flexible to cater to different users.

Furthermore, it cant be shrunk either, which means users with low resolution screens, e.g 800x600 may be unable to use the application properly

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.