In the welcome message we're making multiple references to the jQuery plugins registry and publishing plugins in there. That doesn't really make sense anymore, since the plugins site is currently in "read-only mode".

Hi!
The generator scaffolds out a collection method, a static method, default options for the static method and a custom selector. In order to use the static method's default options in the collection method, I'm guessing I'd pass an options argument and then do options = $.extend({}, $.myplugin.options, options); like is done in the static method?

If so, this should maybe be clarified (or options passed to the collection method as they're currently done to the static method). I'm not a total neophyte in terms of writing jQuery plugins, but I found the scaffolded code confusing enough to stop me for a moment...

Right now, due to its really basic usage of grunt-jquery-init, it seems generator-jquery doesn't fully leverage the power of Yeoman to scaffold out the desired plugin.

For instance, if all you want to build is a collection-based plugin, the static method and selector methods will be unpopulated and probably ultimately removed. In fact, if you've never coded a jQuery plugin and are looking to the generator with the intent of learning best practices, the extra methods might even be confusing.

One solution would be to add a prompt asking which scaffolds the user wants added to name.js. If this is desirable, let me know and I'll write a pull request later.

Thanks!

In the generator template for the .html file, the path to qunit resources are set to "../bower_components/qunit/qunit.js" and "../bower_components/qunit/qunit.css"

This seems to have changed. QUnit (v1.11.0) now contains three subfolders addons, qunit and test.
So the path needs to be updated to:

"../bower_components/qunit/qunit/qunit.js"
"../bower_components/qunit/qunit/qunit.css"

No big deal, but not easy to spot when it's late at night. ;)

In the generated Gruntfile the configuration for uglify is as follows:

uglify: { options: { banner: '<%= banner %>' }, dist: { src: '<%= concat.dist.dest %>', dest: 'dist/jquery.<%= pkg.name %>.min.js' } },

I believe uglify.dist.src should be <%= concat.dist.src %>

According to the docs for jQuery Boilerplate, there're two simple changes that could be added to improve performance and compatibility:

1. Add a semicolon before the enclosure to prevent issues with script minification and concatenation
2. Pass window and undefined to the enclosure, improving resolution time slightly.

Any thoughts? Will write a pull request if this is thought to be desirable.

By default, the generated source JavaScript has syntax errors.

yo jquery vanilla
// ...
grunt

And I get this output:

Running "jshint:gruntfile" (jshint) task

✔ No problems


Running "jshint:src" (jshint) task

src/yo-jquery-vanilla.js
  line 10  col 9   Expected an identifier and instead saw '='.
  line 18  col 6   Expected an identifier and instead saw '='.
  line 20  col 30  Expected an identifier and instead saw '.'.
  line 26  col 5   Expected an identifier and instead saw '.'.
  line 31  col 16  Expected an identifier and instead saw '='.

  ✖  5 errors  ⚠  0 warnings

Warning: Task "jshint:src" failed. Use --force to continue.

Aborted due to warnings.

because

cat src/yo-jquery-vanilla.js

/*
 * 
 * 
 *
 * Copyright (c) 2015 
 * Licensed under the MIT license.
 */
(function ($) {
  // Collection method.
  $.fn. = function () {
    return this.each(function (i) {
      // Do something to each selected element.
      $(this).html('' + i);
    });
  };

  // Static method.
  $. = function (options) {
    // Override default options with passed-in options.
    options = $.extend({}, $..options, options);
    // Return the name of your plugin plus a punctuation character.
    return '' + options.punctuation;
  };

  // Static method default options.
  $..options = {
    punctuation: '.'
  };

  // Custom selector.
  $.expr[':']. = function (el) {
    return $(el).text() === 'awesome test markup';
  };
}(jQuery));

Not sure what the best way to fix this in context is, but if you bower install jQuery ~> 1.11, jquery.js is moved into a dist subdir and causes the default install tests to fail

$ yo jquery -v
1.1.2

$ npm list -g | grep generator-jquery
├─┬ [email protected]

# SNIPPED: `yo jquery` # fill out form w/ 1.10.2

$ grunt test
# ... snip / success ...

$ find bower_components | grep /jquery.js$
bower_components/jquery/jquery.js
bower_components/jquery/test/jquery.js

$ bower install jquery#1.11.0
# ... snip success ...

$ find bower_components | grep /jquery.js$
bower_components/jquery/dist/jquery.js
bower_components/jquery/src/jquery.js

$ grunt test
# ... snip successes ...

Running "qunit:all" (qunit) task
Testing http://localhost:9000/test/a.html FFF
>> global failure
>> Message: ReferenceError: Can't find variable: jQuery
>> http://localhost:9000/src/a.js:38

>> global failure
>> Message: ReferenceError: Can't find variable: jQuery
>> http://localhost:9000/test/a_test.js:62

>> global failure
>> Message: ReferenceError: Can't find variable: jQuery
>> http://localhost:9000/test/a.html:17

Warning: 3/3 assertions failed (21ms) Use --force to continue.

Aborted due to warnings.

the default grunt task shows an error with phantomjs because connect is missing (compare to "test" task):

wrong:

grunt.registerTask('default', ['jshint', 'qunit', 'clean', 'concat', 'uglify']);

correct:

grunt.registerTask('default', ['jshint', 'connect', 'qunit', 'clean', 'concat', 'uglify']);

Started at: e904aab

I get this error when i'm trying to install using "yo jquery"

/usr/lib/node_modules/generator-jquery/app/index.js:52
if (!available.bower && !available.npm) {
^
TypeError: Cannot read property 'bower' of undefined
at /usr/lib/node_modules/generator-jquery/app/index.js:52:23
at /usr/lib/node_modules/generator-jquery/node_modules/pkg-name/index.js:25:4
at callback (/usr/lib/node_modules/generator-jquery/node_modules/pkg-name/node_modules/each-async/each-async.js:54:12)
at /usr/lib/node_modules/generator-jquery/node_modules/pkg-name/node_modules/each-async/each-async.js:23:7
at /usr/lib/node_modules/generator-jquery/node_modules/pkg-name/index.js:16:5
at /usr/lib/node_modules/generator-jquery/node_modules/pkg-name/node_modules/npm-name/index.js:14:5
at ClientRequest. (/usr/lib/node_modules/generator-jquery/node_modules/pkg-name/node_modules/npm-name/node_modules/got/index.js:47:5)
at ClientRequest.g (events.js:180:16)
at ClientRequest.emit (events.js:95:17)
at HTTPParser.parserOnIncomingClient as onIncoming

(my first contribution to open source, hope I'm doing everything right. Sorry if I don't!)

When testing my plugin using the basic QUnit testcase I get, I feel like I'm not really testing well. My plugin is only getting tested against the jQuery version I gave up although it should test on every supported version. For example if I say my plugin supports 1.9 and later, I want it to be tested on:

• 1.9 and all its patch releases
• 1.10 and all its patch releases
• 1.11 and all its patch releases
• 2 and all its patch releases
• 2.1 and all its patch releases
• jQuery 3.0 via the git cdn they have, so I'm sure my plugin doesn't break when they release.
• jQuery 3.0 compat via the git cdn they have, so I'm sure my plugin doesn't break when they release.

I know that jQuery UI and jQuery Mobile have CI setup to test this, but I have not dug into how they do that. Sorry therefor but I'm not that of a grunt pro.

If I'm going way too in here or am just asking for way to complicated stuff sorry. If you don't want to integrate this into the main templates, maybe consider a recipe similar to other generators? Thank you for this generator and thanks for building Yeoman.

This is just for documentation if anyone stumbles upon this error:

TypeError: Cannot read property 'bold' of undefined
    at Object.<anonymous> (/usr/local/lib/node_modules/generator-jquery/node_modules/yeoman-generator/lib/util/common.js:5:56)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/usr/local/lib/node_modules/generator-jquery/node_modules/yeoman-generator/lib/base.js:91:26)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)

The cause was fixed in yeoman-generator 0.13.3, and dependency to that version was updated in generator-jquery 0.0.4, which isn't published yet.

Workaorund until then is to clone the latest version locally and do a

git clone https://github.com/yeoman/generator-jquery.git
cd generator-jquery
npm link

see also yeoman/generator-webapp#137

Where are we in terms of the rewrite's completeness compared to grunt-init-jquery? Are we currently still waiting to land the new prompts system before making changes? I've been holding off on making changes for this latter part otherwise I think we could work on wrapping and testing all of these ports up next week. Sound good?

Generator version: 1.1.0
I'm using proxy.

Run yo jquery, always press ENTER, got an undefined before the welcome message:

undefined"Project Name" should not contain "jquery" or "js" and should be a unique ID not already in use at plugins.jquery.com. "Project title" should be a human-readable title, and doesn't need to contain the word "jQuery", although it may. For example, a plugin titled "Awesome Plugin" might have the name "awesome-plugin".

Then got the ERROR:

/usr/local/lib/node_modules/generator-jquery/app/index.js:47
          if (!available.npm || !available.bower) {
                        ^
TypeError: Cannot read property 'npm' of undefined
    at /usr/local/lib/node_modules/generator-jquery/app/index.js:47:25
    at /usr/local/lib/node_modules/generator-jquery/node_modules/pkg-name/index.js:25:4
    at callback (/usr/local/lib/node_modules/generator-jquery/node_modules/pkg-name/node_modules/each-async/index.js:33:4)

After canceled the proxy, the ERROR gone, but this.yeoman still got undefined, before the welcome message.

As nice and straight-forward as the example code generated is, everything is "awesome". This thus requires the user to go through and replace every instance of "awesome" with whatever they called their plugin.

Without changing anything else in the generated code, changing "awesome" to whatever the user enters into the initial prompt would greatly improve the utility and ease-of-use of this generator.

Let me know if you want a pull request... Thanks!

Running "qunit:all" (qunit) task
Testing http://localhost:9000/test/jquery.html FFFF

jQuery#awesome - is chainable
Message: Died on test #1 at http://localhost:9000/bower_components/qunit/qunit/qunit.js:425
at http://localhost:9000/test/jquery_test.js:34
at http://localhost:9000/test/jquery_test.js:62: 'undefined' is not a function (evaluating 'this.elems.awesome()')
TypeError: 'undefined' is not a function (evaluating 'this.elems.awesome()')

jQuery#awesome - is awesome
Message: Died on test #1 at http://localhost:9000/bower_components/qunit/qunit/qunit.js:425
at http://localhost:9000/test/jquery_test.js:39
at http://localhost:9000/test/jquery_test.js:62: 'undefined' is not a function (evaluating 'this.elems.awesome()')
TypeError: 'undefined' is not a function (evaluating 'this.elems.awesome()')

jQuery.awesome - is awesome
Message: Died on test #1 at http://localhost:9000/bower_components/qunit/qunit/qunit.js:425
at http://localhost:9000/test/jquery_test.js:47
at http://localhost:9000/test/jquery_test.js:62: 'undefined' is not a function (evaluating '$.awesome()')
TypeError: 'undefined' is not a function (evaluating '$.awesome()')

jQuery.awesome - is awesome
Message: Expected 2 assertions, but 1 were run
at http://localhost:9000/bower_components/qunit/qunit/qunit.js:425
at http://localhost:9000/test/jquery_test.js:47
at http://localhost:9000/test/jquery_test.js:62

:awesome selector - is awesome
Message: Died on test #1 at http://localhost:9000/bower_components/qunit/qunit/qunit.js:425
at http://localhost:9000/test/jquery_test.js:60
at http://localhost:9000/test/jquery_test.js:62: Syntax error, unrecognized expression: unsupported pseudo: awesome
Error: Syntax error, unrecognized expression: unsupported pseudo: awesome

Warning: 5/5 assertions failed (243ms) Use --force to continue.

Aborted due to warnings.